[JBoss JIRA] (DROOLS-5029) Loose of focus after cloasing Collection Editor
by Anna Dupliak (Jira)
Anna Dupliak created DROOLS-5029:
------------------------------------
Summary: Loose of focus after cloasing Collection Editor
Key: DROOLS-5029
URL: https://issues.redhat.com/browse/DROOLS-5029
Project: Drools
Issue Type: Enhancement
Components: Scenario Simulation and Testing
Affects Versions: 7.33.0.Final
Reporter: Anna Dupliak
Assignee: Daniele Zonca
When user finishes with editing collections, using Collection Editor and push *Close* or *Save* or *Cansel* then Grid of Test scenario is loosing focus and user unable to navigate it by keyboard.
Suggested behaviour:
When Collection Editor disappears after editing Collection cell A then focus should be on the cell of A.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (DROOLS-5009) DMN Designer convert java class with invalid DMN identiefier
by Jozef Marko (Jira)
[ https://issues.redhat.com/browse/DROOLS-5009?page=com.atlassian.jira.plug... ]
Jozef Marko commented on DROOLS-5009:
-------------------------------------
I prefer to contact UX, or at least confirm the text shown to user with someone.
> DMN Designer convert java class with invalid DMN identiefier
> ------------------------------------------------------------
>
> Key: DROOLS-5009
> URL: https://issues.redhat.com/browse/DROOLS-5009
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.33.0.Final
> Reporter: Jozef Marko
> Assignee: Daniel José dos Santos
> Priority: Minor
> Labels: drools-tools
> Attachments: Screenshot from 2020-02-05 16-21-10.png
>
>
> There is an issue if user convert java class to DMN data type while the java class contains field name, that is invalid identifier for DMN.
> for example assume this java class and try to convert it into DMN data type, you will get an error as attached.
> {code:java}
> public class Address {
> private int number;
> }
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (DROOLS-4967) decision table rules are not loaded into kiebase
by Volodymyr Shymkiv (Jira)
[ https://issues.redhat.com/browse/DROOLS-4967?page=com.atlassian.jira.plug... ]
Volodymyr Shymkiv updated DROOLS-4967:
--------------------------------------
Attachment: DROOLS-4967_package_highlight.png
> decision table rules are not loaded into kiebase
> ------------------------------------------------
>
> Key: DROOLS-4967
> URL: https://issues.redhat.com/browse/DROOLS-4967
> Project: Drools
> Issue Type: Bug
> Components: decision tables
> Affects Versions: 7.21.0.Final, 7.22.0.Final, 7.23.0.Final, 7.24.0.Final, 7.25.0.Final, 7.26.0.Final, 7.27.0.Final, 7.28.0.Final, 7.29.0.Final, 7.30.0.Final, 7.31.0.Final
> Reporter: Volodymyr Shymkiv
> Assignee: Mario Fusco
> Priority: Blocker
> Attachments: CanDrink2.xls, CanNotDrink2.xls, DROOLS-4967_package_highlight.png
>
>
> When compiling xls decision table, wrong ruleset name is parsed from the xls file. This can lead to multiple issues, like rules being filtered out by kmodule.xml configuration.
> According to documentation, decision table begins with a cell at second or third column, having value RuleSet. The cell on the right of this one contains the name of the rule set, which we want to use as a package name.
> The problem lies in naive approach to parsing the package name from the xls file. As you can see in project drools-compiler, class org.drools.compiler.kie.builder.impl.KieBuilderImpl method packageNameFromDtable, it execute as follows:
> # find "RuleSet" string in the binary data
> # find and return the nearest string which can act as a valid java package name
> The problem is, the string returned from packageNameFromDtable is NOT the value of the cell next to the RuleSet. It is actually a value of a random cell.
> To understand the problem, we need to understand the binary content of the actual xls file. Every cell is presented as a few bytes, containing cell's value, position, and other information. The "problematic" thing here is, the _order_ of the cells in the binary data is NOT constant. BUT the code really just reads the cell _binary_ next to the "RuleSet" cell.
> Problem is present since version 7.21 as it is caused by a fix for DROOLS-3888 - commit 9a179b6e6b955889200b0258ccd18cd1a5f14b46
> In our case, this results in rules not being loaded, as they are filtered out by kmodule.xml configuration. We have a lot of decision tables we want to migrate from an older drools version, and most of them are now ignored due to this bug.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (DROOLS-4967) decision table rules are not loaded into kiebase
by Volodymyr Shymkiv (Jira)
[ https://issues.redhat.com/browse/DROOLS-4967?page=com.atlassian.jira.plug... ]
Volodymyr Shymkiv reopened DROOLS-4967:
---------------------------------------
Please see attached image to understand.
The problem of your code is that you do assume that if you see "RuleSet" in the cell right before cell with package name ("org.drools.simple.candring") then you will get in bytecode with "RuleSet" with "org.drools.simple.candring" (package name) followed (ignoring several chars).
This is completely wrong projection.
You can try or see on the image attached excel files and its "source" so you can see it is different. Excel writes the content based on history not on the display order. So you can see while it is displayed the same way in excel it has completely different "source" byte stream. Of course you can see it not only on the picture but in the files previously attached itself.
> decision table rules are not loaded into kiebase
> ------------------------------------------------
>
> Key: DROOLS-4967
> URL: https://issues.redhat.com/browse/DROOLS-4967
> Project: Drools
> Issue Type: Bug
> Components: decision tables
> Affects Versions: 7.21.0.Final, 7.22.0.Final, 7.23.0.Final, 7.24.0.Final, 7.25.0.Final, 7.26.0.Final, 7.27.0.Final, 7.28.0.Final, 7.29.0.Final, 7.30.0.Final, 7.31.0.Final
> Reporter: Volodymyr Shymkiv
> Assignee: Mario Fusco
> Priority: Blocker
> Attachments: CanDrink2.xls, CanNotDrink2.xls, DROOLS-4967_package_highlight.png
>
>
> When compiling xls decision table, wrong ruleset name is parsed from the xls file. This can lead to multiple issues, like rules being filtered out by kmodule.xml configuration.
> According to documentation, decision table begins with a cell at second or third column, having value RuleSet. The cell on the right of this one contains the name of the rule set, which we want to use as a package name.
> The problem lies in naive approach to parsing the package name from the xls file. As you can see in project drools-compiler, class org.drools.compiler.kie.builder.impl.KieBuilderImpl method packageNameFromDtable, it execute as follows:
> # find "RuleSet" string in the binary data
> # find and return the nearest string which can act as a valid java package name
> The problem is, the string returned from packageNameFromDtable is NOT the value of the cell next to the RuleSet. It is actually a value of a random cell.
> To understand the problem, we need to understand the binary content of the actual xls file. Every cell is presented as a few bytes, containing cell's value, position, and other information. The "problematic" thing here is, the _order_ of the cells in the binary data is NOT constant. BUT the code really just reads the cell _binary_ next to the "RuleSet" cell.
> Problem is present since version 7.21 as it is caused by a fix for DROOLS-3888 - commit 9a179b6e6b955889200b0258ccd18cd1a5f14b46
> In our case, this results in rules not being loaded, as they are filtered out by kmodule.xml configuration. We have a lot of decision tables we want to migrate from an older drools version, and most of them are now ignored due to this bug.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (DROOLS-4894) DomainClassesMetadata java files are created under directories with dot separated name
by Toshiya Kobayashi (Jira)
[ https://issues.redhat.com/browse/DROOLS-4894?page=com.atlassian.jira.plug... ]
Toshiya Kobayashi commented on DROOLS-4894:
-------------------------------------------
Yes, I'll move this to KOGITO and assign this to me.
> DomainClassesMetadata java files are created under directories with dot separated name
> --------------------------------------------------------------------------------------
>
> Key: DROOLS-4894
> URL: https://issues.redhat.com/browse/DROOLS-4894
> Project: Drools
> Issue Type: Bug
> Components: executable model
> Affects Versions: 7.31.0.Final
> Reporter: Toshiya Kobayashi
> Assignee: Luca Molteni
> Priority: Minor
>
> DomainClassesMetadataXXX java source files are created under directories with dot separated name instead of usual package hierarchy. It doesn't seem to cause issues though.
> For example, when I run kogito-examples/drools-quarkus-unit-example
> {noformat}
> $ mvn clean package
> ...
> $ tree target/generated-sources/
> target/generated-sources/
> ├── annotations
> └── kogito
> ├── org
> │ ├── drools
> │ │ └── project
> │ │ └── model
> │ │ ├── ProjectModel.java
> │ │ └── ProjectRuntime.java
> │ └── kie
> │ └── kogito
> │ ├── examples
> │ │ ├── ApplicationConfig.java
> │ │ └── Application.java
> │ ├── queries
> │ │ ├── AdultUnitDTO.java
> │ │ ├── AdultUnitQueryFindAdultNamesEndpoint.java
> │ │ ├── AdultUnitQueryFindAdultsEndpoint.java
> │ │ ├── AdultUnitQueryFindNotAdultNamesAndAgeEndpoint.java
> │ │ ├── AdultUnitRuleUnitInstance.java
> │ │ ├── AdultUnitRuleUnit.java
> │ │ ├── RulesF894883E1030542FEFCE9860F835B9B7_AdultUnit.java
> │ │ ├── RulesF894883E1030542FEFCE9860F835B9B7_AdultUnitRuleMethods0.java
> │ │ └── RulesF894883E1030542FEFCE9860F835B9B7.java
> │ └── rules
> │ └── alerting
> │ ├── LoggerServiceRuleUnitInstance.java
> │ ├── LoggerServiceRuleUnit.java
> │ ├── MonitoringServiceRuleUnitInstance.java
> │ ├── MonitoringServiceRuleUnit.java
> │ ├── Rules4723952D402A230BDB0E7081EBBA10E2.java
> │ ├── Rules4723952D402A230BDB0E7081EBBA10E2_LoggerService.java
> │ ├── Rules4723952D402A230BDB0E7081EBBA10E2_LoggerServiceRuleMethods0.java
> │ ├── Rules4723952D402A230BDB0E7081EBBA10E2_MonitoringService.java
> │ └── Rules4723952D402A230BDB0E7081EBBA10E2_MonitoringServiceRuleMethods0.java
> ├── org.kie.kogito.queries
> │ └── DomainClassesMetadataF894883E1030542FEFCE9860F835B9B7.java
> └── org.kie.kogito.rules.alerting
> └── DomainClassesMetadata4723952D402A230BDB0E7081EBBA10E2.java
> {noformat}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (DROOLS-4894) DomainClassesMetadata java files are created under directories with dot separated name
by Luca Molteni (Jira)
[ https://issues.redhat.com/browse/DROOLS-4894?page=com.atlassian.jira.plug... ]
Luca Molteni commented on DROOLS-4894:
--------------------------------------
Let's move this to Kogito WDYT?
> DomainClassesMetadata java files are created under directories with dot separated name
> --------------------------------------------------------------------------------------
>
> Key: DROOLS-4894
> URL: https://issues.redhat.com/browse/DROOLS-4894
> Project: Drools
> Issue Type: Bug
> Components: executable model
> Affects Versions: 7.31.0.Final
> Reporter: Toshiya Kobayashi
> Assignee: Luca Molteni
> Priority: Minor
>
> DomainClassesMetadataXXX java source files are created under directories with dot separated name instead of usual package hierarchy. It doesn't seem to cause issues though.
> For example, when I run kogito-examples/drools-quarkus-unit-example
> {noformat}
> $ mvn clean package
> ...
> $ tree target/generated-sources/
> target/generated-sources/
> ├── annotations
> └── kogito
> ├── org
> │ ├── drools
> │ │ └── project
> │ │ └── model
> │ │ ├── ProjectModel.java
> │ │ └── ProjectRuntime.java
> │ └── kie
> │ └── kogito
> │ ├── examples
> │ │ ├── ApplicationConfig.java
> │ │ └── Application.java
> │ ├── queries
> │ │ ├── AdultUnitDTO.java
> │ │ ├── AdultUnitQueryFindAdultNamesEndpoint.java
> │ │ ├── AdultUnitQueryFindAdultsEndpoint.java
> │ │ ├── AdultUnitQueryFindNotAdultNamesAndAgeEndpoint.java
> │ │ ├── AdultUnitRuleUnitInstance.java
> │ │ ├── AdultUnitRuleUnit.java
> │ │ ├── RulesF894883E1030542FEFCE9860F835B9B7_AdultUnit.java
> │ │ ├── RulesF894883E1030542FEFCE9860F835B9B7_AdultUnitRuleMethods0.java
> │ │ └── RulesF894883E1030542FEFCE9860F835B9B7.java
> │ └── rules
> │ └── alerting
> │ ├── LoggerServiceRuleUnitInstance.java
> │ ├── LoggerServiceRuleUnit.java
> │ ├── MonitoringServiceRuleUnitInstance.java
> │ ├── MonitoringServiceRuleUnit.java
> │ ├── Rules4723952D402A230BDB0E7081EBBA10E2.java
> │ ├── Rules4723952D402A230BDB0E7081EBBA10E2_LoggerService.java
> │ ├── Rules4723952D402A230BDB0E7081EBBA10E2_LoggerServiceRuleMethods0.java
> │ ├── Rules4723952D402A230BDB0E7081EBBA10E2_MonitoringService.java
> │ └── Rules4723952D402A230BDB0E7081EBBA10E2_MonitoringServiceRuleMethods0.java
> ├── org.kie.kogito.queries
> │ └── DomainClassesMetadataF894883E1030542FEFCE9860F835B9B7.java
> └── org.kie.kogito.rules.alerting
> └── DomainClassesMetadata4723952D402A230BDB0E7081EBBA10E2.java
> {noformat}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (DROOLS-4894) DomainClassesMetadata java files are created under directories with dot separated name
by Toshiya Kobayashi (Jira)
[ https://issues.redhat.com/browse/DROOLS-4894?page=com.atlassian.jira.plug... ]
Toshiya Kobayashi edited comment on DROOLS-4894 at 2/10/20 2:14 AM:
--------------------------------------------------------------------
Now I see that 7.33.0-SNAPSHOT kie-maven-plugin writes DomainClassesMetadata java to the right path. 8.0.0-SNAPSHOT kogito-maven-plugin still has the issue (dot separated name).
was (Author: tkobayashi):
Now I see that 7.33.0-SNAPSHOT kie-maven-plugin writes DomainClassesMetadata java to the right path. 7.33.0-SNAPSHOT kogito-maven-plugin still has the issue (dot separated name).
> DomainClassesMetadata java files are created under directories with dot separated name
> --------------------------------------------------------------------------------------
>
> Key: DROOLS-4894
> URL: https://issues.redhat.com/browse/DROOLS-4894
> Project: Drools
> Issue Type: Bug
> Components: executable model
> Affects Versions: 7.31.0.Final
> Reporter: Toshiya Kobayashi
> Assignee: Luca Molteni
> Priority: Minor
>
> DomainClassesMetadataXXX java source files are created under directories with dot separated name instead of usual package hierarchy. It doesn't seem to cause issues though.
> For example, when I run kogito-examples/drools-quarkus-unit-example
> {noformat}
> $ mvn clean package
> ...
> $ tree target/generated-sources/
> target/generated-sources/
> ├── annotations
> └── kogito
> ├── org
> │ ├── drools
> │ │ └── project
> │ │ └── model
> │ │ ├── ProjectModel.java
> │ │ └── ProjectRuntime.java
> │ └── kie
> │ └── kogito
> │ ├── examples
> │ │ ├── ApplicationConfig.java
> │ │ └── Application.java
> │ ├── queries
> │ │ ├── AdultUnitDTO.java
> │ │ ├── AdultUnitQueryFindAdultNamesEndpoint.java
> │ │ ├── AdultUnitQueryFindAdultsEndpoint.java
> │ │ ├── AdultUnitQueryFindNotAdultNamesAndAgeEndpoint.java
> │ │ ├── AdultUnitRuleUnitInstance.java
> │ │ ├── AdultUnitRuleUnit.java
> │ │ ├── RulesF894883E1030542FEFCE9860F835B9B7_AdultUnit.java
> │ │ ├── RulesF894883E1030542FEFCE9860F835B9B7_AdultUnitRuleMethods0.java
> │ │ └── RulesF894883E1030542FEFCE9860F835B9B7.java
> │ └── rules
> │ └── alerting
> │ ├── LoggerServiceRuleUnitInstance.java
> │ ├── LoggerServiceRuleUnit.java
> │ ├── MonitoringServiceRuleUnitInstance.java
> │ ├── MonitoringServiceRuleUnit.java
> │ ├── Rules4723952D402A230BDB0E7081EBBA10E2.java
> │ ├── Rules4723952D402A230BDB0E7081EBBA10E2_LoggerService.java
> │ ├── Rules4723952D402A230BDB0E7081EBBA10E2_LoggerServiceRuleMethods0.java
> │ ├── Rules4723952D402A230BDB0E7081EBBA10E2_MonitoringService.java
> │ └── Rules4723952D402A230BDB0E7081EBBA10E2_MonitoringServiceRuleMethods0.java
> ├── org.kie.kogito.queries
> │ └── DomainClassesMetadataF894883E1030542FEFCE9860F835B9B7.java
> └── org.kie.kogito.rules.alerting
> └── DomainClassesMetadata4723952D402A230BDB0E7081EBBA10E2.java
> {noformat}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (DROOLS-4894) DomainClassesMetadata java files are created under directories with dot separated name
by Toshiya Kobayashi (Jira)
[ https://issues.redhat.com/browse/DROOLS-4894?page=com.atlassian.jira.plug... ]
Toshiya Kobayashi commented on DROOLS-4894:
-------------------------------------------
Now I see that 7.33.0-SNAPSHOT kie-maven-plugin writes DomainClassesMetadata java to the right path. 7.33.0-SNAPSHOT kogito-maven-plugin still has the issue (dot separated name).
> DomainClassesMetadata java files are created under directories with dot separated name
> --------------------------------------------------------------------------------------
>
> Key: DROOLS-4894
> URL: https://issues.redhat.com/browse/DROOLS-4894
> Project: Drools
> Issue Type: Bug
> Components: executable model
> Affects Versions: 7.31.0.Final
> Reporter: Toshiya Kobayashi
> Assignee: Luca Molteni
> Priority: Minor
>
> DomainClassesMetadataXXX java source files are created under directories with dot separated name instead of usual package hierarchy. It doesn't seem to cause issues though.
> For example, when I run kogito-examples/drools-quarkus-unit-example
> {noformat}
> $ mvn clean package
> ...
> $ tree target/generated-sources/
> target/generated-sources/
> ├── annotations
> └── kogito
> ├── org
> │ ├── drools
> │ │ └── project
> │ │ └── model
> │ │ ├── ProjectModel.java
> │ │ └── ProjectRuntime.java
> │ └── kie
> │ └── kogito
> │ ├── examples
> │ │ ├── ApplicationConfig.java
> │ │ └── Application.java
> │ ├── queries
> │ │ ├── AdultUnitDTO.java
> │ │ ├── AdultUnitQueryFindAdultNamesEndpoint.java
> │ │ ├── AdultUnitQueryFindAdultsEndpoint.java
> │ │ ├── AdultUnitQueryFindNotAdultNamesAndAgeEndpoint.java
> │ │ ├── AdultUnitRuleUnitInstance.java
> │ │ ├── AdultUnitRuleUnit.java
> │ │ ├── RulesF894883E1030542FEFCE9860F835B9B7_AdultUnit.java
> │ │ ├── RulesF894883E1030542FEFCE9860F835B9B7_AdultUnitRuleMethods0.java
> │ │ └── RulesF894883E1030542FEFCE9860F835B9B7.java
> │ └── rules
> │ └── alerting
> │ ├── LoggerServiceRuleUnitInstance.java
> │ ├── LoggerServiceRuleUnit.java
> │ ├── MonitoringServiceRuleUnitInstance.java
> │ ├── MonitoringServiceRuleUnit.java
> │ ├── Rules4723952D402A230BDB0E7081EBBA10E2.java
> │ ├── Rules4723952D402A230BDB0E7081EBBA10E2_LoggerService.java
> │ ├── Rules4723952D402A230BDB0E7081EBBA10E2_LoggerServiceRuleMethods0.java
> │ ├── Rules4723952D402A230BDB0E7081EBBA10E2_MonitoringService.java
> │ └── Rules4723952D402A230BDB0E7081EBBA10E2_MonitoringServiceRuleMethods0.java
> ├── org.kie.kogito.queries
> │ └── DomainClassesMetadataF894883E1030542FEFCE9860F835B9B7.java
> └── org.kie.kogito.rules.alerting
> └── DomainClassesMetadata4723952D402A230BDB0E7081EBBA10E2.java
> {noformat}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (DROOLS-5028) Support incremental update for function with executable model
by Toshiya Kobayashi (Jira)
Toshiya Kobayashi created DROOLS-5028:
-----------------------------------------
Summary: Support incremental update for function with executable model
Key: DROOLS-5028
URL: https://issues.redhat.com/browse/DROOLS-5028
Project: Drools
Issue Type: Task
Components: executable model
Affects Versions: 7.32.0.Final
Reporter: Toshiya Kobayashi
Assignee: Luca Molteni
When you do incremental compilation with executable model, if a function is updated, you will get this error.
{noformat}
[ERROR] testKJarUpgradeWithChangedFunction[PATTERN_DSL](org.drools.modelcompiler.IncrementalCompilationTest) Time elapsed: 2.682 s <<< ERROR!
java.lang.IllegalArgumentException: Unsupported change type: function!
at org.drools.modelcompiler.builder.CanonicalKieBaseUpdater.run(CanonicalKieBaseUpdater.java:148)
at org.drools.core.impl.KnowledgeBaseImpl.enqueueModification(KnowledgeBaseImpl.java:745)
at org.drools.compiler.kie.builder.impl.KieContainerImpl.update(KieContainerImpl.java:266)
at org.drools.compiler.kie.builder.impl.KieContainerImpl.update(KieContainerImpl.java:236)
at org.drools.compiler.kie.builder.impl.KieContainerImpl.updateToVersion(KieContainerImpl.java:194)
at org.drools.modelcompiler.IncrementalCompilationTest.testKJarUpgradeWithChangedFunction(IncrementalCompilationTest.java:359)
...
{noformat}
This is an explicit limitation at the moment but I filed this JIRA to support a function update.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months