[JBoss JIRA] (DROOLS-3843) DMN Editor Decision Navigator differentiate icons for DRGElement
by Guilherme Gomes (Jira)
[ https://issues.redhat.com/browse/DROOLS-3843?page=com.atlassian.jira.plug... ]
Guilherme Gomes edited comment on DROOLS-3843 at 4/8/20 2:35 PM:
-----------------------------------------------------------------
[~hmanwani], I'm adding you as the writer since this JIRA has impact on docs.
cc'ing [~stetson.robinson], since it has impact on Kogito side as well.
was (Author: karreiro):
[~hmanwani], I'm adding you as the writer since this JIRA has impact on docs.
cc [~stetson.robinson] maybe it has impact on Kogito side as well.
> DMN Editor Decision Navigator differentiate icons for DRGElement
> ----------------------------------------------------------------
>
> Key: DROOLS-3843
> URL: https://issues.redhat.com/browse/DROOLS-3843
> Project: Drools
> Issue Type: Enhancement
> Components: DMN Editor
> Reporter: Matteo Mortari
> Assignee: Valentino Pellegrino
> Priority: Major
> Labels: drools-tools, ux_needed
> Attachments: dmn-icons.png, image-2019-04-03-10-38-39-270.png
>
>
> In this example:
> !image-2019-04-03-10-38-39-270.png|thumbnail!
> The 1st one is a Decision, the other are Input Data.
> Experienced DMN practitioner may know that a decision logic can only happen to Decision or BKM node, hence one could distinguish potential Input data node by not having decision logic (context in the example). But also what about Decision or BKM for which you didn't write the decision logic yet?
> PLease consider distinguished icon for DRG Elements.
> For example
> leave Input Data with the filled circle
> Decision: filled square
> BKM: filled trapezoid.
> Thanks
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (DROOLS-3843) DMN Editor Decision Navigator differentiate icons for DRGElement
by Guilherme Gomes (Jira)
[ https://issues.redhat.com/browse/DROOLS-3843?page=com.atlassian.jira.plug... ]
Guilherme Gomes commented on DROOLS-3843:
-----------------------------------------
[~hmanwani], I'm adding you as the writer since this JIRA has impact on docs.
cc [~stetson.robinson] maybe it has impact on Kogito side as well.
> DMN Editor Decision Navigator differentiate icons for DRGElement
> ----------------------------------------------------------------
>
> Key: DROOLS-3843
> URL: https://issues.redhat.com/browse/DROOLS-3843
> Project: Drools
> Issue Type: Enhancement
> Components: DMN Editor
> Reporter: Matteo Mortari
> Assignee: Valentino Pellegrino
> Priority: Major
> Labels: drools-tools, ux_needed
> Attachments: dmn-icons.png, image-2019-04-03-10-38-39-270.png
>
>
> In this example:
> !image-2019-04-03-10-38-39-270.png|thumbnail!
> The 1st one is a Decision, the other are Input Data.
> Experienced DMN practitioner may know that a decision logic can only happen to Decision or BKM node, hence one could distinguish potential Input data node by not having decision logic (context in the example). But also what about Decision or BKM for which you didn't write the decision logic yet?
> PLease consider distinguished icon for DRG Elements.
> For example
> leave Input Data with the filled circle
> Decision: filled square
> BKM: filled trapezoid.
> Thanks
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (DROOLS-3843) DMN Editor Decision Navigator differentiate icons for DRGElement
by Guilherme Gomes (Jira)
[ https://issues.redhat.com/browse/DROOLS-3843?page=com.atlassian.jira.plug... ]
Guilherme Gomes updated DROOLS-3843:
------------------------------------
Writer: Heena Manwani
> DMN Editor Decision Navigator differentiate icons for DRGElement
> ----------------------------------------------------------------
>
> Key: DROOLS-3843
> URL: https://issues.redhat.com/browse/DROOLS-3843
> Project: Drools
> Issue Type: Enhancement
> Components: DMN Editor
> Reporter: Matteo Mortari
> Assignee: Valentino Pellegrino
> Priority: Major
> Labels: drools-tools, ux_needed
> Attachments: dmn-icons.png, image-2019-04-03-10-38-39-270.png
>
>
> In this example:
> !image-2019-04-03-10-38-39-270.png|thumbnail!
> The 1st one is a Decision, the other are Input Data.
> Experienced DMN practitioner may know that a decision logic can only happen to Decision or BKM node, hence one could distinguish potential Input data node by not having decision logic (context in the example). But also what about Decision or BKM for which you didn't write the decision logic yet?
> PLease consider distinguished icon for DRG Elements.
> For example
> leave Input Data with the filled circle
> Decision: filled square
> BKM: filled trapezoid.
> Thanks
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (WFLY-1415) Move away from expensive enum switch
by David Lloyd (Jira)
[ https://issues.redhat.com/browse/WFLY-1415?page=com.atlassian.jira.plugin... ]
David Lloyd commented on WFLY-1415:
-----------------------------------
As the original poster (7 years ago!), I feel I should provide a point of clarification. IIRC, it transpires that string switch also creates a distinct class as well; my recollection should be checked because it would be a bit of a wasted effort to do all this migration only to discover that nothing was saved.
> Move away from expensive enum switch
> ------------------------------------
>
> Key: WFLY-1415
> URL: https://issues.redhat.com/browse/WFLY-1415
> Project: WildFly
> Issue Type: Task
> Reporter: David Lloyd
> Priority: Minor
> Labels: janitor
>
> We use enums and enum switch extensively. These constructs generate many, many additional classes and bloat the code base unnecessarily.
> All cases where we are using enum-based switches for our XML parsers should be converted to use Java 7 String switch instead. The enum values shall be replaced with String constant fields, all enum switches converted to String switches, and all enum types removed from these classes. The net result should be a reduction by dozens if not hundreds of .class files, and possibly a measurable performance boost as well.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (DROOLS-5229) DMNValidate mojo fails XMLSchema validation with included models
by Matteo Mortari (Jira)
[ https://issues.redhat.com/browse/DROOLS-5229?page=com.atlassian.jira.plug... ]
Matteo Mortari commented on DROOLS-5229:
----------------------------------------
Hi [~tracyhires] thanks for reporting, the editor generated ID in the file is indeed not XML-valid, will be taken care of.
I just need however to highlight something you mentioned, which is not actually correct:
bq. though disabling DMNValidation for an XML Schema validation also prevents finding FEEL parser errors
Most FEEL parser error are actually detected during DMN "compilation" phase. So disabling DMNValidation, will disable only XSD schema check and static analysis (before compilation).
Ref.: https://docs.jboss.org/drools/release/7.35.0.Final/drools-docs/html_singl...
Consequently, using the Maven pom.xml settings you suggest does indeed circumvent the XSD schema validation checks, but it will still perform FEEL parser checks, as those happens during DMN model compilation.
> DMNValidate mojo fails XMLSchema validation with included models
> ----------------------------------------------------------------
>
> Key: DROOLS-5229
> URL: https://issues.redhat.com/browse/DROOLS-5229
> Project: Drools
> Issue Type: Bug
> Affects Versions: 7.34.0.Final
> Reporter: Tracy Hires
> Assignee: Guilherme Gomes
> Priority: Minor
> Attachments: ValidateDMN Mojo Failure.png, xml_validation_error.zip
>
>
> The attached DMN decision project was built using Business Central 7.34.0.Final. In this project, the dmn model `Math Functions.dmn` invokes business knowledge model `Quotient` from dmn model `Divide.dmn`. Invoking the ValidateDMN mojo (enabled by default) from the kie-maven-plugin fails XML Validation. One can get past this error by disabling DMNValidation with the following configuration in the pom (though disabling DMNValidation for an XML Schema validation also prevents finding FEEL parser errors):
> ```
> <build>
> <plugins>
> <plugin>
> <groupId>org.kie</groupId>
> <artifactId>kie-maven-plugin</artifactId>
> <version>7.34.0.Final</version>
> <extensions>true</extensions>
> <!-- Can get past xml validation error by disabling the ValidateDMN Mojo -->
> <configuration>
> <validateDMN>disabled</validateDMN>
> </configuration>
> </plugin>
> </plugins>
> </build>
> ```
> When one combines the two dmn models into a single model, the XML Validation succeeds (this example is not supplied, but is trivial to re-build).
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (DROOLS-4746) UX for DMN "quick test" tool
by Elizabeth Clayton (Jira)
[ https://issues.redhat.com/browse/DROOLS-4746?page=com.atlassian.jira.plug... ]
Elizabeth Clayton edited comment on DROOLS-4746 at 4/8/20 2:01 PM:
-------------------------------------------------------------------
Updated wireframe, actions to show the "Inspect" panel include:
- Select the expression table by left mouse click, automatically opening the inspect panel. (Currently there is no content in the properties panel anyway.)
- Right click a table header cell, where the right mouse click contextual menu will include an option to "Inspect."
- User a toolbar menu button for inspect/debug.
was (Author: uxdlc):
Updated wireframe, actions to show panel include:
- Select the expression table by left mouse click, automatically opening the inspect panel. (Currently there is no content in the properties panel anyway.)
- Right click a table header cell, where the right mouse click contextual menu will include an option to "Inspect."
- User a toolbar menu button for inspect/debug.
> UX for DMN "quick test" tool
> ----------------------------
>
> Key: DROOLS-4746
> URL: https://issues.redhat.com/browse/DROOLS-4746
> Project: Drools
> Issue Type: Story
> Components: DMN Editor
> Reporter: Elizabeth Clayton
> Assignee: Elizabeth Clayton
> Priority: Major
> Labels: UX, UXTeam, drools-tools
> Attachments: decision-logic-2-2.png, decision-logic-3-2.png
>
>
> As a DMN author, I'd like to probe the DMN model during the authoring phase without leaving the DMN Editor. Actually, it's really important to explore the DMN model to understand with values are required by the test.
> When the user run the test he can get back the results of the DMN execution.
> Moreover, it would be handy to add those input/output to an existing (or new) test scenario.
> *Acceptance criteria*
> Users are able to:
> * Execute a single node boxed expression by providing node inputs (within the DMN editor.)
> * Explore the DMN model and provide inputs necessary to run a scenario test.
> * Obtain results (Expected) within the DMN editor once the test is run.
> Notes:
> * Try to dissociate this feature from the "test scenario" concept and think of this more as a partial execution. When we're thinking about the concept of a "test scenario", we think about input values and expected outputs... however, in this new component, users will be able to provide inputs and just check the current output.
> * Out of scope: Saving or exporting the "quick test."
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (DROOLS-5229) DMNValidate mojo fails XMLSchema validation with included models
by Matteo Mortari (Jira)
[ https://issues.redhat.com/browse/DROOLS-5229?page=com.atlassian.jira.plug... ]
Matteo Mortari reassigned DROOLS-5229:
--------------------------------------
Assignee: Guilherme Gomes (was: Matteo Mortari)
> DMNValidate mojo fails XMLSchema validation with included models
> ----------------------------------------------------------------
>
> Key: DROOLS-5229
> URL: https://issues.redhat.com/browse/DROOLS-5229
> Project: Drools
> Issue Type: Bug
> Affects Versions: 7.34.0.Final
> Reporter: Tracy Hires
> Assignee: Guilherme Gomes
> Priority: Minor
> Attachments: ValidateDMN Mojo Failure.png, xml_validation_error.zip
>
>
> The attached DMN decision project was built using Business Central 7.34.0.Final. In this project, the dmn model `Math Functions.dmn` invokes business knowledge model `Quotient` from dmn model `Divide.dmn`. Invoking the ValidateDMN mojo (enabled by default) from the kie-maven-plugin fails XML Validation. One can get past this error by disabling DMNValidation with the following configuration in the pom (though disabling DMNValidation for an XML Schema validation also prevents finding FEEL parser errors):
> ```
> <build>
> <plugins>
> <plugin>
> <groupId>org.kie</groupId>
> <artifactId>kie-maven-plugin</artifactId>
> <version>7.34.0.Final</version>
> <extensions>true</extensions>
> <!-- Can get past xml validation error by disabling the ValidateDMN Mojo -->
> <configuration>
> <validateDMN>disabled</validateDMN>
> </configuration>
> </plugin>
> </plugins>
> </build>
> ```
> When one combines the two dmn models into a single model, the XML Validation succeeds (this example is not supplied, but is trivial to re-build).
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (DROOLS-4746) UX for DMN "quick test" tool
by Elizabeth Clayton (Jira)
[ https://issues.redhat.com/browse/DROOLS-4746?page=com.atlassian.jira.plug... ]
Elizabeth Clayton commented on DROOLS-4746:
-------------------------------------------
Updated wireframe, actions to show panel include:
- Select the expression table by left mouse click, automatically opening the inspect panel. (Currently there is no content in the properties panel anyway.)
- Right click a table header cell, where the right mouse click contextual menu will include an option to "Inspect."
- User a toolbar menu button for inspect/debug.
> UX for DMN "quick test" tool
> ----------------------------
>
> Key: DROOLS-4746
> URL: https://issues.redhat.com/browse/DROOLS-4746
> Project: Drools
> Issue Type: Story
> Components: DMN Editor
> Reporter: Elizabeth Clayton
> Assignee: Elizabeth Clayton
> Priority: Major
> Labels: UX, UXTeam, drools-tools
> Attachments: decision-logic-2-2.png, decision-logic-3-2.png
>
>
> As a DMN author, I'd like to probe the DMN model during the authoring phase without leaving the DMN Editor. Actually, it's really important to explore the DMN model to understand with values are required by the test.
> When the user run the test he can get back the results of the DMN execution.
> Moreover, it would be handy to add those input/output to an existing (or new) test scenario.
> *Acceptance criteria*
> Users are able to:
> * Execute a single node boxed expression by providing node inputs (within the DMN editor.)
> * Explore the DMN model and provide inputs necessary to run a scenario test.
> * Obtain results (Expected) within the DMN editor once the test is run.
> Notes:
> * Try to dissociate this feature from the "test scenario" concept and think of this more as a partial execution. When we're thinking about the concept of a "test scenario", we think about input values and expected outputs... however, in this new component, users will be able to provide inputs and just check the current output.
> * Out of scope: Saving or exporting the "quick test."
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (DROOLS-5230) Managing a List of structures in Test Scenario editor produces an Exception
by Tracy Hires (Jira)
[ https://issues.redhat.com/browse/DROOLS-5230?page=com.atlassian.jira.plug... ]
Tracy Hires updated DROOLS-5230:
--------------------------------
Component/s: Scenario Simulation and Testing
Affects Version/s: 7.34.0.Final
> Managing a List of structures in Test Scenario editor produces an Exception
> ---------------------------------------------------------------------------
>
> Key: DROOLS-5230
> URL: https://issues.redhat.com/browse/DROOLS-5230
> Project: Drools
> Issue Type: Bug
> Components: Scenario Simulation and Testing
> Affects Versions: 7.34.0.Final
> Reporter: Tracy Hires
> Assignee: Mario Fusco
> Priority: Critical
> Attachments: Error screen shot.png, test_scenario_list_exception.zip
>
>
> When trying to delete an item from a list of structures with nested structures in the scenario editor, an exception is thrown with a message that is not helpful to the end user.
> Log entry is:
> ```
> ^[[0m^[[31m17:16:51,564 ERROR [org.kie.workbench.common.services.backend.logger.GenericErrorLoggerServiceImpl] (default task-415) Error from user: xxxxx Error ID: -881202734 Location: LibraryPerspective|$ProjectScreen[!Worg.kie.dmn.decision.navigator,EDiagramEditorPropertiesScreen,Eorg.drools.scenariosimulation.TestTools?scesimeditorid=1,!Eorg.drools.scenariosimulation.TestTools?scesimeditorid=2,Eorg.docks.PlaceHolder?name=testRunnerReportingPanel,Worg.kie.guvnor.explorer,],DMNDiagramEditor?path_uri=default://master@dm-ai/XmlValidationBug/src/main/resources/Math%2520Functions.dmn&file_name=Math%20Functions.dmn&has_version_support=true,DMNDiagramEditor?path_uri=default://master@dm-ai/XmlValidationBug/src/main/resources/Divide.dmn&file_name=Divide.dmn&has_version_support=true,org.kie.workbench.common.screens.messageconsole.MessageConsole,,AddAssetsScreen,ScenarioSimulationEditor?path_uri=default://master@dm-ai/XmlValidationBug/src/test/resources/Test%2520Math%2520Functions.scesim&file_name=Test%20Math%20Functions.scesim&has_version_support=true Exception: Uncaught exception: Exception caught: (TypeError) : Cannot read property 'Tc' of undefined Caused by: (TypeError) : Cannot read property 'Tc' of undefined
> ```
> From UI I could see: `Uncaught exception: Exception caught: (TypeError) : Cannot read property 'Tc' of undefined Caused by: (TypeError) : Cannot read property 'Tc' of undefined`
> (Screenshot is attached)
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (DROOLS-5230) Managing a List of structures in Test Scenario editor produces an Exception
by Tracy Hires (Jira)
Tracy Hires created DROOLS-5230:
-----------------------------------
Summary: Managing a List of structures in Test Scenario editor produces an Exception
Key: DROOLS-5230
URL: https://issues.redhat.com/browse/DROOLS-5230
Project: Drools
Issue Type: Bug
Reporter: Tracy Hires
Assignee: Mario Fusco
Attachments: Error screen shot.png, test_scenario_list_exception.zip
When trying to delete an item from a list of structures with nested structures in the scenario editor, an exception is thrown with a message that is not helpful to the end user.
Log entry is:
```
^[[0m^[[31m17:16:51,564 ERROR [org.kie.workbench.common.services.backend.logger.GenericErrorLoggerServiceImpl] (default task-415) Error from user: xxxxx Error ID: -881202734 Location: LibraryPerspective|$ProjectScreen[!Worg.kie.dmn.decision.navigator,EDiagramEditorPropertiesScreen,Eorg.drools.scenariosimulation.TestTools?scesimeditorid=1,!Eorg.drools.scenariosimulation.TestTools?scesimeditorid=2,Eorg.docks.PlaceHolder?name=testRunnerReportingPanel,Worg.kie.guvnor.explorer,],DMNDiagramEditor?path_uri=default://master@dm-ai/XmlValidationBug/src/main/resources/Math%2520Functions.dmn&file_name=Math%20Functions.dmn&has_version_support=true,DMNDiagramEditor?path_uri=default://master@dm-ai/XmlValidationBug/src/main/resources/Divide.dmn&file_name=Divide.dmn&has_version_support=true,org.kie.workbench.common.screens.messageconsole.MessageConsole,,AddAssetsScreen,ScenarioSimulationEditor?path_uri=default://master@dm-ai/XmlValidationBug/src/test/resources/Test%2520Math%2520Functions.scesim&file_name=Test%20Math%20Functions.scesim&has_version_support=true Exception: Uncaught exception: Exception caught: (TypeError) : Cannot read property 'Tc' of undefined Caused by: (TypeError) : Cannot read property 'Tc' of undefined
```
>From UI I could see: `Uncaught exception: Exception caught: (TypeError) : Cannot read property 'Tc' of undefined Caused by: (TypeError) : Cannot read property 'Tc' of undefined`
(Screenshot is attached)
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months