[JBoss JIRA] (DROOLS-5028) Support incremental update for function with executable model
by Kris Verlaenen (Jira)
[ https://issues.redhat.com/browse/DROOLS-5028?page=com.atlassian.jira.plug... ]
Kris Verlaenen updated DROOLS-5028:
-----------------------------------
Sprint: 2020 Week 10-12 (from Mar 2), 2020 Week 13-15 (from Mar 23), 2020 Week 16-18 (from Apr 13) (was: 2020 Week 10-12 (from Mar 2), 2020 Week 13-15 (from Mar 23))
> Support incremental update for function with executable model
> -------------------------------------------------------------
>
> Key: DROOLS-5028
> URL: https://issues.redhat.com/browse/DROOLS-5028
> Project: Drools
> Issue Type: Task
> Components: executable model
> Affects Versions: 7.32.0.Final
> Reporter: Toshiya Kobayashi
> Assignee: Toshiya Kobayashi
> Priority: Major
> Labels: good-first-issue
>
> When you do incremental compilation with executable model, if a function is updated, you will get this error.
> {noformat}
> [ERROR] testKJarUpgradeWithChangedFunction[PATTERN_DSL](org.drools.modelcompiler.IncrementalCompilationTest) Time elapsed: 2.682 s <<< ERROR!
> java.lang.IllegalArgumentException: Unsupported change type: function!
> at org.drools.modelcompiler.builder.CanonicalKieBaseUpdater.run(CanonicalKieBaseUpdater.java:148)
> at org.drools.core.impl.KnowledgeBaseImpl.enqueueModification(KnowledgeBaseImpl.java:745)
> at org.drools.compiler.kie.builder.impl.KieContainerImpl.update(KieContainerImpl.java:266)
> at org.drools.compiler.kie.builder.impl.KieContainerImpl.update(KieContainerImpl.java:236)
> at org.drools.compiler.kie.builder.impl.KieContainerImpl.updateToVersion(KieContainerImpl.java:194)
> at org.drools.modelcompiler.IncrementalCompilationTest.testKJarUpgradeWithChangedFunction(IncrementalCompilationTest.java:359)
> ...
> {noformat}
> This is an explicit limitation at the moment but I filed this JIRA to support a function update.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 5 months
[JBoss JIRA] (DROOLS-5028) Support incremental update for function with executable model
by Toshiya Kobayashi (Jira)
[ https://issues.redhat.com/browse/DROOLS-5028?page=com.atlassian.jira.plug... ]
Toshiya Kobayashi updated DROOLS-5028:
--------------------------------------
Sprint: 2020 Week 10-12 (from Mar 2), 2020 Week 13-15 (from Mar 23) (was: 2020 Week 10-12 (from Mar 2), 2020 Week 16-18 (from Apr 13))
> Support incremental update for function with executable model
> -------------------------------------------------------------
>
> Key: DROOLS-5028
> URL: https://issues.redhat.com/browse/DROOLS-5028
> Project: Drools
> Issue Type: Task
> Components: executable model
> Affects Versions: 7.32.0.Final
> Reporter: Toshiya Kobayashi
> Assignee: Toshiya Kobayashi
> Priority: Major
> Labels: good-first-issue
>
> When you do incremental compilation with executable model, if a function is updated, you will get this error.
> {noformat}
> [ERROR] testKJarUpgradeWithChangedFunction[PATTERN_DSL](org.drools.modelcompiler.IncrementalCompilationTest) Time elapsed: 2.682 s <<< ERROR!
> java.lang.IllegalArgumentException: Unsupported change type: function!
> at org.drools.modelcompiler.builder.CanonicalKieBaseUpdater.run(CanonicalKieBaseUpdater.java:148)
> at org.drools.core.impl.KnowledgeBaseImpl.enqueueModification(KnowledgeBaseImpl.java:745)
> at org.drools.compiler.kie.builder.impl.KieContainerImpl.update(KieContainerImpl.java:266)
> at org.drools.compiler.kie.builder.impl.KieContainerImpl.update(KieContainerImpl.java:236)
> at org.drools.compiler.kie.builder.impl.KieContainerImpl.updateToVersion(KieContainerImpl.java:194)
> at org.drools.modelcompiler.IncrementalCompilationTest.testKJarUpgradeWithChangedFunction(IncrementalCompilationTest.java:359)
> ...
> {noformat}
> This is an explicit limitation at the moment but I filed this JIRA to support a function update.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 5 months
[JBoss JIRA] (DROOLS-5028) Support incremental update for function with executable model
by Toshiya Kobayashi (Jira)
[ https://issues.redhat.com/browse/DROOLS-5028?page=com.atlassian.jira.plug... ]
Toshiya Kobayashi updated DROOLS-5028:
--------------------------------------
Sprint: 2020 Week 10-12 (from Mar 2), 2020 Week 16-18 (from Apr 13) (was: 2020 Week 10-12 (from Mar 2), 2020 Week 13-15 (from Mar 23))
> Support incremental update for function with executable model
> -------------------------------------------------------------
>
> Key: DROOLS-5028
> URL: https://issues.redhat.com/browse/DROOLS-5028
> Project: Drools
> Issue Type: Task
> Components: executable model
> Affects Versions: 7.32.0.Final
> Reporter: Toshiya Kobayashi
> Assignee: Toshiya Kobayashi
> Priority: Major
> Labels: good-first-issue
>
> When you do incremental compilation with executable model, if a function is updated, you will get this error.
> {noformat}
> [ERROR] testKJarUpgradeWithChangedFunction[PATTERN_DSL](org.drools.modelcompiler.IncrementalCompilationTest) Time elapsed: 2.682 s <<< ERROR!
> java.lang.IllegalArgumentException: Unsupported change type: function!
> at org.drools.modelcompiler.builder.CanonicalKieBaseUpdater.run(CanonicalKieBaseUpdater.java:148)
> at org.drools.core.impl.KnowledgeBaseImpl.enqueueModification(KnowledgeBaseImpl.java:745)
> at org.drools.compiler.kie.builder.impl.KieContainerImpl.update(KieContainerImpl.java:266)
> at org.drools.compiler.kie.builder.impl.KieContainerImpl.update(KieContainerImpl.java:236)
> at org.drools.compiler.kie.builder.impl.KieContainerImpl.updateToVersion(KieContainerImpl.java:194)
> at org.drools.modelcompiler.IncrementalCompilationTest.testKJarUpgradeWithChangedFunction(IncrementalCompilationTest.java:359)
> ...
> {noformat}
> This is an explicit limitation at the moment but I filed this JIRA to support a function update.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 5 months
[JBoss JIRA] (DROOLS-5234) I use jsonString as the parameter of the function and i get a error:Syntax error on tokens, delete these tokens
by xin zhang (Jira)
xin zhang created DROOLS-5234:
---------------------------------
Summary: I use jsonString as the parameter of the function and i get a error:Syntax error on tokens, delete these tokens
Key: DROOLS-5234
URL: https://issues.redhat.com/browse/DROOLS-5234
Project: Drools
Issue Type: Bug
Components: build
Affects Versions: 7.22.0.Final
Reporter: xin zhang
Assignee: Ant Stephenson
version : `7.22.0.Final`
- this is my rule:
```
package org.zhangnix.droolsdemo;
import org.zhangnix.droolsdemo.model.DroolsContext;
import com.alibaba.fastjson.JSON;
import com.alibaba.fastjson.JSONObject;
import java.math.BigDecimal;
import java.util.List;
import java.util.Date;
import java.lang.Boolean;
import java.lang.String;
import java.lang.Integer;
function boolean checkGoodsCount(Integer currentGoodsCount,String jsonString) {
JSONObject context = JSON.parseObject(jsonString);
int goodsCount = context.getInteger("goodsCount");
String compareType = context.getString("compareType");
switch (compareType) {
case "M":
return currentGoodsCount > goodsCount;
case "E":
return currentGoodsCount == goodsCount;
case "EM":
return currentGoodsCount >= goodsCount;
default:
return false;
}
}
rule "Activity conditions"
when
$droolsContext:DroolsContext();
eval(checkGoodsCount($droolsContext.getCurrentGoodsCount(),'{"compareType":"EM","goodsCount":3}'));
then
end
```
I use jsonString as the parameter of the function and i get a error:
> Syntax error on tokens, delete these tokens
this is my generate java file:
```
public static boolean eval0( org.zhangnix.droolsdemo.model.DroolsContext $droolsContext
) throws java.lang.Exception {
Boolean $eval$result$ = ( checkGoodsCount($droolsContext.getCurrentGoodsCount(),"{"compareType":"EM","goodsCount":3}") );
return $eval$result$ == null ? false : $eval$result$.booleanValue();
}
```
When parsing jsonString, there is no backslash (\\) before the quotes. Please tell me what should I do to pass jsonString correctly.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 5 months
[JBoss JIRA] (DROOLS-2254) Automate .proto files rebuild in pom.xml
by Michael Biarnes Kiefer (Jira)
[ https://issues.redhat.com/browse/DROOLS-2254?page=com.atlassian.jira.plug... ]
Michael Biarnes Kiefer updated DROOLS-2254:
-------------------------------------------
Fix Version/s: 7.37.0.Final
(was: 7.36.0.Final)
> Automate .proto files rebuild in pom.xml
> ----------------------------------------
>
> Key: DROOLS-2254
> URL: https://issues.redhat.com/browse/DROOLS-2254
> Project: Drools
> Issue Type: Task
> Components: tools
> Affects Versions: 7.5.0.Final
> Reporter: Dmitry Volodin
> Assignee: Dmitry Volodin
> Priority: Minor
> Fix For: 7.37.0.Final
>
>
> According to contribution guide, any .proto file or protobuf version changes it's necessary to download protoc utility and regenerate Java classes based on .proto files.
> This will add automation for downloading protoc utility and Java classes generation based on Maven Protocol Buffers Plugin. There is no timestamps and other build related info inside generated Java files and no changes will be added on each new build.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 5 months
[JBoss JIRA] (DROOLS-5095) [DMN Designer] Investigate performance switching between editor instances
by Michael Biarnes Kiefer (Jira)
[ https://issues.redhat.com/browse/DROOLS-5095?page=com.atlassian.jira.plug... ]
Michael Biarnes Kiefer updated DROOLS-5095:
-------------------------------------------
Fix Version/s: 7.37.0.Final
(was: 7.36.0.Final)
> [DMN Designer] Investigate performance switching between editor instances
> -------------------------------------------------------------------------
>
> Key: DROOLS-5095
> URL: https://issues.redhat.com/browse/DROOLS-5095
> Project: Drools
> Issue Type: Task
> Components: DMN Editor
> Affects Versions: 7.33.0.Final
> Reporter: Jozef Marko
> Assignee: Guilherme Gomes
> Priority: Minor
> Labels: drools-tools
> Fix For: 7.37.0.Final
>
> Attachments: switch-dmn.webm
>
>
> This JIRA is to investigate the reported performance issue switching between different DMN Designer instances in Business Central.
> The issue was noticed by [~jomarko] when testing DROOLS-5058 (although the fix therein should have had *zero* affect on switching).
> For more details see the video [^switch-dmn.webm]
> h2. Manual acceptance test
> - Prepare 5 DMN models in project
> - Open all in parallel
> - Try to switch between them, keep all opened
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 5 months