[JBoss JIRA] (WFCORE-5028) CallbackHandler from CLI overriding discovered wildfly-config for authentication.
by Darran Lofthouse (Jira)
Darran Lofthouse created WFCORE-5028:
----------------------------------------
Summary: CallbackHandler from CLI overriding discovered wildfly-config for authentication.
Key: WFCORE-5028
URL: https://issues.redhat.com/browse/WFCORE-5028
Project: WildFly Core
Issue Type: Bug
Components: CLI, Security
Reporter: Darran Lofthouse
Assignee: Darran Lofthouse
Fix For: 12.0.2.Final, 13.0.0.Beta2
WFCORE-4976 made an update to ProtocolConnectionUtils so that a supplied CallbackHandler takes priority - this works where a client is using ModelControllerClient.create() and passing in a CallbackHandler as we should take that as an indication that the caller wants control of authentication.
However by fixing in ProtocolConnectionUtils it has also picked up the case where the CLI passes in the CallbackHandler - that case however should only use the CBH if the information can not be obtained from the AuthenticationConfiguration. This call does not come via ModelControllerClient but both paths meet at ProtocolConnectionUtils.
Either the adjustment of the AuthenticationContext to give the CallbackHandler should happen in ModelControllerClient - or an additional boolean should be passed into ProtocolConnectionUtils to indicate if the CallbackHandler should be given priority. The latter may be a less invasive evolution of the fix prepared so far.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 2 months
[JBoss JIRA] (WFLY-13640) Provide Support for MicroProfile Reactive Messaging
by Kabir Khan (Jira)
[ https://issues.redhat.com/browse/WFLY-13640?page=com.atlassian.jira.plugi... ]
Kabir Khan moved EAP7-1519 to WFLY-13640:
-----------------------------------------
Project: WildFly (was: JBoss EAP Planning for version 7 and above)
Key: WFLY-13640 (was: EAP7-1519)
Issue Type: Feature Request (was: Requirement)
Workflow: GIT Pull Request workflow (was: EAP Agile Workflow 2.0)
Component/s: (was: MicroProfile)
EAP PT Pre-Checked (PC): (was: TODO)
Target Release: (was: EAP-XP-2.0.0.GA)
EAP PT Community Docs (CD): (was: TODO)
EAP PT Product Docs (PD): (was: New)
EAP PT Test Dev (TD): (was: TODO)
EAP PT Docs Analysis (DA): (was: TODO)
EAP PT Test Plan (TP): (was: TODO)
EAP PT Analysis Document (AD): (was: TODO)
> Provide Support for MicroProfile Reactive Messaging
> ---------------------------------------------------
>
> Key: WFLY-13640
> URL: https://issues.redhat.com/browse/WFLY-13640
> Project: WildFly
> Issue Type: Feature Request
> Reporter: Bilgehan Ozpeynirci
> Assignee: Kabir Khan
> Priority: Major
>
> Sending and receiving messages between microservices with MicroProfile Reactive Messaging specification.
> It will possible to produce, process and consume messages within your application.
> Smallrye Reactive Messaging: https://smallrye.io/smallrye-reactive-messaging/
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 2 months
[JBoss JIRA] (WFCORE-4976) Where ModelControllerClient is initialised in process with CBH AuthenticationConfiguration takes priority.
by Darran Lofthouse (Jira)
[ https://issues.redhat.com/browse/WFCORE-4976?page=com.atlassian.jira.plug... ]
Darran Lofthouse updated WFCORE-4976:
-------------------------------------
Component/s: (was: CLI)
> Where ModelControllerClient is initialised in process with CBH AuthenticationConfiguration takes priority.
> ----------------------------------------------------------------------------------------------------------
>
> Key: WFCORE-4976
> URL: https://issues.redhat.com/browse/WFCORE-4976
> Project: WildFly Core
> Issue Type: Bug
> Components: Management, Security
> Reporter: Darran Lofthouse
> Assignee: Darran Lofthouse
> Priority: Major
> Labels: downstream_dependency
> Fix For: 12.0.0.Beta4, 12.0.0.Final
>
>
> In ProtocolConnectionUtils we have the following code to pass in the provided CallbackHanldler: -
> {code:java}
> if (handler != null) {
> mergedConfiguration = mergedConfiguration.useCallbackHandler(handler, DEFAULT_CALLBACK_KINDS);
> }
> {code}
> However the AuthenticationClient performs the following sanitation of the specified KINDS: -
> {code:java}
> case SET_USER_CB_KINDS:
> // SANITAZE on above content
> if (this.principal != null) {
> sanitazeOnMutation(SET_PRINCIPAL);
> }
> if (this.credentialSource != null) {
> sanitazeOnMutation(SET_CRED_SOURCE);
> }
> if (this.setRealm != null) {
> sanitazeOnMutation(SET_REALM);
> }
> if (this.parameterSpecs != null) {
> sanitazeOnMutation(SET_PARAM_SPECS);
> }
> if (this.keyManagerFactory != null) {
> sanitazeOnMutation(SET_KEY_MGR_FAC);
> }
> break;
> {code}
> Before passing in the CallbackHandler and specifying which KINDS is applies to the ProtocolConnectionUtils call should first remove the duplicates from the configuration.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 2 months
[JBoss JIRA] (WFCORE-4976) Where ModelControllerClient is initialised in process with CBH AuthenticationConfiguration takes priority.
by Darran Lofthouse (Jira)
[ https://issues.redhat.com/browse/WFCORE-4976?page=com.atlassian.jira.plug... ]
Darran Lofthouse updated WFCORE-4976:
-------------------------------------
Component/s: Management
> Where ModelControllerClient is initialised in process with CBH AuthenticationConfiguration takes priority.
> ----------------------------------------------------------------------------------------------------------
>
> Key: WFCORE-4976
> URL: https://issues.redhat.com/browse/WFCORE-4976
> Project: WildFly Core
> Issue Type: Bug
> Components: CLI, Management, Security
> Reporter: Darran Lofthouse
> Assignee: Darran Lofthouse
> Priority: Major
> Labels: downstream_dependency
> Fix For: 12.0.0.Beta4, 12.0.0.Final
>
>
> In ProtocolConnectionUtils we have the following code to pass in the provided CallbackHanldler: -
> {code:java}
> if (handler != null) {
> mergedConfiguration = mergedConfiguration.useCallbackHandler(handler, DEFAULT_CALLBACK_KINDS);
> }
> {code}
> However the AuthenticationClient performs the following sanitation of the specified KINDS: -
> {code:java}
> case SET_USER_CB_KINDS:
> // SANITAZE on above content
> if (this.principal != null) {
> sanitazeOnMutation(SET_PRINCIPAL);
> }
> if (this.credentialSource != null) {
> sanitazeOnMutation(SET_CRED_SOURCE);
> }
> if (this.setRealm != null) {
> sanitazeOnMutation(SET_REALM);
> }
> if (this.parameterSpecs != null) {
> sanitazeOnMutation(SET_PARAM_SPECS);
> }
> if (this.keyManagerFactory != null) {
> sanitazeOnMutation(SET_KEY_MGR_FAC);
> }
> break;
> {code}
> Before passing in the CallbackHandler and specifying which KINDS is applies to the ProtocolConnectionUtils call should first remove the duplicates from the configuration.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 2 months
[JBoss JIRA] (WFCORE-4976) Where ModelControllerClient is initialised in process with CBH AuthenticationConfiguration takes priority.
by Darran Lofthouse (Jira)
[ https://issues.redhat.com/browse/WFCORE-4976?page=com.atlassian.jira.plug... ]
Darran Lofthouse updated WFCORE-4976:
-------------------------------------
Component/s: CLI
(was: Management)
> Where ModelControllerClient is initialised in process with CBH AuthenticationConfiguration takes priority.
> ----------------------------------------------------------------------------------------------------------
>
> Key: WFCORE-4976
> URL: https://issues.redhat.com/browse/WFCORE-4976
> Project: WildFly Core
> Issue Type: Bug
> Components: CLI, Security
> Reporter: Darran Lofthouse
> Assignee: Darran Lofthouse
> Priority: Major
> Labels: downstream_dependency
> Fix For: 12.0.0.Beta4, 12.0.0.Final
>
>
> In ProtocolConnectionUtils we have the following code to pass in the provided CallbackHanldler: -
> {code:java}
> if (handler != null) {
> mergedConfiguration = mergedConfiguration.useCallbackHandler(handler, DEFAULT_CALLBACK_KINDS);
> }
> {code}
> However the AuthenticationClient performs the following sanitation of the specified KINDS: -
> {code:java}
> case SET_USER_CB_KINDS:
> // SANITAZE on above content
> if (this.principal != null) {
> sanitazeOnMutation(SET_PRINCIPAL);
> }
> if (this.credentialSource != null) {
> sanitazeOnMutation(SET_CRED_SOURCE);
> }
> if (this.setRealm != null) {
> sanitazeOnMutation(SET_REALM);
> }
> if (this.parameterSpecs != null) {
> sanitazeOnMutation(SET_PARAM_SPECS);
> }
> if (this.keyManagerFactory != null) {
> sanitazeOnMutation(SET_KEY_MGR_FAC);
> }
> break;
> {code}
> Before passing in the CallbackHandler and specifying which KINDS is applies to the ProtocolConnectionUtils call should first remove the duplicates from the configuration.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 2 months
[JBoss JIRA] (JGRP-2478) Fibers: test performance versus regular threads
by Bela Ban (Jira)
[ https://issues.redhat.com/browse/JGRP-2478?page=com.atlassian.jira.plugin... ]
Bela Ban updated JGRP-2478:
---------------------------
Description:
Test performance on the latest JDK-15-loom with {{use_fibers="true"/"false"}}.
This requires a few code changes:
* There's no need to pool fibers, see [1] for details
* If fibers are used, {{thread_pool}} and {{internal_pool}} in {{TP}} could be assigned the result of {{Executors.newVirtualThreadExecutor()}}
* In a future version, we could simply remove the 2 thread pools
[1] [https://cr.openjdk.java.net/~rpressler/loom/loom/sol1_part1.html]
was:
Test performance on the latest JDK-15-loom with {{use_fibers="true"/"false"}}.
This requires a few code changes:
* There's no need to pool fibers, see [1] for details
* If fibers are used, {{thread_pool}} and {{internal_pool}} in {{TP}} could be assigned the result of {{Executors.newVirtualThreadExecutor()}}
* In a future version, we could simply remove the 2 thread pool
[1] [https://cr.openjdk.java.net/~rpressler/loom/loom/sol1_part1.html]
> Fibers: test performance versus regular threads
> -----------------------------------------------
>
> Key: JGRP-2478
> URL: https://issues.redhat.com/browse/JGRP-2478
> Project: JGroups
> Issue Type: Task
> Reporter: Bela Ban
> Assignee: Bela Ban
> Priority: Major
> Fix For: 5.0.0.Final
>
>
> Test performance on the latest JDK-15-loom with {{use_fibers="true"/"false"}}.
> This requires a few code changes:
> * There's no need to pool fibers, see [1] for details
> * If fibers are used, {{thread_pool}} and {{internal_pool}} in {{TP}} could be assigned the result of {{Executors.newVirtualThreadExecutor()}}
> * In a future version, we could simply remove the 2 thread pools
> [1] [https://cr.openjdk.java.net/~rpressler/loom/loom/sol1_part1.html]
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 2 months
[JBoss JIRA] (JGRP-2478) Fibers: test performance versus regular threads
by Bela Ban (Jira)
[ https://issues.redhat.com/browse/JGRP-2478?page=com.atlassian.jira.plugin... ]
Bela Ban updated JGRP-2478:
---------------------------
Description:
Test performance on the latest JDK-15-loom with {{use_fibers="true"/"false"}}.
This requires a few code changes:
* There's no need to pool fibers, see [1] for details
* If fibers are used, {{thread_pool}} and {{internal_pool}} in {{TP}} could be assigned the result of {{Executors.newVirtualThreadExecutor()}}
* In a future version, we could simply remove the 2 thread pool
[1] [https://cr.openjdk.java.net/~rpressler/loom/loom/sol1_part1.html]
was:
Test performance on the latest JDK-15-loom with {{use_fibers="true"/"false"}}.
This requires a few code changes:
* There's no need to pool fibers, see [1] for details
* If fibers are used, {{thread_pool}} and {{internal_pool}} in {{TP}} could be assigned the result of {{Executors.newVirtualThradExecutor()}}
* In a future version, we could simply remove the 2 thread pool
[1] [https://cr.openjdk.java.net/~rpressler/loom/loom/sol1_part1.html]
> Fibers: test performance versus regular threads
> -----------------------------------------------
>
> Key: JGRP-2478
> URL: https://issues.redhat.com/browse/JGRP-2478
> Project: JGroups
> Issue Type: Task
> Reporter: Bela Ban
> Assignee: Bela Ban
> Priority: Major
> Fix For: 5.0.0.Final
>
>
> Test performance on the latest JDK-15-loom with {{use_fibers="true"/"false"}}.
> This requires a few code changes:
> * There's no need to pool fibers, see [1] for details
> * If fibers are used, {{thread_pool}} and {{internal_pool}} in {{TP}} could be assigned the result of {{Executors.newVirtualThreadExecutor()}}
> * In a future version, we could simply remove the 2 thread pool
> [1] [https://cr.openjdk.java.net/~rpressler/loom/loom/sol1_part1.html]
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 2 months