[JBoss JIRA] (DROOLS-5442) [Guided Decision Table] Key navigation failure in Descision table
by Jozef Marko (Jira)
[ https://issues.redhat.com/browse/DROOLS-5442?page=com.atlassian.jira.plug... ]
Jozef Marko commented on DROOLS-5442:
-------------------------------------
Sent PR is in draft state as the component is general. Checking if tests of other repositories are not affected. Then tests for actual changes will be provided.
> [Guided Decision Table] Key navigation failure in Descision table
> -----------------------------------------------------------------
>
> Key: DROOLS-5442
> URL: https://issues.redhat.com/browse/DROOLS-5442
> Project: Drools
> Issue Type: Bug
> Components: Guided Decision Table Editor
> Affects Versions: 7.39.0.Final
> Reporter: Anna Dupliak
> Assignee: Jozef Marko
> Priority: Major
> Labels: decision_table, drools-tools
> Attachments: arrow.webm, image-2020-06-18-15-04-15-605.png, image-2020-06-18-15-06-26-220.png
>
>
> When user navigates among columns from Description to any other - he need to push right arrow key twice to skip a hidden column introduced recently for decision tables.
> !image-2020-06-18-15-04-15-605.png|thumbnail!
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 2 months
[JBoss JIRA] (DROOLS-5465) [Guided Decision Table] Key navigation failure in Descision table
by Jozef Marko (Jira)
Jozef Marko created DROOLS-5465:
-----------------------------------
Summary: [Guided Decision Table] Key navigation failure in Descision table
Key: DROOLS-5465
URL: https://issues.redhat.com/browse/DROOLS-5465
Project: Drools
Issue Type: Bug
Components: Guided Decision Table Editor
Affects Versions: 7.39.0.Final
Reporter: Jozef Marko
Assignee: Jozef Marko
Attachments: arrow.webm, image-2020-06-18-15-04-15-605.png, image-2020-06-18-15-06-26-220.png
When user navigates among columns from Description to any other - he need to push right arrow key twice to skip a hidden column introduced recently for decision tables.
!image-2020-06-18-15-04-15-605.png|thumbnail!
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 2 months
[JBoss JIRA] (DROOLS-5442) [Guided Decision Table] Key navigation failure in Descision table
by Jozef Marko (Jira)
[ https://issues.redhat.com/browse/DROOLS-5442?page=com.atlassian.jira.plug... ]
Jozef Marko updated DROOLS-5442:
--------------------------------
Tester: Jan Stastny (was: Jozef Marko)
> [Guided Decision Table] Key navigation failure in Descision table
> -----------------------------------------------------------------
>
> Key: DROOLS-5442
> URL: https://issues.redhat.com/browse/DROOLS-5442
> Project: Drools
> Issue Type: Bug
> Components: Guided Decision Table Editor
> Affects Versions: 7.39.0.Final
> Reporter: Anna Dupliak
> Assignee: Jozef Marko
> Priority: Major
> Labels: decision_table, drools-tools
> Attachments: arrow.webm, image-2020-06-18-15-04-15-605.png, image-2020-06-18-15-06-26-220.png
>
>
> When user navigates among columns from Description to any other - he need to push right arrow key twice to skip a hidden column introduced recently for decision tables.
> !image-2020-06-18-15-04-15-605.png|thumbnail!
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 2 months
[JBoss JIRA] (DROOLS-5442) [Guided Decision Table] Key navigation failure in Descision table
by Jozef Marko (Jira)
[ https://issues.redhat.com/browse/DROOLS-5442?page=com.atlassian.jira.plug... ]
Jozef Marko reassigned DROOLS-5442:
-----------------------------------
Assignee: Jozef Marko (was: Toni Rikkola)
> [Guided Decision Table] Key navigation failure in Descision table
> -----------------------------------------------------------------
>
> Key: DROOLS-5442
> URL: https://issues.redhat.com/browse/DROOLS-5442
> Project: Drools
> Issue Type: Bug
> Components: Guided Decision Table Editor
> Affects Versions: 7.39.0.Final
> Reporter: Anna Dupliak
> Assignee: Jozef Marko
> Priority: Major
> Labels: decision_table, drools-tools
> Attachments: arrow.webm, image-2020-06-18-15-04-15-605.png, image-2020-06-18-15-06-26-220.png
>
>
> When user navigates among columns from Description to any other - he need to push right arrow key twice to skip a hidden column introduced recently for decision tables.
> !image-2020-06-18-15-04-15-605.png|thumbnail!
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 2 months
[JBoss JIRA] (DROOLS-5272) Re-evaluate/refactor KiePMML AST factories
by Gabriele Cardosi (Jira)
[ https://issues.redhat.com/browse/DROOLS-5272?page=com.atlassian.jira.plug... ]
Gabriele Cardosi updated DROOLS-5272:
-------------------------------------
Description:
Re-evaluate implementation of KiePMML AST factories in the view of the mining model specifications.
Reevaluate usage of fieldTypeMap - types.
E.g.: inside
DroolsModelProvider.getKiePMMLDroolsASTCommon the
Map<String, KiePMMLOriginalTypeGeneratedType> fieldTypeMap is populated invoking
addTransformationsDerivedFields. Then, a List<KiePMMLDroolsType> is created out of this map.
Later the same map is also populated by
KiePMMLDataDictionaryASTFactory.factory(fieldTypeMap).declareTypes(dataDictionary).
and the List<KiePMMLDroolsType> retrieved by the latter are added to the one created before.
That means it is not needed to have KiePMMLDerivedFieldASTFactory and KiePMMLDataDictionaryASTFactory returning List<KiePMMLDroolsType> - they can simply instantiate and return a Map<String, KiePMMLOriginalTypeGeneratedType>; the maps may be merged together, and the List<KiePMMLDroolsType> may be created out of that (merged) map.
So
1) KiePMMLDataDictionaryASTFactory and KiePMMLDerivedFieldASTFactory should return only a newly instantiated Map<String, KiePMMLOriginalTypeGeneratedType>
2) inside DroolsModelProvider.getKiePMMLDroolsASTCommon those maps should be merged
3) List<KiePMMLDroolsType> should be created out of the merged map
4) merged map and List<KiePMMLDroolsType> should be propagated as parameters
was:Re-evaluate implementation of KiePMML AST factories in the view of the mining model specifications.
> Re-evaluate/refactor KiePMML AST factories
> ------------------------------------------
>
> Key: DROOLS-5272
> URL: https://issues.redhat.com/browse/DROOLS-5272
> Project: Drools
> Issue Type: Task
> Reporter: Gabriele Cardosi
> Assignee: Gabriele Cardosi
> Priority: Major
> Labels: TrustyAI
>
> Re-evaluate implementation of KiePMML AST factories in the view of the mining model specifications.
> Reevaluate usage of fieldTypeMap - types.
>
> E.g.: inside
> DroolsModelProvider.getKiePMMLDroolsASTCommon the
> Map<String, KiePMMLOriginalTypeGeneratedType> fieldTypeMap is populated invoking
> addTransformationsDerivedFields. Then, a List<KiePMMLDroolsType> is created out of this map.
> Later the same map is also populated by
> KiePMMLDataDictionaryASTFactory.factory(fieldTypeMap).declareTypes(dataDictionary).
> and the List<KiePMMLDroolsType> retrieved by the latter are added to the one created before.
> That means it is not needed to have KiePMMLDerivedFieldASTFactory and KiePMMLDataDictionaryASTFactory returning List<KiePMMLDroolsType> - they can simply instantiate and return a Map<String, KiePMMLOriginalTypeGeneratedType>; the maps may be merged together, and the List<KiePMMLDroolsType> may be created out of that (merged) map.
> So
> 1) KiePMMLDataDictionaryASTFactory and KiePMMLDerivedFieldASTFactory should return only a newly instantiated Map<String, KiePMMLOriginalTypeGeneratedType>
> 2) inside DroolsModelProvider.getKiePMMLDroolsASTCommon those maps should be merged
> 3) List<KiePMMLDroolsType> should be created out of the merged map
> 4) merged map and List<KiePMMLDroolsType> should be propagated as parameters
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 2 months
[JBoss JIRA] (DROOLS-5462) Provide default model name for Pmml models without it
by Gabriele Cardosi (Jira)
[ https://issues.redhat.com/browse/DROOLS-5462?page=com.atlassian.jira.plug... ]
Gabriele Cardosi closed DROOLS-5462.
------------------------------------
> Provide default model name for Pmml models without it
> -----------------------------------------------------
>
> Key: DROOLS-5462
> URL: https://issues.redhat.com/browse/DROOLS-5462
> Project: Drools
> Issue Type: Feature Request
> Reporter: Gabriele Cardosi
> Assignee: Gabriele Cardosi
> Priority: Major
> Labels: TrustyAI
>
> modelName attribute is not mandatory from PMML specs.
> With this ticket a "default" one will be provided soon after pmml file is "unmarshalled" to pmml java instance.
> Generated name would be
> _Pmml File Name_ + _model type_ + _index_ (inside models list)
> e.g.
>
> Pmml File "TestSample.pmml"
> Model type "Regression"
> Position : second (index =1)
>
> generated modelName
> _TestSampleRegression1_
>
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 2 months