[JBoss JIRA] (WFWIP-346) Bootable JAR - Second bootable JAR fails to package if first uses certain layers
by Jean Francois Denise (Jira)
[ https://issues.redhat.com/browse/WFWIP-346?page=com.atlassian.jira.plugin... ]
Jean Francois Denise edited comment on WFWIP-346 at 9/3/20 12:15 PM:
---------------------------------------------------------------------
[~jkasik], very good catch! We have an unwanted JBoss module classes sharing between executions. I have fixed it in this branch, could you give it a try: [https://github.com/jfdenise/wildfly-jar-maven-plugin/tree/WFWIP-346]
Thank-you. Again excellent finding! In addition having such a nice reproducer really really helps.
was (Author: jdenise):
[~jkasik], very good catch! We have an unwanted JBoss module classes sharing between executions. I have fixed it in this branch, could you give it a try: [https://github.com/jfdenise/wildfly-jar-maven-plugin/tree/WFWIP-346]
Thank-you. Again excellent finding!
> Bootable JAR - Second bootable JAR fails to package if first uses certain layers
> --------------------------------------------------------------------------------
>
> Key: WFWIP-346
> URL: https://issues.redhat.com/browse/WFWIP-346
> Project: WildFly WIP
> Issue Type: Bug
> Reporter: Jan Kasik
> Assignee: Jean Francois Denise
> Priority: Critical
>
> See the reproducer: https://github.com/honza-kasik/layer-conflict - there are two Maven modules, each configured to run WildFly Maven JAR plugin.
> If I run {{mvn clean package -Dversion.org.wildfly.jar.plugin=2.0.0.Beta3}}, bootable JAR for app-one builds but for app-two the build ends up with an error and app-two fails to package:
> {noformat}
> [ERROR] Failed to execute goal org.wildfly.plugins:wildfly-jar-maven-plugin:2.0.0.Beta3:package (default) on project app-two: Provisioning failed: Failed to generate standalone.xml on {
> [ERROR] "operation" => "composite",
> [ERROR] "address" => [],
> [ERROR] "rollback-on-runtime-failure" => true,
> [ERROR] "steps" => [
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("interface" => "public")],
> [ERROR] "inet-address" => "${jboss.bind.address:127.0.0.1}"
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.wildfly.extension.bean-validation")]
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.jboss.as.weld")]
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.jboss.as.naming")]
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.jboss.as.ee")]
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.wildfly.extension.io")]
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.wildfly.extension.undertow")]
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.jboss.as.jaxrs")]
> [ERROR] }
> [ERROR] ]
> [ERROR] }: {"WFLYCTL0062: Composite operation failed and was rolled back. Steps that failed:" => {"Operation step-8" => "WFLYCTL0310: Extension module org.jboss.as.jaxrs not found"}}
> {noformat}
> Packaging when running {{mvn clean install -Dversion.org.wildfly.jar.plugin=2.0.0.Beta3 -pl app-two}} ends with success. Same for {{app-one}} only.
> If I replace layers in app-one with layer {{cloud-server}} both modules build successfully.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 8 months
[JBoss JIRA] (WFWIP-346) Bootable JAR - Second bootable JAR fails to package if first uses certain layers
by Jean Francois Denise (Jira)
[ https://issues.redhat.com/browse/WFWIP-346?page=com.atlassian.jira.plugin... ]
Jean Francois Denise commented on WFWIP-346:
--------------------------------------------
[~jkasik], very good catch! We have a unwanted JBoss module classes sharing between executions. I have fixed it in this branch, could you give it a try: [https://github.com/jfdenise/wildfly-jar-maven-plugin/tree/WFWIP-346]
Thank-you. Again excellent finding!
> Bootable JAR - Second bootable JAR fails to package if first uses certain layers
> --------------------------------------------------------------------------------
>
> Key: WFWIP-346
> URL: https://issues.redhat.com/browse/WFWIP-346
> Project: WildFly WIP
> Issue Type: Bug
> Reporter: Jan Kasik
> Assignee: Jean Francois Denise
> Priority: Critical
>
> See the reproducer: https://github.com/honza-kasik/layer-conflict - there are two Maven modules, each configured to run WildFly Maven JAR plugin.
> If I run {{mvn clean package -Dversion.org.wildfly.jar.plugin=2.0.0.Beta3}}, bootable JAR for app-one builds but for app-two the build ends up with an error and app-two fails to package:
> {noformat}
> [ERROR] Failed to execute goal org.wildfly.plugins:wildfly-jar-maven-plugin:2.0.0.Beta3:package (default) on project app-two: Provisioning failed: Failed to generate standalone.xml on {
> [ERROR] "operation" => "composite",
> [ERROR] "address" => [],
> [ERROR] "rollback-on-runtime-failure" => true,
> [ERROR] "steps" => [
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("interface" => "public")],
> [ERROR] "inet-address" => "${jboss.bind.address:127.0.0.1}"
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.wildfly.extension.bean-validation")]
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.jboss.as.weld")]
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.jboss.as.naming")]
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.jboss.as.ee")]
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.wildfly.extension.io")]
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.wildfly.extension.undertow")]
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.jboss.as.jaxrs")]
> [ERROR] }
> [ERROR] ]
> [ERROR] }: {"WFLYCTL0062: Composite operation failed and was rolled back. Steps that failed:" => {"Operation step-8" => "WFLYCTL0310: Extension module org.jboss.as.jaxrs not found"}}
> {noformat}
> Packaging when running {{mvn clean install -Dversion.org.wildfly.jar.plugin=2.0.0.Beta3 -pl app-two}} ends with success. Same for {{app-one}} only.
> If I replace layers in app-one with layer {{cloud-server}} both modules build successfully.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 8 months
[JBoss JIRA] (WFWIP-346) Bootable JAR - Second bootable JAR fails to package if first uses certain layers
by Jean Francois Denise (Jira)
[ https://issues.redhat.com/browse/WFWIP-346?page=com.atlassian.jira.plugin... ]
Jean Francois Denise edited comment on WFWIP-346 at 9/3/20 12:14 PM:
---------------------------------------------------------------------
[~jkasik], very good catch! We have an unwanted JBoss module classes sharing between executions. I have fixed it in this branch, could you give it a try: [https://github.com/jfdenise/wildfly-jar-maven-plugin/tree/WFWIP-346]
Thank-you. Again excellent finding!
was (Author: jdenise):
[~jkasik], very good catch! We have a unwanted JBoss module classes sharing between executions. I have fixed it in this branch, could you give it a try: [https://github.com/jfdenise/wildfly-jar-maven-plugin/tree/WFWIP-346]
Thank-you. Again excellent finding!
> Bootable JAR - Second bootable JAR fails to package if first uses certain layers
> --------------------------------------------------------------------------------
>
> Key: WFWIP-346
> URL: https://issues.redhat.com/browse/WFWIP-346
> Project: WildFly WIP
> Issue Type: Bug
> Reporter: Jan Kasik
> Assignee: Jean Francois Denise
> Priority: Critical
>
> See the reproducer: https://github.com/honza-kasik/layer-conflict - there are two Maven modules, each configured to run WildFly Maven JAR plugin.
> If I run {{mvn clean package -Dversion.org.wildfly.jar.plugin=2.0.0.Beta3}}, bootable JAR for app-one builds but for app-two the build ends up with an error and app-two fails to package:
> {noformat}
> [ERROR] Failed to execute goal org.wildfly.plugins:wildfly-jar-maven-plugin:2.0.0.Beta3:package (default) on project app-two: Provisioning failed: Failed to generate standalone.xml on {
> [ERROR] "operation" => "composite",
> [ERROR] "address" => [],
> [ERROR] "rollback-on-runtime-failure" => true,
> [ERROR] "steps" => [
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("interface" => "public")],
> [ERROR] "inet-address" => "${jboss.bind.address:127.0.0.1}"
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.wildfly.extension.bean-validation")]
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.jboss.as.weld")]
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.jboss.as.naming")]
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.jboss.as.ee")]
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.wildfly.extension.io")]
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.wildfly.extension.undertow")]
> [ERROR] },
> [ERROR] {
> [ERROR] "operation" => "add",
> [ERROR] "address" => [("extension" => "org.jboss.as.jaxrs")]
> [ERROR] }
> [ERROR] ]
> [ERROR] }: {"WFLYCTL0062: Composite operation failed and was rolled back. Steps that failed:" => {"Operation step-8" => "WFLYCTL0310: Extension module org.jboss.as.jaxrs not found"}}
> {noformat}
> Packaging when running {{mvn clean install -Dversion.org.wildfly.jar.plugin=2.0.0.Beta3 -pl app-two}} ends with success. Same for {{app-one}} only.
> If I replace layers in app-one with layer {{cloud-server}} both modules build successfully.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 8 months
[JBoss JIRA] (ELY-2018) Add ability to FileAuditEndpoint to allow file encoding to be overridden.
by Ilia Vassilev (Jira)
[ https://issues.redhat.com/browse/ELY-2018?page=com.atlassian.jira.plugin.... ]
Ilia Vassilev updated ELY-2018:
-------------------------------
Description: The FileAuditEndpoint doesn't allow file encoding to be overridden. It should allow the encoding to be overridden and specify UTF-8 as the default. (was: The {{FileAuditEndpoint}} doesn't allow for the file encoding to be overridden. It should likely allow the encoding to be overridden or at the very least specify {{UTF-8}} as the default. )
> Add ability to FileAuditEndpoint to allow file encoding to be overridden.
> -------------------------------------------------------------------------
>
> Key: ELY-2018
> URL: https://issues.redhat.com/browse/ELY-2018
> Project: WildFly Elytron
> Issue Type: Feature Request
> Reporter: Ilia Vassilev
> Assignee: Ilia Vassilev
> Priority: Major
>
> The FileAuditEndpoint doesn't allow file encoding to be overridden. It should allow the encoding to be overridden and specify UTF-8 as the default.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 8 months
[JBoss JIRA] (DROOLS-5434) Incorrect warning about file declaring wrong package
by Mario Fusco (Jira)
[ https://issues.redhat.com/browse/DROOLS-5434?page=com.atlassian.jira.plug... ]
Mario Fusco commented on DROOLS-5434:
-------------------------------------
[~magnus_larsson] can you please attach a reproducer of this problem?
> Incorrect warning about file declaring wrong package
> ----------------------------------------------------
>
> Key: DROOLS-5434
> URL: https://issues.redhat.com/browse/DROOLS-5434
> Project: Drools
> Issue Type: Bug
> Components: core engine
> Reporter: Magnus Larsson
> Assignee: Mario Fusco
> Priority: Major
> Attachments: image-2020-09-03-09-20-10-089.png
>
>
> I am running Drools in a Spring-Boot jar and get the following warning statement _File 'BOOT-INF/classes/com/example/test/TEST.drl' is in folder 'BOOT-INF/classes/com/example/test' but declares package 'com.example.test'. It is advised to have a correspondance between package and folder names_. The package name in the drl file is correct, the problem is just that _BOOT-INF.classes._ isn't considered when evaluating if printing the warning or not.
> I have tracked it down to *KieBuilderImpl.java*, method *isFileInKieBase*. The last 2 lines in that method calls:
> {code:java}
> // packageNameForFile prints warning if package in .drl file is not same as flatted directory structure
> // Does not care about SUPPORTED_RESOURCES_ROOTS, thus prints the warning
> String pkgNameForFile = packageNameForFile( fileName, folderNameForFile, !useFolders, file );
> // Does care about SUPPORTED_RESOURCES_ROOTS, so the drl file is loaded
> return isPackageInKieBase( kieBase, pkgNameForFile );
> {code}
> As it is implemented right now, the warning might either be a false-positive (and still get loaded), or the package is wrong (and the file is not loaded).
> Voting to include the SUPPORTED_RESOURCES_ROOTS as valid prefixes when checking if the warning should be printed.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 8 months
[JBoss JIRA] (ELY-2017) FileAuditEndpoint doesn't allow for file encoding to be overridden
by Ilia Vassilev (Jira)
Ilia Vassilev created ELY-2017:
----------------------------------
Summary: FileAuditEndpoint doesn't allow for file encoding to be overridden
Key: ELY-2017
URL: https://issues.redhat.com/browse/ELY-2017
Project: WildFly Elytron
Issue Type: Enhancement
Reporter: Ilia Vassilev
Assignee: Ilia Vassilev
The {{FileAuditEndpoint}} doesn't allow for the file encoding to be overridden. It should likely allow the encoding to be overridden or at the very least specify {{UTF-8}} as the default.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 8 months