[JBoss JIRA] (WFLY-13779) MicroProfile Metrics tests started to fail since changes in ConfigSource
by Jeff Mesnil (Jira)
[ https://issues.redhat.com/browse/WFLY-13779?page=com.atlassian.jira.plugi... ]
Jeff Mesnil commented on WFLY-13779:
------------------------------------
I have thought about this more.
The main thing to consider is that with MicroProfile Config, the config sources are added to the Config the first time a class loader calls ConfigProviderResolver.getConfig().
Any addition/removal of a config-source provided by the subsystem will not modify existing Config associated to a ClassLoader.
In case of deployments, that means that the set of ConfigSources is determined when the deployment is deployed.
For WildFly subsystems, that means that the set of ConfigSources is determined when the use MicroProfile Config the first time. Any subsequent modifications to the microprofile-config-smallrye substem will not impact these Configs.
So I think we need to make 2 changes:
* in the WildFly codebase, flag the config-source and config-source-provider :remove operations with RESTART-ALL-SERVICES to properly notify that if these resources are removed, server must be reloaded
* in your test fixture, after removing a config-source-provider, you'll have to reload the server to get it in the proper state.
> MicroProfile Metrics tests started to fail since changes in ConfigSource
> ------------------------------------------------------------------------
>
> Key: WFLY-13779
> URL: https://issues.redhat.com/browse/WFLY-13779
> Project: WildFly
> Issue Type: Bug
> Components: MP Metrics
> Reporter: Sultan Zhantemirov
> Assignee: Jeff Mesnil
> Priority: Major
>
> WildFly build: 21.0.0.Beta1-SNAPSHOT
> Java: oracle-java-11
> A several failures appeared in our small standalone test suite [1] for MicroProfile on WF/EAP. To be more specific, a few failures in MP Metrics that have one common cause:
> {noformat}
> java.lang.RuntimeException: config.source.properties.path property not defined
> {noformat}
> caused by line [2].
> I have a reason to believe that this PR [3] could be reason of these failures. What should be done in this case?
> Thank you.
> [1] - https://github.com/jboss-eap-qe/eap-microprofile-test-suite/tree/master/m...
> [2] - https://github.com/jboss-eap-qe/eap-microprofile-test-suite/blob/8b726042...
> [3] - https://github.com/wildfly/wildfly/pull/13247
>
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 10 months
[JBoss JIRA] (WFLY-13845) Attribute enable-amq1-prefix doesn't work (remote artemis)
by Emmanuel Hugonnet (Jira)
Emmanuel Hugonnet created WFLY-13845:
----------------------------------------
Summary: Attribute enable-amq1-prefix doesn't work (remote artemis)
Key: WFLY-13845
URL: https://issues.redhat.com/browse/WFLY-13845
Project: WildFly
Issue Type: Bug
Components: JMS, Management
Affects Versions: 20.0.1.Final
Reporter: Emmanuel Hugonnet
Assignee: Chao Wang
Fix For: 21.0.0.Beta1
I need to connect Wildfly 17.0.1 to a remote Artemis server. I follow the doc here: [https://docs.wildfly.org/17/Admin_Guide.html#Messaging_Connect_a_pooled-c...] No problem for point 1 to 3. But when I follow the instruction for disabling the compatibility mode (enable-amq1-prefix) I have this error:
{quote}{{[standalone@localhost:9990 /] /subsystem=messaging-activemq/pooled-connection-factory=remote-artemis:write-attribute(name="enable-amq1-prefix", value="false")}}
\{{{}}
\{{ "outcome" => "failed",}}
\{{ "failure-description" => "WFLYCTL0248: Invalid value false for enable-amq1-prefix; legal values are [XA_GENERIC, GENERIC, XA_T}}
{{OPIC, TOPIC, QUEUE, XA_QUEUE]",}}
\{{ "rolled-back" => true}}
{{}}}
{quote}
If I deploy my MDB that connects to queue myqueue, I see in artemis console my MDB is connected to jms.queue.myqueue.
I also tried to add the attribute manually but it seems it doesn't work:
{quote}{{<pooled-connection-factory name="remote-artemis" entries="java:/}}{{jms/remoteCF}}{{" connectors="remote-artemis" enable-amq1-prefix="false"/>}}
{quote}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 10 months
[JBoss JIRA] (WFCORE-5131) (7.3.z) The embedded host and server handlers hang on start
by Ivo Studensky (Jira)
Ivo Studensky created WFCORE-5131:
-------------------------------------
Summary: (7.3.z) The embedded host and server handlers hang on start
Key: WFCORE-5131
URL: https://issues.redhat.com/browse/WFCORE-5131
Project: WildFly Core
Issue Type: Bug
Components: Embedded
Affects Versions: 12.0.0.Beta1
Reporter: Ivo Studensky
Assignee: Yeray Borges Santana
Fix For: 12.0.0.Beta2, 12.0.0.Final
Recently we changed the way the {{EmbedHostControllerHandler}} and {{EmbedServerHandler}} wait for the embedded host/server until it starts.
We were using a pooling executing management operations to check the process state. We needed a different solution to be able to check the process state when the embedded host/server was launched with and empty configuration file.
In the new approach we exposed the process state to the client so it can be directly pooling without requiring a management operation.
Currently the update of this internal field is racy, and a hang can occurs starting the embedded.
We saw this bug in the CI test suite: https://ci.wildfly.org/viewLog.html?buildId=197876&buildTypeId=WF_MasterW...
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 10 months
[JBoss JIRA] (WFCORE-5130) (7.3.z) Expose the process state from the embed server and controller
by Ivo Studensky (Jira)
Ivo Studensky created WFCORE-5130:
-------------------------------------
Summary: (7.3.z) Expose the process state from the embed server and controller
Key: WFCORE-5130
URL: https://issues.redhat.com/browse/WFCORE-5130
Project: WildFly Core
Issue Type: Enhancement
Components: Embedded
Reporter: Ivo Studensky
Assignee: Yeray Borges Santana
Fix For: 12.0.0.Beta1, 12.0.0.Final
When we are starting the embedded managed server or host controller we are polling for the process state to verify when the server or host controller are ready for the caller.
The polling is problematic to cover the case for an embedded managed host controller started with an empty host configuration file. The polling requires a host name to poll for its state and with an empty host configuration, we don't have such host to poll.
This situation ends up returning to the client the model controller as soon as we have requested to start the managed host controller, that means the model controller can be used by a client even when the host controller process state is still starting, which is problematic. This is a rare case found in s390 machines.
The embedded managed server / host has already a reference to the process state, the enhancement here is to expose its value so any client can check and poll based on the current value, instead of polling by executing a management operation.
This enhancement should help Galleon to return to the caller a model controller client that is ready to use.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 10 months
[JBoss JIRA] (WFCORE-5129) (7.3.z) EmbeddedServer can't interact with version <12
by Ivo Studensky (Jira)
Ivo Studensky created WFCORE-5129:
-------------------------------------
Summary: (7.3.z) EmbeddedServer can't interact with version <12
Key: WFCORE-5129
URL: https://issues.redhat.com/browse/WFCORE-5129
Project: WildFly Core
Issue Type: Bug
Components: Embedded
Affects Versions: 12.0.1.Final
Reporter: Ivo Studensky
Assignee: Yeray Borges Santana
Fix For: 13.0.0.Beta2
I am in context where an embedded server version 12.x is started for a version 11 (or 10) of wildfly-core.
This occurs with Bootable JAR maven plugin that depends on 12.x for its CLI support.
This can also happen using CLI shaded client JAR of WildFly 20 to start an embedded server for a WildFly 19 installation.
The problem has been introduced by https://issues.redhat.com/browse/WFCORE-4893 that defined a new method not supported by older versions.
The EmbeddedServer should be able to fallback to legacy logic if the new method is not present.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 10 months
[JBoss JIRA] (WFLY-13838) plain text j_password appears in the legacy audit log
by Hisanobu Okuda (Jira)
[ https://issues.redhat.com/browse/WFLY-13838?page=com.atlassian.jira.plugi... ]
Hisanobu Okuda updated WFLY-13838:
----------------------------------
Git Pull Request: https://github.com/wildfly/wildfly/pull/13553 (was: https://github.com/wildfly/wildfly/pull/13547)
> plain text j_password appears in the legacy audit log
> -----------------------------------------------------
>
> Key: WFLY-13838
> URL: https://issues.redhat.com/browse/WFLY-13838
> Project: WildFly
> Issue Type: Bug
> Components: Web (Undertow)
> Affects Versions: 20.0.1.Final
> Reporter: Hisanobu Okuda
> Assignee: Hisanobu Okuda
> Priority: Major
> Fix For: 21.0.0.Beta1
>
> Attachments: web-form-auth.tar.gz
>
>
> The unmasked value of j_password is written in the audit log as `[parameters=guest::,guest::,]`.
> {code}
> 12:48:45,385 TRACE [org.jboss.security.audit] (default task-1) [Success]principal=guest;request=[/test:cookies=[javax.servlet.http.Cookie@46b3f22]:headers=Origin=http://localhost:8080,Cookie=JSESSIONID=dbDjUA6QeA2UXCyyPaqdSSgE4Kjd0_JvxUG7-pBx.localhost,Accept=text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8,User-Agent=Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:79.0) Gecko/20100101 Firefox/79.0,Connection=keep-alive,Referer=http://localhost:8080/test/secure/index.jsp,Host=localhost:8080,Accept-Encoding=gzip, deflate,DNT=1,Upgrade-Insecure-Requests=1,Accept-Language=en-US,en;q=0.5,Content-Length=33,Content-Type=application/x-www-form-urlencoded,][parameters=guest::,guest::,][attributes=];message=UT000030: User guest successfully authenticated.;Source=org.wildfly.extension.undertow.security.AuditNotificationReceiver;
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 10 months