[JBoss JIRA] (SSLNTV-5) Ensure that protoVersion is initialized in ssl.c
by Farah Juma (Jira)
[ https://issues.redhat.com/browse/SSLNTV-5?page=com.atlassian.jira.plugin.... ]
Farah Juma updated SSLNTV-5:
----------------------------
Fix Version/s: 2.1.0.SP01
> Ensure that protoVersion is initialized in ssl.c
> ------------------------------------------------
>
> Key: SSLNTV-5
> URL: https://issues.redhat.com/browse/SSLNTV-5
> Project: WildFly OpenSSL Natives
> Issue Type: Bug
> Reporter: Farah Juma
> Assignee: Farah Juma
> Priority: Major
> Fix For: 2.1.0.SP01
>
>
> The following error occurs when building on MacOS:
> {code}
> [INFO] --- exec-maven-plugin:1.6.0:exec (default) @ wildfly-openssl-macosx-x86_64 ---
> mkdir -p target/classes/macosx-x86_64
> cc -Werror -Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wpointer-arith -std=c89 -Wdeclaration-after-statement -Wformat -Wformat-security -Wunused -Wno-unknown-pragmas -c ../libwfssl/src/alpn.c -o target/alpn.o -I../libwfssl/include -I/Users/darranlofthouse/applications/jdk-11.0.2.jdk/Contents/Home/include -I/Users/darranlofthouse/applications/jdk-11.0.2.jdk/Contents/Home/include/darwin
> cc -Werror -Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wpointer-arith -std=c89 -Wdeclaration-after-statement -Wformat -Wformat-security -Wunused -Wno-unknown-pragmas -c ../libwfssl/src/clientcert.c -o target/clientcert.o -I../libwfssl/include -I/Users/darranlofthouse/applications/jdk-11.0.2.jdk/Contents/Home/include -I/Users/darranlofthouse/applications/jdk-11.0.2.jdk/Contents/Home/include/darwin
> cc -Werror -Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wpointer-arith -std=c89 -Wdeclaration-after-statement -Wformat -Wformat-security -Wunused -Wno-unknown-pragmas -c ../libwfssl/src/options.c -o target/options.o -I../libwfssl/include -I/Users/darranlofthouse/applications/jdk-11.0.2.jdk/Contents/Home/include -I/Users/darranlofthouse/applications/jdk-11.0.2.jdk/Contents/Home/include/darwin
> cc -Werror -Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wpointer-arith -std=c89 -Wdeclaration-after-statement -Wformat -Wformat-security -Wunused -Wno-unknown-pragmas -c ../libwfssl/src/session.c -o target/session.o -I../libwfssl/include -I/Users/darranlofthouse/applications/jdk-11.0.2.jdk/Contents/Home/include -I/Users/darranlofthouse/applications/jdk-11.0.2.jdk/Contents/Home/include/darwin
> cc -Werror -Wall -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wpointer-arith -std=c89 -Wdeclaration-after-statement -Wformat -Wformat-security -Wunused -Wno-unknown-pragmas -c ../libwfssl/src/ssl.c -o target/ssl.o -I../libwfssl/include -I/Users/darranlofthouse/applications/jdk-11.0.2.jdk/Contents/Home/include -I/Users/darranlofthouse/applications/jdk-11.0.2.jdk/Contents/Home/include/darwin
> ../libwfssl/src/ssl.c:604:25: error: variable 'protoVersion' is used uninitialized whenever 'for' loop exits because its condition is false [-Werror,-Wsometimes-uninitialized]
> for (i = 0; i < 6; i++) {
> ^~~~~
> ../libwfssl/src/ssl.c:610:81: note: uninitialized use occurs here
> ssl_methods.SSL_CTX_ctrl((c->ctx), SSL_CTRL_SET_MIN_PROTO_VERSION, (protoVersion), NULL);
> ^~~~~~~~~~~~
> ../libwfssl/src/ssl.c:604:25: note: remove the condition if it is always true
> for (i = 0; i < 6; i++) {
> ^~~~~
> ../libwfssl/src/ssl.c:550:21: note: initialize the variable 'protoVersion' to silence this warning
> int protoVersion;
> ^
> = 0
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 10 months
[JBoss JIRA] (SSLNTV-6) Allow JDK 8 to be used for linux-i386
by Farah Juma (Jira)
Farah Juma created SSLNTV-6:
-------------------------------
Summary: Allow JDK 8 to be used for linux-i386
Key: SSLNTV-6
URL: https://issues.redhat.com/browse/SSLNTV-6
Project: WildFly OpenSSL Natives
Issue Type: Bug
Reporter: Farah Juma
Assignee: Farah Juma
There isn't a 32-bit JDK 11 version for Linux so we're going to allow JDK 8 to be used to build linux-i386.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 10 months
[JBoss JIRA] (WFLY-13779) MicroProfile Metrics tests started to fail since changes in ConfigSource
by Jeff Mesnil (Jira)
[ https://issues.redhat.com/browse/WFLY-13779?page=com.atlassian.jira.plugi... ]
Jeff Mesnil commented on WFLY-13779:
------------------------------------
This issue appeared after WFLY-12549 because now subsystems can depend on microprofile-config-smallrye resources for their configurations.
Before that bug fix, subsystems were not able to use them (which was not correct from a MP point of view) and this bug was hidden.
But you would have encountered the same issue if you had:
* set a sys prop
* add a config-source that depends on this sysprop
* deploy an application that calls Config.getConfig()
* removes the sys prop
=> at that point the application would use the config-source prop that is no longer correct and it would throw an exception similar to yours.
I'll add a test to WildFly to highlight this issue.
> MicroProfile Metrics tests started to fail since changes in ConfigSource
> ------------------------------------------------------------------------
>
> Key: WFLY-13779
> URL: https://issues.redhat.com/browse/WFLY-13779
> Project: WildFly
> Issue Type: Bug
> Components: MP Metrics
> Reporter: Sultan Zhantemirov
> Assignee: Jeff Mesnil
> Priority: Major
>
> WildFly build: 21.0.0.Beta1-SNAPSHOT
> Java: oracle-java-11
> A several failures appeared in our small standalone test suite [1] for MicroProfile on WF/EAP. To be more specific, a few failures in MP Metrics that have one common cause:
> {noformat}
> java.lang.RuntimeException: config.source.properties.path property not defined
> {noformat}
> caused by line [2].
> I have a reason to believe that this PR [3] could be reason of these failures. What should be done in this case?
> Thank you.
> [1] - https://github.com/jboss-eap-qe/eap-microprofile-test-suite/tree/master/m...
> [2] - https://github.com/jboss-eap-qe/eap-microprofile-test-suite/blob/8b726042...
> [3] - https://github.com/wildfly/wildfly/pull/13247
>
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 10 months