[JBoss JIRA] (WFLY-13832) Bug in detecting the org.apache.cxf module
by Tomas Hofman (Jira)
[ https://issues.redhat.com/browse/WFLY-13832?page=com.atlassian.jira.plugi... ]
Tomas Hofman moved JBEAP-20167 to WFLY-13832:
---------------------------------------------
Project: WildFly (was: JBoss Enterprise Application Platform)
Key: WFLY-13832 (was: JBEAP-20167)
Workflow: GIT Pull Request workflow (was: CDW with loose statuses v1)
Component/s: Web Services
(was: Web Services)
Affects Version/s: (was: 7.3.0.GA)
> Bug in detecting the org.apache.cxf module
> ------------------------------------------
>
> Key: WFLY-13832
> URL: https://issues.redhat.com/browse/WFLY-13832
> Project: WildFly
> Issue Type: Bug
> Components: Web Services
> Reporter: Tomas Hofman
> Assignee: Jim Ma
> Priority: Major
>
> When deploying an EAR file which has a sub deployment that uses CXF annotation classes a warning is logged that looks like this:
> WFLYWS0065: Annotation '@org.apache.cxf.interceptor.OutInterceptors' found on class 'de.comdirect.application.mt.wsexample.server.SimpleWsServiceWS'. Perhaps you forgot to add a 'org.apache.cxf' module dependency to your deployment?
> If you declare a dependency on org.apache.cxf in the sub-deployment, the warning is not logged. However, if you declare the org.apache.cxf dependency at the EAR level with export=true you still get the message even though the CXF module should be visible.
> I tracked down the class org.jboss.as.webservices.deployers.WSClassVerificationProcessor located in the org/jboss/as/webservices/main/wildfly-webservices-server-integration-7.3.0.GA-redhat-00004.jar
> In this class there is a method which logs this message, plus an additional related method:
> private void verifyApacheCXFModuleDependencyRequirement(DeploymentUnit unit) {
> if (!hasCxfModuleDependency(unit)) {
>
> CompositeIndex index = (CompositeIndex)unit.getAttachment(Attachments.COMPOSITE_ANNOTATION_INDEX);
> DotName[] dotNames = \{ DotNames.WEB_SERVICE_ANNOTATION, DotNames.WEB_SERVICE_PROVIDER_ANNOTATION };
> for (DotName dotName : dotNames) {
> for (AnnotationInstance ai : index.getAnnotations(dotName)) {
> AnnotationTarget at = ai.target();
> if (at instanceof ClassInfo) {
> ClassInfo clazz = (ClassInfo)ai.target();
> for (DotName dn : clazz.annotations().keySet()) {
> if (dn.toString().startsWith("org.apache.cxf")) {
> WSLogger.ROOT_LOGGER.missingModuleDependency(dn.toString(), clazz.name().toString(), "org.apache.cxf");
> }
> }
> }
> }
> }
> }
> }
> private static boolean hasCxfModuleDependency(DeploymentUnit unit) {
> ModuleSpecification moduleSpec = (ModuleSpecification)unit.getAttachment(Attachments.MODULE_SPECIFICATION);
> for (ModuleDependency dep : moduleSpec.getUserDependencies()) {
> String id = dep.getIdentifier().getName();
> if (cxfExportingModules.contains(id)) {
> return true;
> }
> }
> return false;
> }
> The hasCxfModuleDependency() method checks a list of dependencies called userDependencies looking to see if there is an "org.apache.cxf" entry in the list.
> However, there is more than one list of module dependencies which are part of moduleSpec.
> private final List<ModuleDependency> systemDependencies = new ArrayList();
> private final List<ModuleDependency> localDependencies = new ArrayList();
> private final List<ModuleDependency> userDependencies = new ArrayList();
> I think when you have an exported dependency from the EAR level it may be part of one of the other dependency lists rather than in userDependencies, so what we have is well-meaning code that tries to check and make sure you have the right dependency to support your annotation (because normally missing annotation classes just fail silently so a check is useful to have), but I think it doesn't check everywhere that it should.
> Since the EAP 7.3.1 patch just came out, I installed that and repeated the test but there was no difference.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 3 months
[JBoss JIRA] (DROOLS-5613) Disable Trusty pmml when jpmml is present
by Gabriele Cardosi (Jira)
[ https://issues.redhat.com/browse/DROOLS-5613?page=com.atlassian.jira.plug... ]
Gabriele Cardosi closed DROOLS-5613.
------------------------------------
> Disable Trusty pmml when jpmml is present
> -----------------------------------------
>
> Key: DROOLS-5613
> URL: https://issues.redhat.com/browse/DROOLS-5613
> Project: Drools
> Issue Type: Task
> Reporter: Gabriele Cardosi
> Assignee: Gabriele Cardosi
> Priority: Blocker
> Labels: TrustyAI
>
> Inside trusty PMMLAssembler:
> 1. copy/refactor isjPMMLAvailableToClassLoader (from legacy PMMLAssembler)
> 2. modify
> {code:java}
> private static boolean isToEnable()
> {code}
> to always return "false" when jpmml is present
> Inside legacy PMMLAssembler:
> 1. modify
> {code:java}
> private static boolean isToEnable()
> {code}
> to always return "false" when jpmml is present
> 2. remove isjPMMLAvailableToClassLoader invocation from
> {code:java}
> private void addPackage(Resource resource)
> {code}
> 3. modify isjPMMLAvailableToClassLoader to log when jpmml is present
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 3 months
[JBoss JIRA] (WFWIP-330) Bootable JAR - Cloud - No HA support in default configuration.
by Martin Choma (Jira)
[ https://issues.redhat.com/browse/WFWIP-330?page=com.atlassian.jira.plugin... ]
Martin Choma closed WFWIP-330.
------------------------------
I can verify issue was resolved in wildfly-jar-maven-plugin version Beta6.
> Bootable JAR - Cloud - No HA support in default configuration.
> --------------------------------------------------------------
>
> Key: WFWIP-330
> URL: https://issues.redhat.com/browse/WFWIP-330
> Project: WildFly WIP
> Issue Type: Bug
> Reporter: Jean Francois Denise
> Assignee: Jean Francois Denise
> Priority: Major
>
> When no Galleon Layers are provisioned, the default configuration standalone-microprofile.xml is used. For cloud, having an HA configuration makes more sense.
> The Bootable JAR maven plugin should provision a standalone-microprofile-ha.xml
> NB: HA features are enabled for WildFly/EAP/XP S2I builder image default configurations.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 3 months
[JBoss JIRA] (WFWIP-329) Bootable JAR - Cloud - Disable management console in mgmt http-interface
by Martin Choma (Jira)
[ https://issues.redhat.com/browse/WFWIP-329?page=com.atlassian.jira.plugin... ]
Martin Choma closed WFWIP-329.
------------------------------
I can verify issue was resolved in wildfly-jar-maven-plugin version Beta6.
> Bootable JAR - Cloud - Disable management console in mgmt http-interface
> ------------------------------------------------------------------------
>
> Key: WFWIP-329
> URL: https://issues.redhat.com/browse/WFWIP-329
> Project: WildFly WIP
> Issue Type: Bug
> Reporter: Jean Francois Denise
> Assignee: Jean Francois Denise
> Priority: Major
>
> The console is disabled for config run in EAP/XP s2i builder image. It makes sense to apply the same change for Bootable JAR when cloud is enabled. So a CLI script will run to disable it (if management interface exists):
> /core-service=management/management-interface=http-interface:write-attribute(name=console-enabled,value=false)
>
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 3 months
[JBoss JIRA] (WFLY-12586) Duplicated classes in testsuite, content slightly differs in some cases
by Parul Sharma (Jira)
[ https://issues.redhat.com/browse/WFLY-12586?page=com.atlassian.jira.plugi... ]
Parul Sharma commented on WFLY-12586:
-------------------------------------
As per my analysis, only WebInfLib.java is a duplicate class, other classes are running in different parts of the test suite with code changes. I think we should not consider as duplicate classes.
> Duplicated classes in testsuite, content slightly differs in some cases
> -----------------------------------------------------------------------
>
> Key: WFLY-12586
> URL: https://issues.redhat.com/browse/WFLY-12586
> Project: WildFly
> Issue Type: Bug
> Components: Test Suite
> Reporter: Rostislav Svoboda
> Assignee: Parul Sharma
> Priority: Major
>
> There are duplicated classes in testsuite, content slightly differs in some cases
> {code}
> for i in `find . | grep '.*src.*\.java$' | sed "s,.*src/main/java/,,g" | sed "s,.*src/test/java/,,g" | sort | uniq -c | sort -n | grep "2 " | cut -d" " -f 5-`; do echo "$i"; find . | grep "$i"; echo ""; done
> org/jboss/as/test/integration/deployment/classloading/war/WebInfLibClass.java
> ./integration/web/src/test/java/org/jboss/as/test/integration/deployment/classloading/war/WebInfLibClass.java
> ./integration/basic/src/test/java/org/jboss/as/test/integration/deployment/classloading/war/WebInfLibClass.java
> org/jboss/as/test/integration/deployment/deploymentoverlay/DeploymentOverlayTestCase.java
> ./integration/web/src/test/java/org/jboss/as/test/integration/deployment/deploymentoverlay/DeploymentOverlayTestCase.java
> ./integration/basic/src/test/java/org/jboss/as/test/integration/deployment/deploymentoverlay/DeploymentOverlayTestCase.java
> org/jboss/as/test/integration/ejb/security/EjbSecurityDomainSetup.java
> ./integration/basic/src/test/java/org/jboss/as/test/integration/ejb/security/EjbSecurityDomainSetup.java
> ./integration/ws/src/test/java/org/jboss/as/test/integration/ejb/security/EjbSecurityDomainSetup.java
> org/jboss/as/test/integration/web/security/SecuredServlet.java
> ./integration/web/src/test/java/org/jboss/as/test/integration/web/security/SecuredServlet.java
> ./integration/basic/src/test/java/org/jboss/as/test/integration/web/security/SecuredServlet.java
> org/jboss/as/test/integration/web/security/WebSimpleRoleMappingSecurityDomainSetup.java
> ./integration/web/src/test/java/org/jboss/as/test/integration/web/security/WebSimpleRoleMappingSecurityDomainSetup.java
> ./integration/basic/src/test/java/org/jboss/as/test/integration/web/security/WebSimpleRoleMappingSecurityDomainSetup.java
> org/jboss/as/test/integration/web/security/WebTestsSecurityDomainSetup.java
> ./integration/web/src/test/java/org/jboss/as/test/integration/web/security/WebTestsSecurityDomainSetup.java
> ./integration/basic/src/test/java/org/jboss/as/test/integration/web/security/WebTestsSecurityDomainSetup.java
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 3 months