[Red Hat JIRA] (ELY-1745) The AvailableRealmsCallback should not result in a NPE if there is no mechanism configuration.
by Darran Lofthouse (Jira)
[ https://issues.redhat.com/browse/ELY-1745?page=com.atlassian.jira.plugin.... ]
Darran Lofthouse updated ELY-1745:
----------------------------------
Fix Version/s: 1.14.2.CR1
(was: 1.14.1.Final)
> The AvailableRealmsCallback should not result in a NPE if there is no mechanism configuration.
> ----------------------------------------------------------------------------------------------
>
> Key: ELY-1745
> URL: https://issues.redhat.com/browse/ELY-1745
> Project: WildFly Elytron
> Issue Type: Bug
> Components: API / SPI
> Reporter: Darran Lofthouse
> Assignee: Martin Mazánek
> Priority: Major
> Fix For: 1.14.2.CR1
>
>
> The NPE is due to the following code: -
> {noformat}
> } else if (callback instanceof AvailableRealmsCallback) {
> Collection<String> names = stateRef.get().getMechanismConfiguration().getMechanismRealmNames();
> if (log.isTraceEnabled()) {
> log.tracef("Handling AvailableRealmsCallback: realms = [%s]", String.join(", ", names));
> }
> if (! names.isEmpty()) {
> ((AvailableRealmsCallback) callback).setRealmNames(names.toArray(new String[names.size()]));
> }
> handleOne(callbacks, idx + 1);
> {noformat}
> If mechanism configuration is mandatory this should report an appropriate error, if not it should fallback to specifying an empty list.
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
5 years, 3 months
[Red Hat JIRA] (ELY-1994) Ensure the Elytron build works on Java 14
by Darran Lofthouse (Jira)
[ https://issues.redhat.com/browse/ELY-1994?page=com.atlassian.jira.plugin.... ]
Darran Lofthouse updated ELY-1994:
----------------------------------
Fix Version/s: 1.14.2.CR1
(was: 1.14.1.Final)
> Ensure the Elytron build works on Java 14
> -----------------------------------------
>
> Key: ELY-1994
> URL: https://issues.redhat.com/browse/ELY-1994
> Project: WildFly Elytron
> Issue Type: Task
> Components: Testsuite
> Reporter: Darran Lofthouse
> Priority: Major
> Fix For: 1.14.2.CR1
>
>
> Overall the build is not doing too badly and doesn't fail until we get to the main testsuite.
>
> {code:java}
> [INFO] WildFly Elytron - Tests ............................ FAILURE [ 1.447 s]
> [INFO] WildFly Elytron .................................... SKIPPED
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:46 min
> [INFO] Finished at: 2020-06-11T11:25:23+01:00
> [INFO] ------------------------------------------------------------------------
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0-jboss-1:testCompile (default-testCompile) on project wildfly-elytron-tests: Compilation failure: Compilation failure:
> [ERROR] /home/darranl/src/community/wildfly-elytron/tests/base/src/test/java/org/wildfly/security/auth/TestLoginModule.java:[31,25] package java.security.acl does not exist
> [ERROR] /home/darranl/src/community/wildfly-elytron/tests/base/src/test/java/org/wildfly/security/auth/TestLoginModule.java:[107,40] cannot find symbol
> [ERROR] symbol: class Group
> [ERROR] location: class org.wildfly.security.auth.TestLoginModule
> [ERROR] -> [Help 1] {code}
> If this is all that is failing for us maybe we can revisit the test and see how appropriate it is and if it can be adapted to use available APIs.
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
5 years, 3 months