[Red Hat JIRA] (JGRP-2523) Cap max data read by TcpConnection or NioConnection
by Bela Ban (Jira)
[ https://issues.redhat.com/browse/JGRP-2523?page=com.atlassian.jira.plugin... ]
Bela Ban resolved JGRP-2523.
----------------------------
Resolution: Done
> Cap max data read by TcpConnection or NioConnection
> ---------------------------------------------------
>
> Key: JGRP-2523
> URL: https://issues.redhat.com/browse/JGRP-2523
> Project: JGroups
> Issue Type: Feature Request
> Reporter: Bela Ban
> Assignee: Bela Ban
> Priority: Minor
> Fix For: 4.2.11, 5.1.3
>
>
> Both NioConnection and TcpConnection read the length (4 bytes) first, then allocate a buffer and call InputStream.readFully().
> If some random client ({{nc}}, {{curl}}, {{wget}} etc)connects accidentally, {{length}} might be huge and the memory allocation will fail with an OOME. This may even terminate the JVM, e.g. if {{-XX:+ExitOnOutOfMemoryError}} is set.
> Solution: introduce an attribute which caps the max length, and throws an exception (closing the connection), avoiding reading the data. If 0, the length will not be capped.
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
3 years, 9 months
[Red Hat JIRA] (JGRP-2135) OOM with JGroups 3.6.11.
by Bela Ban (Jira)
[ https://issues.redhat.com/browse/JGRP-2135?page=com.atlassian.jira.plugin... ]
Bela Ban commented on JGRP-2135:
--------------------------------
Fixed properly in https://issues.redhat.com/browse/JGRP-2523
> OOM with JGroups 3.6.11.
> ------------------------
>
> Key: JGRP-2135
> URL: https://issues.redhat.com/browse/JGRP-2135
> Project: JGroups
> Issue Type: Bug
> Affects Versions: 3.6.11
> Reporter: Zoltan Farkas
> Assignee: Bela Ban
> Priority: Major
> Fix For: 3.6.12, 3.6.20.Final
>
> Attachments: AppCluster.xml
>
>
> We are running our JVMs with : -XX:OnOutOfMemoryError="kill -9 %p"
> we have been experiencing OOMs fairly often, and the OOMs happen at:
> {code}
> Object / Stack Frame |Name | Shallow Heap | Retained Heap |Context Class Loader |Is Daemon
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> java.lang.Thread @ 0x81bdf838 |Connection.Receiver [144.77.77.53:50363 - 144.77.77.53:50363],sis-cluster.service,prodpmwsv5-6461| 120 | 456 |sun.misc.Launcher$AppClassLoader @ 0x800175a8|false
> |- at java.lang.OutOfMemoryError.<init>()V (OutOfMemoryError.java:48) | | | | |
> |- at org.jgroups.blocks.cs.TcpConnection$Receiver.run()V (TcpConnection.java:310)| | | | |
> |- at java.lang.Thread.run()V (Thread.java:745) | | | | |
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> {code}
> the Code where it happens is in TcpConnection.java:
> {code}
> while(canRun()) {
> try {
> int len=in.readInt();
> if(buffer == null || buffer.length < len)
> buffer=new byte[len];
> in.readFully(buffer, 0, len);
> updateLastAccessed();
> server.receive(peer_addr, buffer, 0, len);
> }
> catch(OutOfMemoryError mem_ex) {
> t=mem_ex;
> break; // continue;
> }
> catch(IOException io_ex) {
> t=io_ex;
> break;
> }
> catch(Throwable e) {
> }
> }
> {code}
> when allocating: buffer=new byte[len];
> it looks to me that some invalid large value is received and the process OOMs when allocating a huge byte array
> Running JVMs without kill on OOM would make this issue "dissapear" in the sense that it is swallowed by:
> {code}
> catch(OutOfMemoryError mem_ex) {
> t=mem_ex;
> break; // continue;
> }
> {code}
> Handling OutOfMemoryError is a strange implementation choice...
> instead a size limit should be employed to protect from receiving invalid sizes...
> My heap limit is 1GB and my heap dumps are 50Mb so the attempted allocation size is huge...
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
3 years, 9 months
[Red Hat JIRA] (JGRP-2523) Cap max data read by TcpConnection or NioConnection
by Bela Ban (Jira)
Bela Ban created JGRP-2523:
------------------------------
Summary: Cap max data read by TcpConnection or NioConnection
Key: JGRP-2523
URL: https://issues.redhat.com/browse/JGRP-2523
Project: JGroups
Issue Type: Feature Request
Reporter: Bela Ban
Assignee: Bela Ban
Fix For: 4.2.11, 5.1.3
Both NioConnection and TcpConnection read the length (4 bytes) first, then allocate a buffer and call InputStream.readFully().
If some random client ({{nc}}, {{curl}}, {{wget}} etc)connects accidentally, {{length}} might be huge and the memory allocation will fail with an OOME. This may even terminate the JVM, e.g. if {{-XX:+ExitOnOutOfMemoryError}} is set.
Solution: introduce an attribute which caps the max length, and throws an exception (closing the connection), avoiding reading the data. If 0, the length will not be capped.
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
3 years, 9 months
[Red Hat JIRA] (WFLY-13031) EAP quickstart 'messaging-clustering-singleton' shows errors after import
by Ranabir Chakraborty (Jira)
[ https://issues.redhat.com/browse/WFLY-13031?page=com.atlassian.jira.plugi... ]
Ranabir Chakraborty edited comment on WFLY-13031 at 1/8/21 6:43 AM:
--------------------------------------------------------------------
[~zcervink] Hello I have checked it today and it's working fine for me. Below are the screenshots.
And also from your given screenshot, it looks like you are not using the newest quickstart version. The schema location is still there inside jboss-ejb3.xml which was resolved with PR.!error-1.png|thumbnail! !error-1-1.png|thumbnail!
was (Author: rchakrab):
[~zcervink] Hello I have checked it today and it's working fine for me.
And also from your given screenshot, it looks like you are not using the newest quickstart version. The schema location is still there inside jboss-ejb3.xml which was resolved the PR itself. !error-1.png|thumbnail!!error-1-1.png|thumbnail!
> EAP quickstart 'messaging-clustering-singleton' shows errors after import
> -------------------------------------------------------------------------
>
> Key: WFLY-13031
> URL: https://issues.redhat.com/browse/WFLY-13031
> Project: WildFly
> Issue Type: Bug
> Components: Quickstarts
> Affects Versions: 18.0.1.Final
> Reporter: Zbyněk Červinka
> Assignee: Parul Sharma
> Priority: Major
> Fix For: 19.0.0.Beta2, 19.0.0.Final
>
> Attachments: Problems view.png, Project Explorer.png, error-1-1.png, error-1.png, error-2.png, error.png, jboss-ejb3.xml file.png
>
>
> h1. EAP quickstart 'messaging-clustering-singleton' shows 3 errors in the jboss-ejb3.xml file after import:
> * Referenced file contains errors (jar:file:/Applications/codereadystudio-eap-8/studio/codereadystudio.app/Contents/Eclipse/plugins/org.jboss.tools.as.catalog_3.7.0.v20190624-1620.jar!/schema/xsd/jboss-ejb-delivery-active_1_1.xsd). For more information, right click on the message in the Problems View and select "Show Details..."
> * Referenced file contains errors (jar:file:/Applications/codereadystudio-eap-8/studio/codereadystudio.app/Contents/Eclipse/plugins/org.jboss.tools.as.catalog_3.7.0.v20190624-1620.jar!/schema/xsd/jboss-ejb3-2_0.xsd). For more information, right click on the message in the Problems View and select "Show Details..."
> * Referenced file contains errors (jar:file:/Applications/codereadystudio-eap-8/studio/codereadystudio.app/Contents/Eclipse/plugins/org.jboss.tools.as.catalog_3.7.0.v20190624-1620.jar!/schema/xsd/jboss-ejb3-spec-2_0.xsd). For more information, right click on the message in the Problems View and select "Show Details..."
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
3 years, 9 months
[Red Hat JIRA] (WFLY-13031) EAP quickstart 'messaging-clustering-singleton' shows errors after import
by Ranabir Chakraborty (Jira)
[ https://issues.redhat.com/browse/WFLY-13031?page=com.atlassian.jira.plugi... ]
Ranabir Chakraborty edited comment on WFLY-13031 at 1/8/21 6:42 AM:
--------------------------------------------------------------------
[~zcervink] Hello I have checked it today and it's working fine for me.
And also from your given screenshot, it looks like you are not using the newest quickstart version. The schema location is still there inside jboss-ejb3.xml which was resolved the PR itself. !error-1.png|thumbnail!!error-1-1.png|thumbnail!
was (Author: rchakrab):
[~zcervink] Hello I have checked it today and it's working fine for me.
And also from your given screenshot, it looks like you are not using the newest quickstart version. The schema location is still there inside jboss-ejb3.xml which was resolved the PR itself.
> EAP quickstart 'messaging-clustering-singleton' shows errors after import
> -------------------------------------------------------------------------
>
> Key: WFLY-13031
> URL: https://issues.redhat.com/browse/WFLY-13031
> Project: WildFly
> Issue Type: Bug
> Components: Quickstarts
> Affects Versions: 18.0.1.Final
> Reporter: Zbyněk Červinka
> Assignee: Parul Sharma
> Priority: Major
> Fix For: 19.0.0.Beta2, 19.0.0.Final
>
> Attachments: Problems view.png, Project Explorer.png, error-1-1.png, error-1.png, error-2.png, error.png, jboss-ejb3.xml file.png
>
>
> h1. EAP quickstart 'messaging-clustering-singleton' shows 3 errors in the jboss-ejb3.xml file after import:
> * Referenced file contains errors (jar:file:/Applications/codereadystudio-eap-8/studio/codereadystudio.app/Contents/Eclipse/plugins/org.jboss.tools.as.catalog_3.7.0.v20190624-1620.jar!/schema/xsd/jboss-ejb-delivery-active_1_1.xsd). For more information, right click on the message in the Problems View and select "Show Details..."
> * Referenced file contains errors (jar:file:/Applications/codereadystudio-eap-8/studio/codereadystudio.app/Contents/Eclipse/plugins/org.jboss.tools.as.catalog_3.7.0.v20190624-1620.jar!/schema/xsd/jboss-ejb3-2_0.xsd). For more information, right click on the message in the Problems View and select "Show Details..."
> * Referenced file contains errors (jar:file:/Applications/codereadystudio-eap-8/studio/codereadystudio.app/Contents/Eclipse/plugins/org.jboss.tools.as.catalog_3.7.0.v20190624-1620.jar!/schema/xsd/jboss-ejb3-spec-2_0.xsd). For more information, right click on the message in the Problems View and select "Show Details..."
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
3 years, 9 months
[Red Hat JIRA] (WFLY-13031) EAP quickstart 'messaging-clustering-singleton' shows errors after import
by Ranabir Chakraborty (Jira)
[ https://issues.redhat.com/browse/WFLY-13031?page=com.atlassian.jira.plugi... ]
Ranabir Chakraborty updated WFLY-13031:
---------------------------------------
Attachment: (was: error-1-2.png)
> EAP quickstart 'messaging-clustering-singleton' shows errors after import
> -------------------------------------------------------------------------
>
> Key: WFLY-13031
> URL: https://issues.redhat.com/browse/WFLY-13031
> Project: WildFly
> Issue Type: Bug
> Components: Quickstarts
> Affects Versions: 18.0.1.Final
> Reporter: Zbyněk Červinka
> Assignee: Parul Sharma
> Priority: Major
> Fix For: 19.0.0.Beta2, 19.0.0.Final
>
> Attachments: Problems view.png, Project Explorer.png, error-1-1.png, error-1.png, error-2.png, error.png, jboss-ejb3.xml file.png
>
>
> h1. EAP quickstart 'messaging-clustering-singleton' shows 3 errors in the jboss-ejb3.xml file after import:
> * Referenced file contains errors (jar:file:/Applications/codereadystudio-eap-8/studio/codereadystudio.app/Contents/Eclipse/plugins/org.jboss.tools.as.catalog_3.7.0.v20190624-1620.jar!/schema/xsd/jboss-ejb-delivery-active_1_1.xsd). For more information, right click on the message in the Problems View and select "Show Details..."
> * Referenced file contains errors (jar:file:/Applications/codereadystudio-eap-8/studio/codereadystudio.app/Contents/Eclipse/plugins/org.jboss.tools.as.catalog_3.7.0.v20190624-1620.jar!/schema/xsd/jboss-ejb3-2_0.xsd). For more information, right click on the message in the Problems View and select "Show Details..."
> * Referenced file contains errors (jar:file:/Applications/codereadystudio-eap-8/studio/codereadystudio.app/Contents/Eclipse/plugins/org.jboss.tools.as.catalog_3.7.0.v20190624-1620.jar!/schema/xsd/jboss-ejb3-spec-2_0.xsd). For more information, right click on the message in the Problems View and select "Show Details..."
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
3 years, 9 months
[Red Hat JIRA] (REMJMX-174) Set up GitHub actions for CI
by Darran Lofthouse (Jira)
Darran Lofthouse created REMJMX-174:
---------------------------------------
Summary: Set up GitHub actions for CI
Key: REMJMX-174
URL: https://issues.redhat.com/browse/REMJMX-174
Project: Remoting JMX
Issue Type: Task
Components: Build
Reporter: Darran Lofthouse
Fix For: 3.0.5.Final, 3.1.0.Beta1
The actions could be copied over from WildFly Elytron as it just needs a simple "mvn clean install"
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
3 years, 9 months
[Red Hat JIRA] (WFLY-13031) EAP quickstart 'messaging-clustering-singleton' shows errors after import
by Ranabir Chakraborty (Jira)
[ https://issues.redhat.com/browse/WFLY-13031?page=com.atlassian.jira.plugi... ]
Ranabir Chakraborty edited comment on WFLY-13031 at 1/8/21 6:41 AM:
--------------------------------------------------------------------
[~zcervink] Hello I have checked it today and it's working fine for me.
And also from your given screenshot, it looks like you are not using the newest quickstart version. The schema location is still there inside jboss-ejb3.xml which was resolved the PR itself.
was (Author: rchakrab):
[~zcervink] Hello I have checked it today and it's working fine for me. Here are the screenshots.
And also from your given screenshot, it looks like you are not using the newest quickstart version. The schema location is still there inside jboss-ejb3.xml which was resolved the PR itself.
!error.png|width=114,height=183!!error-1.png|width=229,height=151!
> EAP quickstart 'messaging-clustering-singleton' shows errors after import
> -------------------------------------------------------------------------
>
> Key: WFLY-13031
> URL: https://issues.redhat.com/browse/WFLY-13031
> Project: WildFly
> Issue Type: Bug
> Components: Quickstarts
> Affects Versions: 18.0.1.Final
> Reporter: Zbyněk Červinka
> Assignee: Parul Sharma
> Priority: Major
> Fix For: 19.0.0.Beta2, 19.0.0.Final
>
> Attachments: Problems view.png, Project Explorer.png, error-1-1.png, error-1.png, error-2.png, error.png, jboss-ejb3.xml file.png
>
>
> h1. EAP quickstart 'messaging-clustering-singleton' shows 3 errors in the jboss-ejb3.xml file after import:
> * Referenced file contains errors (jar:file:/Applications/codereadystudio-eap-8/studio/codereadystudio.app/Contents/Eclipse/plugins/org.jboss.tools.as.catalog_3.7.0.v20190624-1620.jar!/schema/xsd/jboss-ejb-delivery-active_1_1.xsd). For more information, right click on the message in the Problems View and select "Show Details..."
> * Referenced file contains errors (jar:file:/Applications/codereadystudio-eap-8/studio/codereadystudio.app/Contents/Eclipse/plugins/org.jboss.tools.as.catalog_3.7.0.v20190624-1620.jar!/schema/xsd/jboss-ejb3-2_0.xsd). For more information, right click on the message in the Problems View and select "Show Details..."
> * Referenced file contains errors (jar:file:/Applications/codereadystudio-eap-8/studio/codereadystudio.app/Contents/Eclipse/plugins/org.jboss.tools.as.catalog_3.7.0.v20190624-1620.jar!/schema/xsd/jboss-ejb3-spec-2_0.xsd). For more information, right click on the message in the Problems View and select "Show Details..."
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
3 years, 9 months