[Red Hat JIRA] (DROOLS-6043) FireAllRules response time increase on date constraint-intensive rulesets with executable model
by Mario Fusco (Jira)
[ https://issues.redhat.com/browse/DROOLS-6043?page=com.atlassian.jira.plug... ]
Mario Fusco updated DROOLS-6043:
--------------------------------
Sprint: 2021 Week 07-09 (from Feb 15)
> FireAllRules response time increase on date constraint-intensive rulesets with executable model
> -----------------------------------------------------------------------------------------------
>
> Key: DROOLS-6043
> URL: https://issues.redhat.com/browse/DROOLS-6043
> Project: Drools
> Issue Type: Bug
> Components: core engine
> Affects Versions: 7.49.0.Final
> Reporter: Matteo Casalino
> Assignee: Mario Fusco
> Priority: Major
> Attachments: fg-Drools_7_49_0_drl.svg, fg-Drools_7_49_0_exec_model.svg, perf-regression-date-constraints.zip
>
>
> We notice a significant performance regression on firing rules which make intensive use of constraints on dates with executable model.
> From a quick look at the flame graphs, it looks like plenty of CPU is spent in java/time/LocalDate.parse and java/util/GregorianCalendar.from, when executable model is used.
> The attached benchmark shows a 600%+ increase of response time when running with executable model instead of drl.
> DRL:
> {noformat}
> Benchmark (inputFacts) (kieBaseName) Mode Cnt Score Error Units
> DroolsFireJMHBench.testOneFactAgainsAllRules src/main/resources/facts.json testKieBase sample 2728 18.340 ▒ 0.240 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.00 src/main/resources/facts.json testKieBase sample 14.598 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.50 src/main/resources/facts.json testKieBase sample 17.105 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.90 src/main/resources/facts.json testKieBase sample 23.170 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.95 src/main/resources/facts.json testKieBase sample 26.116 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.99 src/main/resources/facts.json testKieBase sample 32.920 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.999 src/main/resources/facts.json testKieBase sample 46.064 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.9999 src/main/resources/facts.json testKieBase sample 55.443 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p1.00 src/main/resources/facts.json testKieBase sample 55.443 ms/op
> {noformat}
> Executable model:
> {noformat}
> Benchmark (inputFacts) (kieBaseName) Mode Cnt Score Error Units
> DroolsFireJMHBench.testOneFactAgainsAllRules src/main/resources/facts.json testKieBase sample 363 138.380 ± 4.116 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.00 src/main/resources/facts.json testKieBase sample 116.523 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.50 src/main/resources/facts.json testKieBase sample 131.072 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.90 src/main/resources/facts.json testKieBase sample 160.956 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.95 src/main/resources/facts.json testKieBase sample 173.172 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.99 src/main/resources/facts.json testKieBase sample 271.602 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.999 src/main/resources/facts.json testKieBase sample 313.000 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.9999 src/main/resources/facts.json testKieBase sample 313.000 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p1.00 src/main/resources/facts.json testKieBase sample 313.000 ms/op
> {noformat}
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
3 years, 2 months
[Red Hat JIRA] (DROOLS-6042) Actual text value instead of tip
by Mario Fusco (Jira)
[ https://issues.redhat.com/browse/DROOLS-6042?page=com.atlassian.jira.plug... ]
Mario Fusco reassigned DROOLS-6042:
-----------------------------------
Assignee: Toni Rikkola (was: Mario Fusco)
> Actual text value instead of tip
> --------------------------------
>
> Key: DROOLS-6042
> URL: https://issues.redhat.com/browse/DROOLS-6042
> Project: Drools
> Issue Type: Bug
> Affects Versions: 7.50.0.Final
> Reporter: Gabriele Cardosi
> Assignee: Toni Rikkola
> Priority: Major
> Attachments: CreatedField.png, CreationField.png, ExpectedBehavior.png
>
>
> When creating a new DataType, inside the "Name" text box a String "Insert a name" is shown.
> That string is a tip, and as such should be shown, but in reality it is the actual value of that text box.
> That leads to
> 1) when editing, the user have to cancel that string before (not expected, giving the shown message)
> 2) if not edited, the name of the field remains the proposed one.
> If that proposed string should serve a s default/auto generated value, it would be better no not use a "do that" sentence.
> Attached screens.
> If a "do that" string is to be used, then it should be shown as in the "Search data type" search combo
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
3 years, 2 months
[Red Hat JIRA] (DROOLS-6043) FireAllRules response time increase on date constraint-intensive rulesets with executable model
by Matteo Casalino (Jira)
Matteo Casalino created DROOLS-6043:
---------------------------------------
Summary: FireAllRules response time increase on date constraint-intensive rulesets with executable model
Key: DROOLS-6043
URL: https://issues.redhat.com/browse/DROOLS-6043
Project: Drools
Issue Type: Bug
Components: core engine
Affects Versions: 7.49.0.Final
Reporter: Matteo Casalino
Assignee: Mario Fusco
Attachments: fg-Drools_7_49_0_drl.svg, fg-Drools_7_49_0_exec_model.svg, perf-regression-date-constraints.zip
We notice a significant performance regression on firing rules which make intensive use of constraints on dates with executable model.
From a quick look at the flame graphs, it looks like plenty of CPU is spent in java/time/LocalDate.parse and java/util/GregorianCalendar.from, when executable model is used.
The attached benchmark shows a 600%+ increase of response time when running with executable model instead of drl.
DRL:
{noformat}
Benchmark (inputFacts) (kieBaseName) Mode Cnt Score Error Units
DroolsFireJMHBench.testOneFactAgainsAllRules src/main/resources/facts.json testKieBase sample 2728 18.340 ▒ 0.240 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.00 src/main/resources/facts.json testKieBase sample 14.598 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.50 src/main/resources/facts.json testKieBase sample 17.105 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.90 src/main/resources/facts.json testKieBase sample 23.170 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.95 src/main/resources/facts.json testKieBase sample 26.116 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.99 src/main/resources/facts.json testKieBase sample 32.920 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.999 src/main/resources/facts.json testKieBase sample 46.064 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.9999 src/main/resources/facts.json testKieBase sample 55.443 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p1.00 src/main/resources/facts.json testKieBase sample 55.443 ms/op
{noformat}
Executable model:
{noformat}
Benchmark (inputFacts) (kieBaseName) Mode Cnt Score Error Units
DroolsFireJMHBench.testOneFactAgainsAllRules src/main/resources/facts.json testKieBase sample 363 138.380 ± 4.116 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.00 src/main/resources/facts.json testKieBase sample 116.523 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.50 src/main/resources/facts.json testKieBase sample 131.072 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.90 src/main/resources/facts.json testKieBase sample 160.956 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.95 src/main/resources/facts.json testKieBase sample 173.172 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.99 src/main/resources/facts.json testKieBase sample 271.602 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.999 src/main/resources/facts.json testKieBase sample 313.000 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.9999 src/main/resources/facts.json testKieBase sample 313.000 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p1.00 src/main/resources/facts.json testKieBase sample 313.000 ms/op
{noformat}
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
3 years, 2 months
[Red Hat JIRA] (DROOLS-6010) Not able to use a space within quotes in guided DecisionTable.
by Jozef Marko (Jira)
[ https://issues.redhat.com/browse/DROOLS-6010?page=com.atlassian.jira.plug... ]
Jozef Marko updated DROOLS-6010:
--------------------------------
Steps to Reproduce:
* Import attached project and open GuidedDecisionTable.
* In the Model tab we have condition as Person( id in ( "1", "2", " " ) ).
* Check the source tab, we can see rule like as:
*
{code:java}
rule "Row 1 SampleTable"
dialect "mvel"
when
person : Person( id in ( "1", "2", "" ) )
then
end{code}
space within quotes is removed.
> Not able to use a space within quotes in guided DecisionTable.
> --------------------------------------------------------------
>
> Key: DROOLS-6010
> URL: https://issues.redhat.com/browse/DROOLS-6010
> Project: Drools
> Issue Type: Bug
> Components: Guided Decision Table Editor, Guided Rule Editor, Guided Template Editor
> Reporter: Toni Rikkola
> Assignee: Toni Rikkola
> Priority: Major
> Labels: drools-tools
>
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
3 years, 2 months
[Red Hat JIRA] (WFLY-14456) Remove Java EE References from the i18n strings
by Yeray Borges Santana (Jira)
Yeray Borges Santana created WFLY-14456:
-------------------------------------------
Summary: Remove Java EE References from the i18n strings
Key: WFLY-14456
URL: https://issues.redhat.com/browse/WFLY-14456
Project: WildFly
Issue Type: Task
Components: Server
Reporter: Yeray Borges Santana
Assignee: Yeray Borges Santana
Replace Java EE References from the i18n strings. Those strings are in the various XXXLogger.java files and the LocalDescriptions.properties files.
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
3 years, 2 months
[Red Hat JIRA] (WFCORE-5292) Remove Java EE References from the i18n strings
by Darran Lofthouse (Jira)
[ https://issues.redhat.com/browse/WFCORE-5292?page=com.atlassian.jira.plug... ]
Darran Lofthouse commented on WFCORE-5292:
------------------------------------------
Before submitting PRs lets just double check with [~brian.stansberry] and [~jmesnil]. If we are going to need reviews from each component lead then IMO individual PRs make more sense, but this would be a hit to CI as each job would trigger a full CI run.
> Remove Java EE References from the i18n strings
> -----------------------------------------------
>
> Key: WFCORE-5292
> URL: https://issues.redhat.com/browse/WFCORE-5292
> Project: WildFly Core
> Issue Type: Task
> Components: Server
> Reporter: Yeray Borges Santana
> Assignee: Yeray Borges Santana
> Priority: Major
>
> Replace Java EE References from the i18n strings. Those strings are in the various XXXLogger.java files and the LocalDescriptions.properties files.
>
>
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
3 years, 2 months