[Red Hat JIRA] (WFWIP-371) NullPointerException when expression=encryption:create-expression uses resolver with invalid secret-key
by Ondrej Kotek (Jira)
[ https://issues.redhat.com/browse/WFWIP-371?page=com.atlassian.jira.plugin... ]
Ondrej Kotek updated WFWIP-371:
-------------------------------
Description:
NullPointerException when {{/subsystem=elytron/expression=encryption:create-expression}} uses resolver with invalid secret-key (no key under the given alias).
The failure at the end is OK, but it should not be {{NullPointerException}}:
{noformat}
[standalone@localhost:9990 /] /subsystem=elytron/secret-key-credential-store=credentialstorethree:read-aliases
{
"outcome" => "success",
"result" => [
"secretkey",
"key"
]
}
[standalone@localhost:9990 /] /subsystem=elytron/expression=encryption:read-resource
{
"outcome" => "success",
"result" => {
"default-resolver" => "Default",
"prefix" => "ENC",
"resolvers" => [
{
"name" => "Default",
"credential-store" => "credentialstorethree",
"secret-key" => "secretkey"
},
{
"name" => "resolver2",
"credential-store" => "credentialstorethree",
"secret-key" => "secretkey2"
}
]
}
}
[standalone@localhost:9990 /] /subsystem=elytron/expression=encryption:create-expression(clear-text=CredentialStoreTwoPassword)
{
"outcome" => "success",
"result" => {"expression" => "${ENC::RUxZAUMQ+LZYf7LtJiSPV4EqY4FEk3WK2V2i4ywGhTTu/3uRQirYtvphB2A8fmK6CSlUnYUd}"}
}
[standalone@localhost:9990 /] /subsystem=elytron/expression=encryption:create-expression(clear-text=CredentialStoreTwoPassword,resolver=resolver2)
{
"outcome" => "failed",
"failure-description" => "WFLYCTL0158: Operation handler failed: java.lang.NullPointerException",
"rolled-back" => true
}
{noformat}
{noformat}
08:52:49,669 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 1) WFLYCTL0013: Operation ("create-expression") failed - address: ([
("subsystem" => "elytron"),
("expression" => "encryption")
]): java.lang.NullPointerException
at org.wildfly.extension.elytron@15.0.0.Beta1-SNAPSHOT//org.wildfly.extension.elytron.expression.ElytronExpressionResolver.createExpression(ElytronExpressionResolver.java:139)
at org.wildfly.extension.elytron@15.0.0.Beta1-SNAPSHOT//org.wildfly.extension.elytron.ExpressionResolverResourceDefinition$CreateExpressionHandler.executeRuntimeStep(ExpressionResolverResourceDefinition.java:217)
at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.AbstractRuntimeOnlyHandler$1.execute(AbstractRuntimeOnlyHandler.java:59)
at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.AbstractOperationContext.executeStep(AbstractOperationContext.java:1040)
at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.AbstractOperationContext.processStages(AbstractOperationContext.java:779)
at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.AbstractOperationContext.executeOperation(AbstractOperationContext.java:468)
at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.OperationContextImpl.executeOperation(OperationContextImpl.java:1415)
at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.ModelControllerImpl.internalExecute(ModelControllerImpl.java:431)
at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.ModelControllerImpl.lambda$execute$1(ModelControllerImpl.java:248)
at org.wildfly.security.elytron-private@1.14.3.CR1-SNAPSHOT//org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:304)
at org.wildfly.security.elytron-private@1.14.3.CR1-SNAPSHOT//org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:270)
at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.ModelControllerImpl.execute(ModelControllerImpl.java:248)
at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler.doExecute(ModelControllerClientOperationHandler.java:240)
at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler.access$400(ModelControllerClientOperationHandler.java:138)
at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler$1$1.run(ModelControllerClientOperationHandler.java:162)
at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler$1$1.run(ModelControllerClientOperationHandler.java:158)
at org.wildfly.security.elytron-private@1.14.3.CR1-SNAPSHOT//org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:328)
at org.wildfly.security.elytron-private@1.14.3.CR1-SNAPSHOT//org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:285)
at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.AccessAuditContext.doAs(AccessAuditContext.java:254)
at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.AccessAuditContext.doAs(AccessAuditContext.java:225)
at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler$1.execute(ModelControllerClientOperationHandler.java:158)
at org.jboss.as.protocol@15.0.0.Beta1-SNAPSHOT//org.jboss.as.protocol.mgmt.ManagementRequestContextImpl$1.doExecute(ManagementRequestContextImpl.java:70)
at org.jboss.as.protocol@15.0.0.Beta1-SNAPSHOT//org.jboss.as.protocol.mgmt.ManagementRequestContextImpl$AsyncTaskRunner.run(ManagementRequestContextImpl.java:160)
at org.jboss.threads@2.4.0.Final//org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35)
at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1990)
at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1486)
at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1377)
at java.base/java.lang.Thread.run(Thread.java:834)
at org.jboss.threads@2.4.0.Final//org.jboss.threads.JBossThread.run(JBossThread.java:513)
{noformat}
was:
NullPointerException when {{/subsystem=elytron/expression=encryption:create-expression}} uses resolver with invalid secret-key (no key under the given alias).
The failure at the end is OK, but it should not be {{NullPointerException}}:
{noformat}
[standalone@localhost:9990 /] /subsystem=elytron/secret-key-credential-store=credentialstorethree:read-aliases
{
"outcome" => "success",
"result" => [
"secretkey",
"key"
]
}
[standalone@localhost:9990 /] /subsystem=elytron/expression=encryption:read-resource
{
"outcome" => "success",
"result" => {
"default-resolver" => "Default",
"prefix" => "ENC",
"resolvers" => [
{
"name" => "Default",
"credential-store" => "credentialstorethree",
"secret-key" => "secretkey"
},
{
"name" => "resolver2",
"credential-store" => "credentialstorethree",
"secret-key" => "secretkey2"
}
]
}
}
[standalone@localhost:9990 /] /subsystem=elytron/expression=encryption:create-expression(clear-text=CredentialStoreTwoPassword)
{
"outcome" => "success",
"result" => {"expression" => "${ENC::RUxZAUMQ+LZYf7LtJiSPV4EqY4FEk3WK2V2i4ywGhTTu/3uRQirYtvphB2A8fmK6CSlUnYUd}"}
}
[standalone@localhost:9990 /] /subsystem=elytron/expression=encryption:create-expression(clear-text=CredentialStoreTwoPassword,resolver=resolver2)
{
"outcome" => "failed",
"failure-description" => "WFLYCTL0158: Operation handler failed: java.lang.NullPointerException",
"rolled-back" => true
}
{noformat}
> NullPointerException when expression=encryption:create-expression uses resolver with invalid secret-key
> -------------------------------------------------------------------------------------------------------
>
> Key: WFWIP-371
> URL: https://issues.redhat.com/browse/WFWIP-371
> Project: WildFly WIP
> Issue Type: Bug
> Components: Security
> Reporter: Ondrej Kotek
> Assignee: Darran Lofthouse
> Priority: Major
>
> NullPointerException when {{/subsystem=elytron/expression=encryption:create-expression}} uses resolver with invalid secret-key (no key under the given alias).
> The failure at the end is OK, but it should not be {{NullPointerException}}:
> {noformat}
> [standalone@localhost:9990 /] /subsystem=elytron/secret-key-credential-store=credentialstorethree:read-aliases
> {
> "outcome" => "success",
> "result" => [
> "secretkey",
> "key"
> ]
> }
> [standalone@localhost:9990 /] /subsystem=elytron/expression=encryption:read-resource
> {
> "outcome" => "success",
> "result" => {
> "default-resolver" => "Default",
> "prefix" => "ENC",
> "resolvers" => [
> {
> "name" => "Default",
> "credential-store" => "credentialstorethree",
> "secret-key" => "secretkey"
> },
> {
> "name" => "resolver2",
> "credential-store" => "credentialstorethree",
> "secret-key" => "secretkey2"
> }
> ]
> }
> }
> [standalone@localhost:9990 /] /subsystem=elytron/expression=encryption:create-expression(clear-text=CredentialStoreTwoPassword)
> {
> "outcome" => "success",
> "result" => {"expression" => "${ENC::RUxZAUMQ+LZYf7LtJiSPV4EqY4FEk3WK2V2i4ywGhTTu/3uRQirYtvphB2A8fmK6CSlUnYUd}"}
> }
> [standalone@localhost:9990 /] /subsystem=elytron/expression=encryption:create-expression(clear-text=CredentialStoreTwoPassword,resolver=resolver2)
> {
> "outcome" => "failed",
> "failure-description" => "WFLYCTL0158: Operation handler failed: java.lang.NullPointerException",
> "rolled-back" => true
> }
> {noformat}
> {noformat}
> 08:52:49,669 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 1) WFLYCTL0013: Operation ("create-expression") failed - address: ([
> ("subsystem" => "elytron"),
> ("expression" => "encryption")
> ]): java.lang.NullPointerException
> at org.wildfly.extension.elytron@15.0.0.Beta1-SNAPSHOT//org.wildfly.extension.elytron.expression.ElytronExpressionResolver.createExpression(ElytronExpressionResolver.java:139)
> at org.wildfly.extension.elytron@15.0.0.Beta1-SNAPSHOT//org.wildfly.extension.elytron.ExpressionResolverResourceDefinition$CreateExpressionHandler.executeRuntimeStep(ExpressionResolverResourceDefinition.java:217)
> at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.AbstractRuntimeOnlyHandler$1.execute(AbstractRuntimeOnlyHandler.java:59)
> at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.AbstractOperationContext.executeStep(AbstractOperationContext.java:1040)
> at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.AbstractOperationContext.processStages(AbstractOperationContext.java:779)
> at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.AbstractOperationContext.executeOperation(AbstractOperationContext.java:468)
> at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.OperationContextImpl.executeOperation(OperationContextImpl.java:1415)
> at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.ModelControllerImpl.internalExecute(ModelControllerImpl.java:431)
> at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.ModelControllerImpl.lambda$execute$1(ModelControllerImpl.java:248)
> at org.wildfly.security.elytron-private@1.14.3.CR1-SNAPSHOT//org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:304)
> at org.wildfly.security.elytron-private@1.14.3.CR1-SNAPSHOT//org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:270)
> at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.ModelControllerImpl.execute(ModelControllerImpl.java:248)
> at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler.doExecute(ModelControllerClientOperationHandler.java:240)
> at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler.access$400(ModelControllerClientOperationHandler.java:138)
> at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler$1$1.run(ModelControllerClientOperationHandler.java:162)
> at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler$1$1.run(ModelControllerClientOperationHandler.java:158)
> at org.wildfly.security.elytron-private@1.14.3.CR1-SNAPSHOT//org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:328)
> at org.wildfly.security.elytron-private@1.14.3.CR1-SNAPSHOT//org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:285)
> at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.AccessAuditContext.doAs(AccessAuditContext.java:254)
> at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.AccessAuditContext.doAs(AccessAuditContext.java:225)
> at org.jboss.as.controller@15.0.0.Beta1-SNAPSHOT//org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler$1.execute(ModelControllerClientOperationHandler.java:158)
> at org.jboss.as.protocol@15.0.0.Beta1-SNAPSHOT//org.jboss.as.protocol.mgmt.ManagementRequestContextImpl$1.doExecute(ManagementRequestContextImpl.java:70)
> at org.jboss.as.protocol@15.0.0.Beta1-SNAPSHOT//org.jboss.as.protocol.mgmt.ManagementRequestContextImpl$AsyncTaskRunner.run(ManagementRequestContextImpl.java:160)
> at org.jboss.threads@2.4.0.Final//org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35)
> at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1990)
> at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1486)
> at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1377)
> at java.base/java.lang.Thread.run(Thread.java:834)
> at org.jboss.threads@2.4.0.Final//org.jboss.threads.JBossThread.run(JBossThread.java:513)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
5 years, 1 month
[Red Hat JIRA] (WFWIP-371) NullPointerException when expression=encryption:create-expression uses resolver with invalid secret-key
by Ondrej Kotek (Jira)
Ondrej Kotek created WFWIP-371:
----------------------------------
Summary: NullPointerException when expression=encryption:create-expression uses resolver with invalid secret-key
Key: WFWIP-371
URL: https://issues.redhat.com/browse/WFWIP-371
Project: WildFly WIP
Issue Type: Bug
Components: Security
Reporter: Ondrej Kotek
Assignee: Darran Lofthouse
NullPointerException when {{/subsystem=elytron/expression=encryption:create-expression}} uses resolver with invalid secret-key (no key under the given alias).
The failure at the end is OK, but it should not be {{NullPointerException}}:
{noformat}
[standalone@localhost:9990 /] /subsystem=elytron/secret-key-credential-store=credentialstorethree:read-aliases
{
"outcome" => "success",
"result" => [
"secretkey",
"key"
]
}
[standalone@localhost:9990 /] /subsystem=elytron/expression=encryption:read-resource
{
"outcome" => "success",
"result" => {
"default-resolver" => "Default",
"prefix" => "ENC",
"resolvers" => [
{
"name" => "Default",
"credential-store" => "credentialstorethree",
"secret-key" => "secretkey"
},
{
"name" => "resolver2",
"credential-store" => "credentialstorethree",
"secret-key" => "secretkey2"
}
]
}
}
[standalone@localhost:9990 /] /subsystem=elytron/expression=encryption:create-expression(clear-text=CredentialStoreTwoPassword)
{
"outcome" => "success",
"result" => {"expression" => "${ENC::RUxZAUMQ+LZYf7LtJiSPV4EqY4FEk3WK2V2i4ywGhTTu/3uRQirYtvphB2A8fmK6CSlUnYUd}"}
}
[standalone@localhost:9990 /] /subsystem=elytron/expression=encryption:create-expression(clear-text=CredentialStoreTwoPassword,resolver=resolver2)
{
"outcome" => "failed",
"failure-description" => "WFLYCTL0158: Operation handler failed: java.lang.NullPointerException",
"rolled-back" => true
}
{noformat}
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
5 years, 1 month
[Red Hat JIRA] (WFCORE-5292) Remove Java EE References from the i18n strings
by Ranabir Chakraborty (Jira)
[ https://issues.redhat.com/browse/WFCORE-5292?page=com.atlassian.jira.plug... ]
Ranabir Chakraborty commented on WFCORE-5292:
---------------------------------------------
[~dlofthouse] There are not many possible changes in WFLY-CORE for XXXLogger.java files and the LocalDescriptions.properties files. I guess putting that in one PR is good.
> Remove Java EE References from the i18n strings
> -----------------------------------------------
>
> Key: WFCORE-5292
> URL: https://issues.redhat.com/browse/WFCORE-5292
> Project: WildFly Core
> Issue Type: Task
> Components: Server
> Reporter: Yeray Borges Santana
> Assignee: Yeray Borges Santana
> Priority: Major
>
> Replace Java EE References from the i18n strings. Those strings are in the various XXXLogger.java files and the LocalDescriptions.properties files.
>
>
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
5 years, 1 month
[Red Hat JIRA] (DROOLS-6043) FireAllRules response time increase on date constraint-intensive rulesets with executable model
by Mario Fusco (Jira)
[ https://issues.redhat.com/browse/DROOLS-6043?page=com.atlassian.jira.plug... ]
Mario Fusco updated DROOLS-6043:
--------------------------------
Sprint: 2021 Week 07-09 (from Feb 15)
> FireAllRules response time increase on date constraint-intensive rulesets with executable model
> -----------------------------------------------------------------------------------------------
>
> Key: DROOLS-6043
> URL: https://issues.redhat.com/browse/DROOLS-6043
> Project: Drools
> Issue Type: Bug
> Components: core engine
> Affects Versions: 7.49.0.Final
> Reporter: Matteo Casalino
> Assignee: Mario Fusco
> Priority: Major
> Attachments: fg-Drools_7_49_0_drl.svg, fg-Drools_7_49_0_exec_model.svg, perf-regression-date-constraints.zip
>
>
> We notice a significant performance regression on firing rules which make intensive use of constraints on dates with executable model.
> From a quick look at the flame graphs, it looks like plenty of CPU is spent in java/time/LocalDate.parse and java/util/GregorianCalendar.from, when executable model is used.
> The attached benchmark shows a 600%+ increase of response time when running with executable model instead of drl.
> DRL:
> {noformat}
> Benchmark (inputFacts) (kieBaseName) Mode Cnt Score Error Units
> DroolsFireJMHBench.testOneFactAgainsAllRules src/main/resources/facts.json testKieBase sample 2728 18.340 ▒ 0.240 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.00 src/main/resources/facts.json testKieBase sample 14.598 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.50 src/main/resources/facts.json testKieBase sample 17.105 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.90 src/main/resources/facts.json testKieBase sample 23.170 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.95 src/main/resources/facts.json testKieBase sample 26.116 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.99 src/main/resources/facts.json testKieBase sample 32.920 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.999 src/main/resources/facts.json testKieBase sample 46.064 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.9999 src/main/resources/facts.json testKieBase sample 55.443 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p1.00 src/main/resources/facts.json testKieBase sample 55.443 ms/op
> {noformat}
> Executable model:
> {noformat}
> Benchmark (inputFacts) (kieBaseName) Mode Cnt Score Error Units
> DroolsFireJMHBench.testOneFactAgainsAllRules src/main/resources/facts.json testKieBase sample 363 138.380 ± 4.116 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.00 src/main/resources/facts.json testKieBase sample 116.523 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.50 src/main/resources/facts.json testKieBase sample 131.072 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.90 src/main/resources/facts.json testKieBase sample 160.956 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.95 src/main/resources/facts.json testKieBase sample 173.172 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.99 src/main/resources/facts.json testKieBase sample 271.602 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.999 src/main/resources/facts.json testKieBase sample 313.000 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.9999 src/main/resources/facts.json testKieBase sample 313.000 ms/op
> DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p1.00 src/main/resources/facts.json testKieBase sample 313.000 ms/op
> {noformat}
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
5 years, 1 month
[Red Hat JIRA] (DROOLS-6042) Actual text value instead of tip
by Mario Fusco (Jira)
[ https://issues.redhat.com/browse/DROOLS-6042?page=com.atlassian.jira.plug... ]
Mario Fusco reassigned DROOLS-6042:
-----------------------------------
Assignee: Toni Rikkola (was: Mario Fusco)
> Actual text value instead of tip
> --------------------------------
>
> Key: DROOLS-6042
> URL: https://issues.redhat.com/browse/DROOLS-6042
> Project: Drools
> Issue Type: Bug
> Affects Versions: 7.50.0.Final
> Reporter: Gabriele Cardosi
> Assignee: Toni Rikkola
> Priority: Major
> Attachments: CreatedField.png, CreationField.png, ExpectedBehavior.png
>
>
> When creating a new DataType, inside the "Name" text box a String "Insert a name" is shown.
> That string is a tip, and as such should be shown, but in reality it is the actual value of that text box.
> That leads to
> 1) when editing, the user have to cancel that string before (not expected, giving the shown message)
> 2) if not edited, the name of the field remains the proposed one.
> If that proposed string should serve a s default/auto generated value, it would be better no not use a "do that" sentence.
> Attached screens.
> If a "do that" string is to be used, then it should be shown as in the "Search data type" search combo
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
5 years, 1 month
[Red Hat JIRA] (DROOLS-6043) FireAllRules response time increase on date constraint-intensive rulesets with executable model
by Matteo Casalino (Jira)
Matteo Casalino created DROOLS-6043:
---------------------------------------
Summary: FireAllRules response time increase on date constraint-intensive rulesets with executable model
Key: DROOLS-6043
URL: https://issues.redhat.com/browse/DROOLS-6043
Project: Drools
Issue Type: Bug
Components: core engine
Affects Versions: 7.49.0.Final
Reporter: Matteo Casalino
Assignee: Mario Fusco
Attachments: fg-Drools_7_49_0_drl.svg, fg-Drools_7_49_0_exec_model.svg, perf-regression-date-constraints.zip
We notice a significant performance regression on firing rules which make intensive use of constraints on dates with executable model.
From a quick look at the flame graphs, it looks like plenty of CPU is spent in java/time/LocalDate.parse and java/util/GregorianCalendar.from, when executable model is used.
The attached benchmark shows a 600%+ increase of response time when running with executable model instead of drl.
DRL:
{noformat}
Benchmark (inputFacts) (kieBaseName) Mode Cnt Score Error Units
DroolsFireJMHBench.testOneFactAgainsAllRules src/main/resources/facts.json testKieBase sample 2728 18.340 ▒ 0.240 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.00 src/main/resources/facts.json testKieBase sample 14.598 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.50 src/main/resources/facts.json testKieBase sample 17.105 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.90 src/main/resources/facts.json testKieBase sample 23.170 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.95 src/main/resources/facts.json testKieBase sample 26.116 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.99 src/main/resources/facts.json testKieBase sample 32.920 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.999 src/main/resources/facts.json testKieBase sample 46.064 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p0.9999 src/main/resources/facts.json testKieBase sample 55.443 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules▒p1.00 src/main/resources/facts.json testKieBase sample 55.443 ms/op
{noformat}
Executable model:
{noformat}
Benchmark (inputFacts) (kieBaseName) Mode Cnt Score Error Units
DroolsFireJMHBench.testOneFactAgainsAllRules src/main/resources/facts.json testKieBase sample 363 138.380 ± 4.116 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.00 src/main/resources/facts.json testKieBase sample 116.523 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.50 src/main/resources/facts.json testKieBase sample 131.072 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.90 src/main/resources/facts.json testKieBase sample 160.956 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.95 src/main/resources/facts.json testKieBase sample 173.172 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.99 src/main/resources/facts.json testKieBase sample 271.602 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.999 src/main/resources/facts.json testKieBase sample 313.000 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p0.9999 src/main/resources/facts.json testKieBase sample 313.000 ms/op
DroolsFireJMHBench.testOneFactAgainsAllRules:testOneFactAgainsAllRules·p1.00 src/main/resources/facts.json testKieBase sample 313.000 ms/op
{noformat}
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
5 years, 1 month