[jboss-jira] [JBoss JIRA] Closed: (JBRULES-2096) AbstractRuleBase.removeRule(String, String) does not release the lock when failing removing rule from the package

[ https://jira.jboss.org/browse/JBRULES-2096?page=com.atlassian.jira.plugin... ] Mark Proctor closed JBRULES-2096. --------------------------------- Assignee: Mark Proctor (was: Edson Tirelli) Resolution: Out of Date I checked the code, the finally does call unlock, so I think this is ok now: {code} public void removeRule(final String packageName, final String ruleName) { try { lock(); final Package pkg = this.pkgs.get( packageName ); if ( pkg == null ) { throw new IllegalArgumentException( "Package name '" + packageName + "' does not exist for this Rule Base." ); } final Rule rule = pkg.getRule( ruleName ); if ( rule == null ) { throw new IllegalArgumentException( "Rule name '" + ruleName + "' does not exist in the Package '" + packageName + "'." ); } this.removalsSinceLock++; removeRule( pkg, rule ); pkg.removeRule( rule ); if ( this.reloadPackageCompilationData == null ) { this.reloadPackageCompilationData = new ReloadPackageCompilationData(); } this.reloadPackageCompilationData.addDialectDatas( pkg.getDialectRuntimeRegistry() ); } finally { unlock(); } } {code} -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira