[jboss-jira] [JBoss JIRA] Closed: (JBMESSAGING-1090) Add appropriate Exception handling when hitting MaxSize

Add appropriate Exception handling when hitting MaxSize ------------------------------------------------------- Key: JBMESSAGING-1090 URL: https://jira.jboss.org/jira/browse/JBMESSAGING-1090 Project: JBoss Messaging Issue Type: Feature Request Components: Messaging Core Affects Versions: 1.4.0.GA Reporter: Jay Howell Assignee: Tim Fox Priority: Minor Fix For: 2.0.0 Beta When using MaxSize for a queue and topic the following behaviors exist Queue - When a queue hits MaxSize, the delivery returned in Channel Support is null. This triggers a very generic JMSException to be thrown by looking at the delivery and seeing if it's null in the ServerConnectionEndpoint. Topic - When a subscription hits the MaxSize(defined in the topic), the delivery returned will be null, but no check is done and no JMSException is thrown in the ServerConnectionEndpoint. What this means is that anyone who wants to put hooks in to gather the messages dropped can't. Either because the exception is too generic or because one is not thrown at all. I would purpose that we put proper exception handling down in the ChannelSupport where MaxSize is checked for both queues and subscriptions. We would need to Change the The two methods in channel support for send and sendInternal to throw a JMSException. Then we throw a checked Exception in ChannelSupport for MaxSize violations(make a new exception derived from MessagingJMSException). Adding proper exception handling to these would allow users to add aspects and notifications when messages are dropped due to MaxSize.