[
https://issues.redhat.com/browse/WFLY-13774?page=com.atlassian.jira.plugi...
]
Emmanuel Hugonnet edited comment on WFLY-13774 at 9/2/20 1:04 PM:
------------------------------------------------------------------
Using env variables the testsuite passes:
export JAEGER_SAMPLER_TYPE=const
export JAEGER_SAMPLER_PARAM=1.0
This was done to be 'consistent' with previous configuration which was relying on
environment variables to configure opentracing.
was (Author: ehugonnet):
Using env variables the testsuite passes:
export JAEGER_SAMPLER_TYPE=const
export JAEGER_SAMPLER_PARAM=1.0
This was done to be 'consisten' with previous configuration which was relying on
environment variables to configure opentracing.
Difference in OpenTracing subsystem standard configuration leads to
the tests failures
---------------------------------------------------------------------------------------
Key: WFLY-13774
URL:
https://issues.redhat.com/browse/WFLY-13774
Project: WildFly
Issue Type: Bug
Components: Build System, MP OpenTracing
Reporter: Sultan Zhantemirov
Assignee: Emmanuel Hugonnet
Priority: Major
Since OpenTracing has been introduced, `standalone.xml` had the following OT SmallRye
subsystem configuration:
{noformat}
<subsystem xmlns="urn:wildfly:microprofile-opentracing-smallrye:2.0"
default-tracer="jaeger">
<jaeger-tracer name="jaeger">
<sampler-configuration sampler-type="const"
sampler-param="1.0"/>
</jaeger-tracer>
</subsystem>
{noformat}
With WildFly 19 and later we also have `standalone-microprofile.xml` configuration file
which is used by default in MicroProfile test suite [1]. It has the following
configuration:
{noformat}
<subsystem xmlns="urn:wildfly:microprofile-opentracing-smallrye:2.0"/>
{noformat}
As it is recommended in documentation [2] it's better to define missing Jaeger
properties (_sampler type _and _sampler param_) in order to sample every request. Sampling
every request is needed by MicroProfile test suite OpenTracing basic tests.
A question is: will `standalone-microprofile.xml` configuration file have the wider OT
subsystem configuration? Or do the tests have to define additional attributes in subsystem
by themselves?
Thank you.
[1] -
https://github.com/jboss-eap-qe/eap-microprofile-test-suite#target-distri...
[2] -
https://access.redhat.com/documentation/en-us/red_hat_jboss_enterprise_ap...
--
This message was sent by Atlassian Jira
(v7.13.8#713008)