[
https://issues.jboss.org/browse/JGRP-1193?page=com.atlassian.jira.plugin....
]
Bela Ban commented on JGRP-1193:
--------------------------------
Not sure I like the enum. This is a 2x2 permutation and enums are not the best way to
solve this IMO. Actually, I'm sure now that I *don't* like the enum :-)
I'd be more inclined to like a RspFilterResult containing 2 booleans (acceptable and
need_more).
OTOH, I do like the existing interface. Brian's issue comes from not synchronizing
access to isAcceptable() and needsMoreResponses(). If I call both methods inside the same
lock, we should be fine and no code changes would be required...
Simplify RspFilter interface
----------------------------
Key: JGRP-1193
URL:
https://issues.jboss.org/browse/JGRP-1193
Project: JGroups
Issue Type: Task
Affects Versions: 2.7, 2.8, 2.9
Reporter: Vladimir Blagojevic
Assignee: Vladimir Blagojevic
Fix For: 3.0
RspFilter interface although having only two methods in its contract has been a source of
some confusion regarding the semantics of response filtering. In order to simplify and
make response filtering semantics easier to understand and implement a new RspFilter has
been proposed for 3.0.
RspFilterResult responseReceived(Object response, Address sender);
RspFilterResult is an enum with four states where each state is essentially a combination
of two boolean variables: validResponse and needMoreResponses.
Original discussion reference:
http://sourceforge.net/mailarchive/forum.php?thread_name=4BC8943F.2000101...
--
This message is automatically generated by JIRA.
For more information on JIRA, see:
http://www.atlassian.com/software/jira