[jboss-jira] [JBoss JIRA] (JGRP-1989) Bundlers: reuse send buffer when transport == sync.

[ https://issues.jboss.org/browse/JGRP-1989?page=com.atlassian.jira.plugin.... ] Bela Ban edited comment on JGRP-1989 at 12/3/15 4:51 AM: --------------------------------------------------------- Another alternative is to always send the reusable buffer and copy at the {{TCP_NIO2}} level *if needed*. For example, if a write of 1000 bytes succeeds, then we know that 1000 bytes have been written and the buffer can get reused. If the write returns rc=800, then we know that we still need to write the final 200 bytes. In this case, we could *copy* the bytes in range {{buf[801..1000]}}. I assume that a TCP write would succeed in most cases, so this would not do a lot of copying. Downside: an NIO write is done deep inside JGroups NIO ({{NioConnection}}), so we'd have to let this class somehow know whether or not to copy data. For instance, if a user always provides copied data in the first place, there'd be no need o copy at all. was (Author: belaban): Another alternative is to always send the reusable buffer and copy at the {{TCP_NIO2}} level *if needed*. For example, if a write of 1000 bytes succeeds than we know that 1000 bytes have been written and the buffer can get reused. If the write returns rc=800, then we know that we still need to write the final 200 bytes. In this case, we could *copy* the bytes in range {{buf[801..1000]}}. I assume that a TCP write would succeed in most cases, so this would not do a lot of copying. Downside: an NIO write is done deep inside JGroups NIO ({{NioConnection}}), so we'd have to let this class somehow know whether or not to copy data. For instance, if a user always provides copied data in the first place, there'd be no need o copy at all. -- This message was sent by Atlassian JIRA (v6.4.11#64026)