[jboss-jira] [JBoss JIRA] (WFLY-8456) Protocols added to a fork of some channel won't show in JMX MBeans

[ https://issues.jboss.org/browse/WFLY-8456?page=com.atlassian.jira.plugin.... ] Paul Ferraro commented on WFLY-8456: ------------------------------------ I would suggest moving the mbean registration logic from ChannelBuilder to the ChannelFactory implementations themselves. This eliminates the need for special handling for externally created channels. Something like: {code:java} public MyChannelFactory implements ChannelFactoy, ChannelListener { @Override public Channel createChannel(String id) { Channel channel = // create channel JmxConfigurator.registerChannel(channel, ...); channel.addListener(this); return channel; } @Override public void channelClosed(Channel channel) { JmxConfigurator.unregisterChannel(channel, ...); channel.removeListener(this); } } {code} -- This message was sent by Atlassian JIRA (v7.2.3#72005)