[
https://issues.jboss.org/browse/JBLOGGING-52?page=com.atlassian.jira.plug...
]
Dan Allen commented on JBLOGGING-52:
------------------------------------
After giving it more thought, I absolutely support your position. The proxy feature was
really a temporary solution until the tooling was ready. Now it is. The generated classes
are so much more reliable and fool-proof, permitted the developer is given the information
to set up the tooling.
I've removed references to the proxy setting from the reference documentation. Can we
convert this issue into "remove the proxy generation?"
(Btw. If we decide to do the proxy generation in the future, I realized that it would be
more appropriated for us to do it in Solder anyhow, as it's more of
developer-oriented, programming model related issue.)
Use of system property for proxy generation setting is too
inflexible
---------------------------------------------------------------------
Key: JBLOGGING-52
URL:
https://issues.jboss.org/browse/JBLOGGING-52
Project: JBoss Logging
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: jboss-logging-spi
Affects Versions: 3.0.0.Beta4-jboss-logging
Reporter: Dan Allen
Assignee: Dan Allen
Fix For: 3.0.0.Beta5-jboss-logging
JBoss Logging uses a system property to configure whether or not proxies are generated
for type-safe loggers. This approach is very inflexible.
The main issue is that the value of this system property is being cached too
aggressively. In CDI extensions, we are forced to use a static code block to set the
property so it is assigned early enough that JBoss Logging caches the correct value.
However, with multiple extensions loading in a non-deterministic order, we end up having
to put this static block in multiple places. [1]
We need a better way to apply this setting. Perhaps a static method on a configuration
API to assign the value before any logging takes place.
[1]
https://github.com/seam/solder/blob/master/impl/src/main/java/org/jboss/s...
https://github.com/seam/servlet/blob/master/impl/src/main/java/org/jboss/...
--
This message is automatically generated by JIRA.
For more information on JIRA, see:
http://www.atlassian.com/software/jira