[jboss-jira] [JBoss JIRA] Updated: (JBAS-5074) MarshalledInvocation constructor should copy over all invocation attributes

MarshalledInvocation constructor should copy over all invocation attributes --------------------------------------------------------------------------- Key: JBAS-5074 URL: http://jira.jboss.com/jira/browse/JBAS-5074 Project: JBoss Application Server Issue Type: Bug Security Level: Public(Everyone can see) Components: EJB2 Affects Versions: JBossAS-5.0.0.Beta2 Reporter: Galder Zamarreno Assigned To: Galder Zamarreno trunk and 4.2.x differ slightly when it comes to org.jboss.invocation.MarshalledInvocation class. in 4.2.x, MarshalledInvocation(Invocation invocation) constructor does: ... this.transient_payload = invocation.transient_payload; this.invocationContext = invocation.invocationContext; ... whereas in trunk, the transient payload is not copied over to the MarshalledInvocation. The discrepancy comes from: http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas/branches/Branch_4_2/se... as part of: "JBAS-2436 - Commiting Pluggable Serialization into JBAS 4.0" (http://jira.jboss.com/jira/browse/JBAS-2436) Brian: "The values should be copied. Without them the Invocation API contract cannot be properly met (e.g. Invocation.getInvocationContext(), Invocation.getTransientValue()). Maybe those methods are never called (except, I guess, now they are called in your tests ;)) but they are part of the API and properly supporting the API is worth the cost of a couple of assignment operations."