[jboss-jira] [JBoss JIRA] (WFCORE-488) Failures of undeploy of a partially failed deployment
[
https://issues.jboss.org/browse/WFCORE-488?page=com.atlassian.jira.plugin...
]
Arcadiy Ivanov commented on WFCORE-488:
---------------------------------------
I am sitting right now inside
{{DeploymentRemoveHandler$1$1.handleResult(OperationContext$ResultAction,
OperationContext, ModelNode) line: 80}}
{noformat}
context.completeStep(new OperationContext.ResultHandler() {
@Override
public void handleResult(ResultAction resultAction, OperationContext
context, ModelNode operation) {
if (resultAction != ResultAction.ROLLBACK) {
removeContent(name, deploymentHashes);
}
}
});
{noformat}
and introspecting {{operation}} or {{context}} I cannot find any failure information
except for {{resultAction}} being {{ROLLBACK}}.
So I would say the failure information is not getting to the DC altogether, rather than a
simply CLI.
{{context.activeStep.outcome}} is undefined for all ModelNodes recursively.
Failures of undeploy of a partially failed deployment
-----------------------------------------------------
Key: WFCORE-488
URL: https://issues.jboss.org/browse/WFCORE-488
Project: WildFly Core
Issue Type: Bug
Components: CLI, Domain Management
Reporter: Arcadiy Ivanov
Assignee: Alexey Loubyansky
{noformat}
[domain@localhost:9990 /] undeploy 2e3b75f2-88ff-4eb9-a8b1-9107c452309e.ear
--all-relevant-server-groups
Undeploy failed: JBAS010839: Operation failed or was rolled back on all servers.
{noformat}
There are several issues at play here:
# Insufficient information is displayed along with JBAS010839
# No actual failure logged either in DC or in individual host's logs
# Failure to find a deployment unit on a particular host should not result in a failure
of a domain-wide undeploy in DeploymentUndeployHandler
I'll start in a reverse order of causation:
In DeploymentUndeployHandler.execute
{noformat}
public void execute(OperationContext context, ModelNode operation) throws
OperationFailedException {
ModelNode model =
context.readResourceForUpdate(PathAddress.EMPTY_ADDRESS).getModel();
...
{noformat}
OperationContextImpl.readResourceForUpdate calls OperationContextImpl.requireChild:
{noformat}
private static Resource requireChild(final Resource resource, final PathElement
childPath, final PathAddress fullAddress) {
if (resource.hasChild(childPath)) {
return resource.requireChild(childPath);
} else {
PathAddress missing = PathAddress.EMPTY_ADDRESS;
for (PathElement search : fullAddress) {
missing = missing.append(search);
if (search.equals(childPath)) {
break;
}
}
throw ControllerMessages.MESSAGES.managementResourceNotFound(missing);
}
}
{noformat}
The exception generated by {{throw
ControllerMessages.MESSAGES.managementResourceNotFound(missing);}}:
# does not propagate from the host to DC and to CLI
# is not logged with any level (not even TRACE) either on host or DC
# should be handled within DeploymentUndeployHandler not to fail the undeploy operation
in case of a partially failed deployment (e.g. EAR with unsatisfied CDI dependencies).
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)