[jboss-jira] [JBoss JIRA] (JGRP-1961) TCP_NIO2: message bundling can lead to corruption of msgs sent asynchronously

[ https://issues.jboss.org/browse/JGRP-1961?page=com.atlassian.jira.plugin.... ] Bela Ban edited comment on JGRP-1961 at 12/7/15 10:34 AM: ---------------------------------------------------------- For non-bundled messages, we create a new buffer for every message: those buffers are not reused. In contrast, message bundlers create a buffer (initial size: 1024 bytes) which is always reused and thus potentially increases. Perhaps we need to abandon this and create a new buffer in bundlers for every message, too, like for non bundled messages... Downside: this affects {{TCP}} and {{UDP}} which don't need to copy. Is blindly copying in {{TCP_NIO2}} an option ? The copies would be unneeded for non-bundled messages, but I guess most messages are bundled, so this should be ok... Copying in {{TCP_NIO2}} is similar to copying in {{TCP}}, with send-queues being enabled... was (Author: belaban): For non-bundled messages, we create a new buffer for every message: those buffers are not reused. In contrast, message bundlers create a buffer (initial size: 1024 bytes) which is always reused and thus potentially increases. Perhaps we need to abandon this and create a new buffer in bundlers for every message, too, like for non bundled messages... Downside: this affects {{TCP}} and {{UDP}} which don't need to copy. Is blindly copying in {{TCP_PING}} an option ? The copies would be unneeded for non-bundled messages, but I guess most messages are bundled, so this should be ok... Copying in {{TCP_NIO2}} is similar to copying in {{TCP}}, with send-queues being enabled... -- This message was sent by Atlassian JIRA (v6.4.11#64026)