]
Manik Surtani commented on JGRP-1414:
-------------------------------------
Pull request sent -
Synchronizing on 'members' MessageDispatcher.cast() is a
contention point
-------------------------------------------------------------------------
Key: JGRP-1414
URL:
https://issues.jboss.org/browse/JGRP-1414
Project: JGroups
Issue Type: Bug
Affects Versions: 3.0.2
Reporter: Manik Surtani
Assignee: Bela Ban
Labels: concurrency, performance
Attachments: TreeSet.png
MessageDispatcher.cast() synchronizes on {{members}} and copies it to a local collection
if {{null}} is passed in as your destination list. This is a contention point if you have
many concurrent threads attempting to cast() to the entire cluster, as they start queueing
up at this point.
Guarding {{members}} with a ReadWriteLock is probably a better approach, allowing
{{members}} to be read safely and concurrently.
However, since {{members}} is protected, I am not sure of the implications around this.
But then again, there is no guarantee that subclasses/extensions synchronize on
{{members}} anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: