[jboss-jira] [JBoss JIRA] Issue Comment Edited: (JBRULES-2833) DroolsCompilerAntTask should scan for drools.package first

[ https://issues.jboss.org/browse/JBRULES-2833?page=com.atlassian.jira.plug... ] Evert Penninckx edited comment on JBRULES-2833 at 4/1/11 10:23 AM: ------------------------------------------------------------------- This issue is not resolved. 1. The file pattern to include/exclude .package files is incorrect: should be "*.package" instead of {code}"*\\*\\*..package"{code} 2. DirectoryScanner.scan() is not called after the includes/excludes are overridden. 3. Most importantly: Overriding the includes which are already defined in the ant task seems like bad design. Seems more logical to me to add a Comparator on the file list which prioritises files with extension .package 4. unittest? ;-) was (Author: evertp): This issue is not resolved. 1. The file pattern to include/exclude .package files is incorrect: should be "*.package" instead of "*\\*\\*..package" 2. DirectoryScanner.scan() is not called after the includes/excludes are overridden. 3. Most importantly: Overriding the includes which are already defined in the ant task seems like bad design. Seems more logical to me to add a Comparator on the file list which prioritises files with extension .package 4. unittest? ;-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira