[jboss-jira] [JBoss JIRA] Closed: (JBMESSAGING-140) Move responsibility for management of delivery list from receiver into channel

Move responsibility for management of delivery list from receiver into channel ------------------------------------------------------------------------------ Key: JBMESSAGING-140 URL: http://jira.jboss.com/jira/browse/JBMESSAGING-140 Project: JBoss Messaging Issue Type: Task Components: Messaging Core Reporter: Tim Fox Assigned To: Tim Fox Fix For: 1.2.0.CR1 Original Estimate: 4 days Remaining Estimate: 4 days Currently each receiver has the responsibility for managing it's list of deliveries. This is to avoid a race condition whereby the message can be acked before the call to handle has returned. This is a high burden of responsibility for the receiver and results in a lot of unnecessary code in the receiver implementation, plus an extra hashmap lookup We should consider whether we can give the responsibiltty to the channel. We could still acknowledge and cancel throught the delivery object, by creating one when required and calling cancel/acknowledge on it. the instance of delivery won't contain a message reference but just a message id. then inside delivery.cancel()/acknowledge(), it calls channel.cancel(this) and the channel is smart enought to lookup the delivery/reference as required. This won't require ANY changes to the receiver/channel interface and will allow us to get rid of the delivery list