[jboss-jira] [JBoss JIRA] (JBRULES-3260) Events with no expiration declared being set to zero expirationOffset during package assembly

Events with no expiration declared being set to zero expirationOffset during package assembly --------------------------------------------------------------------------------------------- Key: JBRULES-3260 URL: https://issues.jboss.org/browse/JBRULES-3260 Project: Drools Issue Type: Bug Security Level: Public(Everyone can see) Components: drools-core (expert), drools-core (fusion) Affects Versions: 5.3.0.CR1, 5.3.0.Final Reporter: Rob Crawford Assignee: Edson Tirelli Fix For: 5.3.1.Final, 5.4.0.Beta1 Had a problem with events being expired immediately on being inserted. These events have no @expiration declaration. Tracing and debugging led to this line: ReteooRuleBase, line 477: node.setExpirationOffset( Math.max( node.getExpirationOffset(), typeDeclaration.getExpirationOffset()+1 ) ); Since neither the type and its supertype have expirations declared, getExpirationOffset() returns -1 in both cases. Max(-1, -1 + 1) == 0, so the event is assigned an expiration of zero. Should make sure not to set the expiration when both are already -1.