[jboss-jira] [JBoss JIRA] (WFCORE-1525) ageout-history does not report failures
[
https://issues.jboss.org/browse/WFCORE-1525?page=com.atlassian.jira.plugi...
]
Bartosz Spyrko-Śmietanko edited comment on WFCORE-1525 at 5/4/16 5:44 PM:
--------------------------------------------------------------------------
Proposed fix - if ageout-history fails to delete some history files, it returns with
{noformat}
{
"outcome" => "failed",
"failure-description" => "WFLYCTL0158: Operation handler failed:
java.lang.IllegalStateException: WFLYPAT0048: Unable to remove some of the history
files.",
"rolled-back" => true
}
{noformat}
In addition offending files are logged at warning level in the patching logger:
{noformat}
[33m22:12:47,080 WARN [org.jboss.as.patching] (management-handler-thread - 3)
WFLYPAT0001: Cannot delete file
/Users/spyrkob/workspaces/set/wildfly-core/testsuite/patching/target/wildfly-core/.installation/patches/cp0/configuration
[33m22:12:47,081 WARN [org.jboss.as.patching] (management-handler-thread - 3)
WFLYPAT0001: Cannot delete file
/Users/spyrkob/workspaces/set/wildfly-core/testsuite/patching/target/wildfly-core/.installation/patches/cp0/timestamp
{noformat}
was (Author: spyrkob):
Proposed fix - if ageout-history fails to delete some history files, it returns with
```
{
"outcome" => "failed",
"failure-description" => "WFLYCTL0158: Operation handler failed:
java.lang.IllegalStateException: WFLYPAT0048: Unable to remove some of the history
files.",
"rolled-back" => true
}
```
In addition offending files are logged at warning level in the patching logger:
```
[33m22:12:47,080 WARN [org.jboss.as.patching] (management-handler-thread - 3)
WFLYPAT0001: Cannot delete file
/Users/spyrkob/workspaces/set/wildfly-core/testsuite/patching/target/wildfly-core/.installation/patches/cp0/configuration
[33m22:12:47,081 WARN [org.jboss.as.patching] (management-handler-thread - 3)
WFLYPAT0001: Cannot delete file
/Users/spyrkob/workspaces/set/wildfly-core/testsuite/patching/target/wildfly-core/.installation/patches/cp0/timestamp
```
ageout-history does not report failures
----------------------------------------
Key: WFCORE-1525
URL: https://issues.jboss.org/browse/WFCORE-1525
Project: WildFly Core
Issue Type: Bug
Components: Patching
Affects Versions: 2.1.0.Final
Reporter: Dennis Reed
Assignee: Bartosz Spyrko-Śmietanko
When ageout-history cannot delete the old CP files, it silently fails and returns
"success".
LocalAgeoutHistoryHandler#recursiveDelete does keep track of whether the
delete failed or succeeded, but the return value from this method is ignored
in execute(...).
If recursiveDelete returns false, it should report a failure.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)