]
Matteo Mortari commented on DROOLS-5132:
----------------------------------------
CRITERIA FOR RESOLVING THIS JIRA as of 2020-04-08: revert for kie-dmn-tck to use TCK
upstream repo's master branch, might require reverting multiple commits of kie-dmn-tck
pom.xml
DMN Drools TCK runner updates
-----------------------------
Key: DROOLS-5132
URL:
https://issues.redhat.com/browse/DROOLS-5132
Project: Drools
Issue Type: Task
Components: dmn engine
Reporter: Matteo Mortari
Assignee: Matteo Mortari
Priority: Major
Activities on upstream DMN TCK is on hold as no meetings are being held -> no PRs
merged on DMN TCK repo.
Hence this PR is pending:
https://github.com/dmn-tck/tck/pull/360
In that branch/PR, I am aligning with the original TCK intention that
"errorResult" flag is an hint, but cannot be enforced, over the runners.
Example, in case
* the result from a DMN expression evaluation is null,
* the TCK expect a null,
* IFF TCK did not flagged as "errorResult", we no longer just fail simply
because the Drools DMN engine reported an error (which was not indicated by the TCK
test).
https://github.com/dmn-tck/tck/pull/360/files#diff-49ce6a21913fba22bc06e7...
Before, if the Drools DMN engine raised an error, but the TCK did not indicated as
"errorResult" we were reporting a failure, even if the actual value was
consistent with the expected one!
Now is aligned as explained.
Naturally, I've in parallel raised already PR to TCK to fix the test and to provide
the proper "errorResult" hint. (
https://github.com/dmn-tck/tck/pull/359)
Once the DMN-TCK-upstream PR for the Drools TCK runner is merged, the commit
https://github.com/kiegroup/drools/commit/ca70199cf5edccf5261f153dde3296c... can be
reverted.