[jboss-jira] [JBoss JIRA] (AS7-2579) system property replacement doesn't work

[ https://issues.jboss.org/browse/AS7-2579?page=com.atlassian.jira.plugin.s... ] Oleg Kulikov commented on AS7-2579: ----------------------------------- Regarding this issue I want to suggest resolve expression inside method SimpleAttributeDefinition.parseAndSetParameter if only attribute definition support expressions. --- HEAD +++ Modified In Working Tree @@ -204,7 +204,7 @@ * @throws XMLStreamException if {@code value} is not valid */ public void parseAndSetParameter(final String value, final ModelNode operation, final XMLStreamReader reader) throws XMLStreamException { - ModelNode paramVal = parse(value, reader); + ModelNode paramVal = this.isAllowExpression() ? parse(value, reader).resolve() : parse(value, reader); operation.get(getName()).set(paramVal); } This modification allows to automaticaly resolve expressions for all particular configuration items supporting expressions. Example for datasource subsystem: //Attribute defines expression support static SimpleAttributeDefinition USERNAME = new SimpleAttributeDefinition(USERNAME_NAME, Credential.Tag.USER_NAME.getLocalName(), new ModelNode(), ModelType.STRING, true, true, MeasurementUnit.NONE); However, the it is not enough to declare expression support and explicit resolution is required irrespective of declaration. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira