[jboss-jira] [JBoss JIRA] Commented: (JBAS-9077) Deployment failure leads to a server hang

[ https://issues.jboss.org/browse/JBAS-9077?page=com.atlassian.jira.plugin.... ] jaikiran pai commented on JBAS-9077: ------------------------------------ Spent a bit of time on this one today. The DeploymentServiceListener _doesn't_ invoke the callback when a service installation fails: {code} public void serviceFailed(final ServiceController<? extends Object> controller, final StartException reason) { controller.removeListener(this); startExceptions.put(controller.getName(), reason); tick(controller); } {code} The "tick" method is supposed to invoke the callback to report the failed service: {code} private void tick(ServiceController<?> controller) { //this can happen if a service with missing deps is removed //we do not decrement the count, as this has already happened //in the dependencyUninstalled method if (count.decrementAndGet() == 0) { target.removeListener(this); if(startExceptions.isEmpty() && failedDependencies.isEmpty()) { log.infof("Completed deployment of \"%s\" in %d ms", deploymentName, Long.valueOf((System.nanoTime() - startTime) / 1000000L)); callback.handleComplete(); } else { final StringBuilder builder = new StringBuilder("Deployment \"%s\" failed in %d ms. "); if(!startExceptions.isEmpty()) { builder.append("Service failures: ").append(startExceptions.values()); } if(!failedDependencies.isEmpty()) { builder.append("Failed Dependencies: ").append(failedDependencies); } log.infof(builder.toString(), deploymentName, Long.valueOf((System.nanoTime() - startTime) / 1000000L)); callback.handleFailure(startExceptions, failedDependencies); } } } {code} However, the "if" block in the tick method doesn't evaluate to true and as a result the callback isn't invoked to handle the failure. I don't yet know the details about the listeners and the deployment lifecycle, so not too sure if that count check is correct. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira