[ http://jira.jboss.com/jira/browse/JBRULES-1273?page=comments#action_12382154 ] Mark Proctor commented on JBRULES-1273: --------------------------------------- can you attach it to our JIRA for us to look at? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-1273?page=comments#action_12383653 ] Rainer Langbehn commented on JBRULES-1273: ------------------------------------------ Hi Mark, some refactoring was necessary and I prepared some examples. I will attach the code shortly. Bye -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-1273?page=all ] Rainer Langbehn updated JBRULES-1273: ------------------------------------- Attachment: maven-drools-plugins.zip Hi Fernando, please take a look at the attached code. Bye Rainer -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-1273?page=comments#action_12389044 ] Rainer Langbehn commented on JBRULES-1273: ------------------------------------------ Anything new on this issue? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBRULES-1273?page=com.atlassian.jira.p... ] Rainer Langbehn commented on JBRULES-1273: ------------------------------------------ ...mmhh, nothing happens to this issue :-( ok, for all of you who voted for and are watching this issue and for everybody else, in the meantime i started a separate project @ sourceforge, http://sourceforge.net/projects/rules/, that aims to provide a set of solely Java Rule Engine API (JSR 94) based components to support the development, testing, integration, management, monitoring and execution of java rules based enterprise applications. The identified and planned components so far are: * a set of Maven 2 plugins for compiling and testing Rule Execution Sets * a JSR 94 based JCA Resource Adapter * a JSR 94 based Stateful Decision Service * a JSR 94 based Stateless Decision Service * a set of MBeans for management and monitoring Currently only support for drools is provided and the project is still in an early phase but i think you can get an idea :-) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBRULES-1273?page=com.atlassian.jira.p... ] Rainer Langbehn commented on JBRULES-1273: ------------------------------------------ Michael, ...I agree. The Maven 2 compiler plugin is almost ready to be released (a class loading issue, error reporting, unit tests and docs are still missing). I will comment this issue if it is released. I 'll respect your hint conecrning JSR-94 and concrete rule engine implementations. BTW, it would be nice, if drools could provide a way to make guvnor usable from the JSR-94 implementation. For this I will create a new issue with my proposed patch. Bye Rainer -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBRULES-1273?page=com.atlassian.jira.p... ] Rainer Langbehn commented on JBRULES-1273: ------------------------------------------ FYI, I just created the issue JBRULES-1721 with my proposed patch to support different implementations of the rule execution set repository to be used. Through this patch the connection between the JSR-94 implementation and the BRMS part of guvnor is possible. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBRULES-1273?page=com.atlassian.jira.p... ] Mark Proctor commented on JBRULES-1273: --------------------------------------- Rainer, Fernando has moved on from JBoss, so not sure what the status of his code review us. Will you be able to get this finished for Drools 5.0, meaning in the next 2 weeks? With unit tests and documentation? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBRULES-1273?page=com.atlassian.jira.plugin... ] Geoffrey De Smet reassigned JBRULES-1273: ----------------------------------------- Assignee: Geoffrey De Smet (was: Michael Neale) Assigning to me. Thinking it would take about a day or 3 to do it, including integration tests and needed cleanup. No time atm, so feel free to steal it from me or provide a patch :) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBRULES-1273?page=com.atlassian.jira.plug... ] Ansgar Konermann commented on JBRULES-1273: ------------------------------------------- Source code of the actual MOJO from the sakai project (second link) is here: https://github.com/sakaiproject/nakamura/blob/master/sandbox/drools/drool... Lean, straightforward implementation. Supports drl, xml and rf files. Single source file for MOJO. Could not find any maven plugin descriptors in the source code. First link from above belongs to this project: http://www.javaforge.com/project/DroolsHelp which is owned by Mathieu Boretti. Scope of this project is broader, adds custom drools<->java integration layer (annotations, spring), bytecode instrumentation. Source code of plugin is available via download of source code JAR: http://www.javaforge.com/displayDocument/drools5-integration-helper-maven... This one is with an extensive plugin descriptor, implementation is slightly more complex, but still easily comprehensible. Includes HelpMojo capable of writing terse usage instructions to the maven log/console. Includes DroolsReport mojo (reporter plugin), integrating the output of plugin run into site. Third variant (attached to this ticket) is comparable to DroolsHelp project in complexity. It's the only one with support for JSR-94 AFAICS. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBRULES-1273?page=com.atlassian.jira.plug... ] Ansgar Konermann edited comment on JBRULES-1273 at 1/8/11 10:44 PM: -------------------------------------------------------------------- Source code of the actual MOJO from the sakai project (second link) is here: https://github.com/sakaiproject/nakamura/blob/master/sandbox/drools/drool... Lean, straightforward implementation. Supports drl, xml and rf files. Single source file for MOJO. Could not find any maven plugin descriptors in the source code. --- First link from above belongs to this project: http://www.javaforge.com/project/DroolsHelp which is owned by Mathieu Boretti. Scope of this project is broader, adds custom drools<->java integration layer (annotations, spring), bytecode instrumentation. Source code of plugin is available via download of source code JAR: http://www.javaforge.com/displayDocument/drools5-integration-helper-maven... This one is with an extensive plugin descriptor, implementation is slightly more complex, but still easily comprehensible. Includes HelpMojo capable of writing terse usage instructions to the maven log/console. Includes DroolsReport mojo (reporter plugin), integrating the output of plugin run into site. --- Third variant (attached to this ticket) is comparable to DroolsHelp project in complexity. It's the only one with support for JSR-94 AFAICS. was (Author: akonermann): Source code of the actual MOJO from the sakai project (second link) is here: https://github.com/sakaiproject/nakamura/blob/master/sandbox/drools/drool... Lean, straightforward implementation. Supports drl, xml and rf files. Single source file for MOJO. Could not find any maven plugin descriptors in the source code. First link from above belongs to this project: http://www.javaforge.com/project/DroolsHelp which is owned by Mathieu Boretti. Scope of this project is broader, adds custom drools<->java integration layer (annotations, spring), bytecode instrumentation. Source code of plugin is available via download of source code JAR: http://www.javaforge.com/displayDocument/drools5-integration-helper-maven... This one is with an extensive plugin descriptor, implementation is slightly more complex, but still easily comprehensible. Includes HelpMojo capable of writing terse usage instructions to the maven log/console. Includes DroolsReport mojo (reporter plugin), integrating the output of plugin run into site. Third variant (attached to this ticket) is comparable to DroolsHelp project in complexity. It's the only one with support for JSR-94 AFAICS. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBRULES-1273?page=com.atlassian.jira.plug... ] Ansgar Konermann commented on JBRULES-1273: ------------------------------------------- Hi Geoffrey, where does this requirement for incremental build support originate from? - is it a requirement for all Maven 3 plugins? or - is it a requirement for inclusion of the plugin into the Drools mainline? If it is a requirement to be accepted for mainline inclusion: does the drools compiler API support incremental compilation? Can you point me to the relevant interfaces and/or methods? As far as I know, the KnowledgeBuilder interface only has add() methods to add resources and does not support removal of packages or other artifacts from the knowledge base which originally were inserted as result of compilation of a given resource file. I'm not sure about current features of the knowledge agent, but last time I looked, the agent was also only capable of *adding* new files to a knowledge base. In case of rule refactoring (e. g. moving rule R from package A to package B, and an existing compiled knowledge base where rule R is already compiled into package A), how can the compiler act sensibly during "incremental compilation"? As we cannot tell from which file the rule R in package A originated, and there is no methot to remove this from the knowledge base either, I see no use of *adding* another rule R to package B (as the build would be totally inconsistent with what is stored in the files on disk. This is different to java compilation, where each java file is compiled into a number of classes in a reproducible manner. Given a modified java file, one can tell exactly which classes have to be overwritten. Maybe this is just my personal taste, but since incremental compilation introduces a lot of chances for inconsistencies, I'd suggest this can be postponed to a later version of a compiler plugin, in favour of bringing value to potential users earlier with a basic feature set. What do you mean by "drl compiler plugin MUST support incremental builds"? -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBRULES-1273?page=com.atlassian.jira.plug... ] Geoffrey De Smet commented on JBRULES-1273: ------------------------------------------- Ansgar distilled a best-of-the-best maven plugin: http://passion.forco.de/content/maven-drools-plugin It's on github (yaaay!:) https://github.com/ansgarkonermann/maven-drools-plugin/blob/master/maven-... -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira