1:20 p.m.
Alexey Loubyansky created AS7-3561:
--------------------------------------
Summary: change validate-address operation contract
Key: AS7-3561
URL: https://issues.jboss.org/browse/AS7-3561
Project: Application Server 7
Issue Type: Task
Components: Domain Management
Reporter: Alexey Loubyansky
Assignee: Alexey Loubyansky
Fix For: 7.1.0.Final
Current implementation is not safe in a sense that the operation fails if the address is
not valid. There is no safe way, i.e. a boolean result, not a failure, to check whether an
address is valid.
The idea is to change the current validate-address so that:
- it's only a root operation, not inherited like the current impl;
- add an address argument (the current impl has no arguments), which will be the address
to check;
- the result type should be a boolean value;
- in case of failure, include a message into the response describing which part of the
address is wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:36 a.m.
[
https://issues.jboss.org/browse/AS7-3561?page=com.atlassian.jira.plugin.s...
]
Alexey Loubyansky resolved AS7-3561.
------------------------------------
Resolution: Done
Done.
change validate-address operation contract
------------------------------------------
Key: AS7-3561
URL: https://issues.jboss.org/browse/AS7-3561
Project: Application Server 7
Issue Type: Task
Components: Domain Management
Reporter: Alexey Loubyansky
Assignee: Alexey Loubyansky
Fix For: 7.1.0.Final
Current implementation is not safe in a sense that the operation fails if the address is
not valid. There is no safe way, i.e. a boolean result, not a failure, to check whether an
address is valid.
The idea is to change the current validate-address so that:
- it's only a root operation, not inherited like the current impl;
- add an address argument (the current impl has no arguments), which will be the address
to check;
- the result type should be a boolean value;
- in case of failure, include a message into the response describing which part of the
address is wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:18 a.m.
[
https://issues.jboss.org/browse/AS7-3561?page=com.atlassian.jira.plugin.s...
]
Michael Golubev commented on AS7-3561:
--------------------------------------
Hello,
This change broke IDEA support of JBoss 7
(http://youtrack.jetbrains.com/issue/IDEA-81489)
In IDEA, we have used 'validate-address' operation in 2 cases:
1) check whether server is ready for remote administration - call to
'validate-address' without address
2) check whether deployment is registered on the server - call to
'validate-address' with 'deployment=<artifact name>' as the address
As I can see from the AS7-3561 and from the actual CLI of the JBoss 7.1.0 final, now,
validate-address:
- could be executed without address only
(execution with 'deployment=<artifact name>' fails with JBAS014739: No
handler for validate-address at address [("deployment" => "=<artifact
name>")]
- requires the 'value' attribute
But, 'value' attribute seems not to expect address or just broken itself, since
every value I've passed as the 'value' fails with JBAS014749: Operation
handler failed: null
(I've tried empty string, "/", "/deployment=<deployed artifact
name>/"...)
Could you please describe what is expected as 'value' or confirm
'validate-address' is broken now?
Regards,
Michael
change validate-address operation contract
------------------------------------------
Key: AS7-3561
URL: https://issues.jboss.org/browse/AS7-3561
Project: Application Server 7
Issue Type: Task
Components: Domain Management
Reporter: Alexey Loubyansky
Assignee: Alexey Loubyansky
Fix For: 7.1.0.Final
Current implementation is not safe in a sense that the operation fails if the address is
not valid. There is no safe way, i.e. a boolean result, not a failure, to check whether an
address is valid.
The idea is to change the current validate-address so that:
- it's only a root operation, not inherited like the current impl;
- add an address argument (the current impl has no arguments), which will be the address
to check;
- the result type should be a boolean value;
- in case of failure, include a message into the response describing which part of the
address is wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:43 a.m.
[
https://issues.jboss.org/browse/AS7-3561?page=com.atlassian.jira.plugin.s...
]
Alexey Loubyansky commented on AS7-3561:
----------------------------------------
Sorry for the trouble and thanks for letting us know.
The new implementation works fine. Here is an example of a DMR validate-address operation
request:
ModelNode op = new ModelNode();
op.get("operation").set("validate-address");
// root address
op.get("address").setEmptyList();
// to validate the root (which is unlikely useful but as an example)
// op.get("value").setEmptyList();
// or a non-root address
ModelNode address = op.get("value").setEmptyList();
address.add("deployment", "my-app.war");
// if your path is deeper, just add all of them
// address.add("child-type", "child-name");
Now you can execute the op.
From the command line, since it's an operation, arguments are
accepted in the DMR toString() format. E.g. for
/subsystem=datasources/data-source=ExampleDS
[standalone@localhost:9999 /]
:validate-address(value=[{"subsystem"=>"datasources"},{"data-source"=>"ExampleDS"}])
{
"outcome" => "success",
"result" => {"valid" => true}
}
Which isn't a friendly syntax. But for operations, I think, it'll stay this way.
If needed, we can add a command with a native node address syntax.
change validate-address operation contract
------------------------------------------
Key: AS7-3561
URL: https://issues.jboss.org/browse/AS7-3561
Project: Application Server 7
Issue Type: Task
Components: Domain Management
Reporter: Alexey Loubyansky
Assignee: Alexey Loubyansky
Fix For: 7.1.0.Final
Current implementation is not safe in a sense that the operation fails if the address is
not valid. There is no safe way, i.e. a boolean result, not a failure, to check whether an
address is valid.
The idea is to change the current validate-address so that:
- it's only a root operation, not inherited like the current impl;
- add an address argument (the current impl has no arguments), which will be the address
to check;
- the result type should be a boolean value;
- in case of failure, include a message into the response describing which part of the
address is wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:45 a.m.
[
https://issues.jboss.org/browse/AS7-3561?page=com.atlassian.jira.plugin.s...
]
Alexey Loubyansky commented on AS7-3561:
----------------------------------------
Small correction...
// or a non-root address
ModelNode address = op.get("value").setEmptyList();
address.add("deployment", "my-app.war");
You don't have to setEmptyList() before adding elements. It was just copy&paste,
sorry.
change validate-address operation contract
------------------------------------------
Key: AS7-3561
URL: https://issues.jboss.org/browse/AS7-3561
Project: Application Server 7
Issue Type: Task
Components: Domain Management
Reporter: Alexey Loubyansky
Assignee: Alexey Loubyansky
Fix For: 7.1.0.Final
Current implementation is not safe in a sense that the operation fails if the address is
not valid. There is no safe way, i.e. a boolean result, not a failure, to check whether an
address is valid.
The idea is to change the current validate-address so that:
- it's only a root operation, not inherited like the current impl;
- add an address argument (the current impl has no arguments), which will be the address
to check;
- the result type should be a boolean value;
- in case of failure, include a message into the response describing which part of the
address is wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4652
days inactive
4668
days old
4 comments
2 participants
participants (2)
-
Alexey Loubyansky (JIRA) -
Michael Golubev (JIRA)