[JBoss JIRA] Created: (JBBOOT-43) Throw validation error if bootstrapUrl != a File

[JBoss JIRA] Created:...

[JBoss JIRA] Created: (JBAS-7185)...

Andrew Lee Rubinger (JIRA)

Wednesday, 15 April 2009 Wed, 15 Apr '09

2:20 p.m.

Throw validation error if bootstrapUrl != a File ------------------------------------------------ Key: JBBOOT-43 URL: https://jira.jboss.org/jira/browse/JBBOOT-43 Project: JBoss Bootstrap Issue Type: Feature Request Components: impl-base Affects Versions: 0.1.1 Reporter: Andrew Lee Rubinger Fix For: 0.1.2 Make a check to ensure that bootstrapUrl is a true file, not a directory. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

Show replies by date

Andrew Lee Rubinger (JIRA)

Wednesday, 15 April Wed, 15 Apr

2:22 p.m.

New subject: [JBoss JIRA] Assigned: (JBBOOT-43) Throw validation error if bootstrapUrl != a File

[ https://jira.jboss.org/jira/browse/JBBOOT-43?page=com.atlassian.jira.plug... ] Andrew Lee Rubinger reassigned JBBOOT-43: ----------------------------------------- Assignee: Andrew Lee Rubinger

...

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

Andrew Lee Rubinger (JIRA)

2:24 p.m.

New subject: [JBoss JIRA] Commented: (JBBOOT-43) Throw validation error if bootstrapUrl != a File

...

Andrew Lee Rubinger (JIRA)

Saturday, 23 May Sat, 23 May

2:57 p.m.

New subject: [JBoss JIRA] Updated: (JBBOOT-43) Throw validation error if bootstrapUrl != a File

[ https://jira.jboss.org/jira/browse/JBBOOT-43?page=com.atlassian.jira.plug... ] Andrew Lee Rubinger updated JBBOOT-43: -------------------------------------- Fix Version/s: Unscheduled (was: 0.1.2)

...

Andrew Lee Rubinger (JIRA)

Friday, 14 August Fri, 14 Aug

3:57 p.m.

New subject: [JBoss JIRA] Assigned: (JBBOOT-43) Throw validation error if bootstrapUrl != a File

[ https://jira.jboss.org/jira/browse/JBBOOT-43?page=com.atlassian.jira.plug... ] Andrew Lee Rubinger reassigned JBBOOT-43: ----------------------------------------- Assignee: John Bailey (was: Andrew Lee Rubinger)

...

John Bailey (JIRA)

Sunday, 16 August Sun, 16 Aug

9:27 a.m.

New subject: [JBoss JIRA] Updated: (JBBOOT-43) Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements

[ https://jira.jboss.org/jira/browse/JBBOOT-43?page=com.atlassian.jira.plug... ] John Bailey updated JBBOOT-43: ------------------------------ Summary: Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements (was: Throw validation error if bootstrapUrl != a File)

...

Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements ---------------------------------------------------------------------------------------------------- Key: JBBOOT-43 URL: https://jira.jboss.org/jira/browse/JBBOOT-43 Project: JBoss Bootstrap Issue Type: Feature Request Components: impl-base Affects Versions: 0.1.1 Reporter: Andrew Lee Rubinger Assignee: John Bailey Fix For: Unscheduled Make a check to ensure that bootstrapUrl is a true file, not a directory.

John Bailey (JIRA)

9:29 a.m.

New subject: [JBoss JIRA] Updated: (JBBOOT-43) Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements

[ https://jira.jboss.org/jira/browse/JBBOOT-43?page=com.atlassian.jira.plug... ] John Bailey updated JBBOOT-43: ------------------------------ Description: Make sure the bootstrapUrl works for URLs other than file:// and verify both relative and fully qualified <url> elements are handled correctly. (was: Make a check to ensure that bootstrapUrl is a true file, not a directory.)

...

Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements ---------------------------------------------------------------------------------------------------- Key: JBBOOT-43 URL: https://jira.jboss.org/jira/browse/JBBOOT-43 Project: JBoss Bootstrap Issue Type: Feature Request Components: impl-base Affects Versions: 0.1.1 Reporter: Andrew Lee Rubinger Assignee: John Bailey Fix For: Unscheduled Make sure the bootstrapUrl works for URLs other than file:// and verify both relative and fully qualified <url> elements are handled correctly.

John Bailey (JIRA)

9:31 a.m.

New subject: [JBoss JIRA] Commented: (JBBOOT-43) Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements

[ https://jira.jboss.org/jira/browse/JBBOOT-43?page=com.atlassian.jira.plug... ] John Bailey commented on JBBOOT-43: ----------------------------------- Updated the issue to focus on making sure the the bootstrapURL fully supports all URLs including.

...

Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements ---------------------------------------------------------------------------------------------------- Key: JBBOOT-43 URL: https://jira.jboss.org/jira/browse/JBBOOT-43 Project: JBoss Bootstrap Issue Type: Feature Request Components: impl-base Affects Versions: 0.1.1 Reporter: Andrew Lee Rubinger Assignee: John Bailey Fix For: Unscheduled Make sure the bootstrapUrl works for URLs other than file:// and verify both relative and fully qualified <url> elements are handled correctly.

John Bailey (JIRA)

10:33 a.m.

New subject: [JBoss JIRA] Commented: (JBBOOT-43) Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements

[ https://jira.jboss.org/jira/browse/JBBOOT-43?page=com.atlassian.jira.plug... ] John Bailey commented on JBBOOT-43: ----------------------------------- After a series of tests, it is a pretty straight forward change to get full URL support. The change just requires the AbstractMCServerBase start to process all nested <url> elements with the bootstrapUrl as the context and not the bootstrapHome. The only thing that does not work is having relative URLs what begin with a slash either in the bootstrapUrl or a nested <url>. This does not work in the existing implementation either. Should this be supported, or should it continue to throw an exception when starting with a slash? I am attaching a patch that includes some tests to show the failure when the slash is present.

...

Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements ---------------------------------------------------------------------------------------------------- Key: JBBOOT-43 URL: https://jira.jboss.org/jira/browse/JBBOOT-43 Project: JBoss Bootstrap Issue Type: Feature Request Components: impl-base Affects Versions: 0.1.1 Reporter: Andrew Lee Rubinger Assignee: John Bailey Fix For: Unscheduled Make sure the bootstrapUrl works for URLs other than file:// and verify both relative and fully qualified <url> elements are handled correctly.

John Bailey (JIRA)

10:35 a.m.

New subject: [JBoss JIRA] Updated: (JBBOOT-43) Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements

[ https://jira.jboss.org/jira/browse/JBBOOT-43?page=com.atlassian.jira.plug... ] John Bailey updated JBBOOT-43: ------------------------------ Attachment: JBBOOT-43.patch Patch includes an update to support relative <url> elements working off the bootstrapUrl.

...

Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements ---------------------------------------------------------------------------------------------------- Key: JBBOOT-43 URL: https://jira.jboss.org/jira/browse/JBBOOT-43 Project: JBoss Bootstrap Issue Type: Feature Request Components: impl-base Affects Versions: 0.1.1 Reporter: Andrew Lee Rubinger Assignee: John Bailey Fix For: Unscheduled Attachments: JBBOOT-43.patch Make sure the bootstrapUrl works for URLs other than file:// and verify both relative and fully qualified <url> elements are handled correctly.

Andrew Lee Rubinger (JIRA)

11:56 p.m.

New subject: [JBoss JIRA] Commented: (JBBOOT-43) Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements

[ https://jira.jboss.org/jira/browse/JBBOOT-43?page=com.atlassian.jira.plug... ] Andrew Lee Rubinger commented on JBBOOT-43: ------------------------------------------- Looks like the patch generally tests the right idea. 1) Looks like you can do away with the MCServerBootstrapUrlTestCase.@After lifecycle method if you shut down the server in each test. Actually, this should be done anyway (so that the environment is left in consistent state). Shutdown will remove all properties set during startup. @see AbstractBasicServerInitializer.cleanup for the impl. 2) MCServerBootstrapUrlTestCase.testNestedUrlStartsWithSlash and testBootstrapUrlStartsWithSlash are testing implementation details regarding the exception message. Might be better to introduce a new exception type and test for instanceof. 3) Nitpicking spelling/typos? ;) - * AbstractMCServerBase "choldBootstrapURL" > "childBootstrapURL" * MCServerBootstrapUrlTestCase "testBootstrapHttpUrlMiltiNested" > "testBootstrapHttpUrlMultiNested" * MCServerBootstrapUrlTestCase "testBootstrapFileUrlMulitNested" > "testBootstrapFileUrlMultiNested"

...

Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements ---------------------------------------------------------------------------------------------------- Key: JBBOOT-43 URL: https://jira.jboss.org/jira/browse/JBBOOT-43 Project: JBoss Bootstrap Issue Type: Feature Request Components: impl-base Affects Versions: 0.1.1 Reporter: Andrew Lee Rubinger Assignee: John Bailey Fix For: Unscheduled Attachments: JBBOOT-43.patch Make sure the bootstrapUrl works for URLs other than file:// and verify both relative and fully qualified <url> elements are handled correctly.

Andrew Lee Rubinger (JIRA)

Monday, 17 August Mon, 17 Aug

12:28 a.m.

New subject: [JBoss JIRA] Updated: (JBBOOT-43) Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements

[ https://jira.jboss.org/jira/browse/JBBOOT-43?page=com.atlassian.jira.plug... ] Andrew Lee Rubinger updated JBBOOT-43: -------------------------------------- Component/s: impl-mc (was: impl-base) Fix Version/s: impl-mc-2.0.0-alpha-3 (was: Unscheduled)

...

Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements ---------------------------------------------------------------------------------------------------- Key: JBBOOT-43 URL: https://jira.jboss.org/jira/browse/JBBOOT-43 Project: JBoss Bootstrap Issue Type: Feature Request Components: impl-mc Affects Versions: 0.1.1 Reporter: Andrew Lee Rubinger Assignee: John Bailey Fix For: impl-mc-2.0.0-alpha-3 Attachments: JBBOOT-43.patch Make sure the bootstrapUrl works for URLs other than file:// and verify both relative and fully qualified <url> elements are handled correctly.

John Bailey (JIRA)

7:28 a.m.

New subject: [JBoss JIRA] Commented: (JBBOOT-43) Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements

[ https://jira.jboss.org/jira/browse/JBBOOT-43?page=com.atlassian.jira.plug... ] John Bailey commented on JBBOOT-43: ----------------------------------- Thanks for looking it over. I have cleaned up 1 and 3 from above. I was attempting to test multiple different configurations of bootstrapUrl and bootstrapHome in a single test, which does not seem to work even with the shutdowServer lifecycle called. The server seems to leave the system property set for the bootstrapUrl after shutdown. This causes fun issues when you attempt to start a new server with just the bootstrapHome. As for the new exception type. Is there a standard place to put this, and do we just want to check if the URL starts with a slash and throw right away?

...

Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements ---------------------------------------------------------------------------------------------------- Key: JBBOOT-43 URL: https://jira.jboss.org/jira/browse/JBBOOT-43 Project: JBoss Bootstrap Issue Type: Feature Request Components: impl-mc Affects Versions: 0.1.1 Reporter: Andrew Lee Rubinger Assignee: John Bailey Fix For: impl-mc-2.0.0-alpha-3 Attachments: JBBOOT-43.patch Make sure the bootstrapUrl works for URLs other than file:// and verify both relative and fully qualified <url> elements are handled correctly.

John Bailey (JIRA)

7:58 a.m.

New subject: [JBoss JIRA] Commented: (JBBOOT-43) Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements

[ https://jira.jboss.org/jira/browse/JBBOOT-43?page=com.atlassian.jira.plug... ] John Bailey commented on JBBOOT-43: ----------------------------------- After second thought, I am not able to remove the additional lifecycle method in MCServerBootstrapUrlTestCase.@After. Even with the shutdownServerAndClear lifecycle, the system properties are not being removed between tests. If the system properties are not removed between tests, subsequent tests will fail if the only the bootstrapHome is set. When each test runs through the start process it runs through the property overrides and sets system properties for each of the bootstrap(Home, Name, URL) properties. So if the bootstrapUrl is set in one test, it will still be set as a system property for the next test. If the subsequent test only sets the bootstrapHome and bootstrapName, it will get the bootstrapUrl applied from the last test as part of the override properties step, and will likely fail with the wrong bootstrapUrl. This seems like something that should get cleaned up when the server is shutdown. To test this behavior, remove the clearServerProperties method and rerun the tests. You will see a failure occur and if traced through it is bases on a lingering bootstrapUrl system property. Should these system properties be cleaned up at server shutdown?

...

Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements ---------------------------------------------------------------------------------------------------- Key: JBBOOT-43 URL: https://jira.jboss.org/jira/browse/JBBOOT-43 Project: JBoss Bootstrap Issue Type: Feature Request Components: impl-mc Affects Versions: 0.1.1 Reporter: Andrew Lee Rubinger Assignee: John Bailey Fix For: impl-mc-2.0.0-alpha-3 Attachments: JBBOOT-43.patch Make sure the bootstrapUrl works for URLs other than file:// and verify both relative and fully qualified <url> elements are handled correctly.

Andrew Lee Rubinger (JIRA)

4:06 p.m.

New subject: [JBoss JIRA] Commented: (JBBOOT-43) Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements

[ https://jira.jboss.org/jira/browse/JBBOOT-43?page=com.atlassian.jira.plug... ] Andrew Lee Rubinger commented on JBBOOT-43: ------------------------------------------- When I add the shutdown, I see sysprop removal: 16:04:36,683 TRACE [SecurityActions] Removed system property "jboss.bootstrap.url" which had previous value: file:/home/alr/business/jboss/wc/jbossas/projects/bootstrap/trunk/impl-mc/target/tests-classes/bootstrap-urls.xml 16:04:36,683 TRACE [SecurityActions] Removed system property "jboss.bootstrap.home.url" which had previous value: file:/home/alr/business/jboss/wc/jbossas/projects/bootstrap/trunk/impl-mc/target/tests-classes/ 16:04:36,683 TRACE [SecurityActions] Removed system property "jboss.bootstrap.name" which had previous value: bootstrap-urls.xml Though one test does fail.

...

Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements ---------------------------------------------------------------------------------------------------- Key: JBBOOT-43 URL: https://jira.jboss.org/jira/browse/JBBOOT-43 Project: JBoss Bootstrap Issue Type: Feature Request Components: impl-mc Affects Versions: 0.1.1 Reporter: Andrew Lee Rubinger Assignee: John Bailey Fix For: impl-mc-2.0.0-alpha-3 Attachments: JBBOOT-43.patch Make sure the bootstrapUrl works for URLs other than file:// and verify both relative and fully qualified <url> elements are handled correctly.

Andrew Lee Rubinger (JIRA)

4:12 p.m.

New subject: [JBoss JIRA] Updated: (JBBOOT-43) Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements

[ https://jira.jboss.org/jira/browse/JBBOOT-43?page=com.atlassian.jira.plug... ] Andrew Lee Rubinger updated JBBOOT-43: -------------------------------------- Attachment: JBBOOT-43.patch

...

Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements ---------------------------------------------------------------------------------------------------- Key: JBBOOT-43 URL: https://jira.jboss.org/jira/browse/JBBOOT-43 Project: JBoss Bootstrap Issue Type: Feature Request Components: impl-mc Affects Versions: 0.1.1 Reporter: Andrew Lee Rubinger Assignee: John Bailey Fix For: impl-mc-2.0.0-alpha-3 Attachments: JBBOOT-43.patch, JBBOOT-43.patch Make sure the bootstrapUrl works for URLs other than file:// and verify both relative and fully qualified <url> elements are handled correctly.

John Bailey (JIRA)

4:27 p.m.

New subject: [JBoss JIRA] Commented: (JBBOOT-43) Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements

[ https://jira.jboss.org/jira/browse/JBBOOT-43?page=com.atlassian.jira.plug... ] John Bailey commented on JBBOOT-43: ----------------------------------- Seems like the server.shutdown shouldn't be necessary for tests that successfully startup, as it is in the @After lifecycle already. As you showed in the patch, the issue was with the exception cases the shutdown was not happening because it wasn't being started. ServerInitializer.cleanup resolves the issue. Is there a reason we still need to call the server.shutdown in the test body?

...

Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements ---------------------------------------------------------------------------------------------------- Key: JBBOOT-43 URL: https://jira.jboss.org/jira/browse/JBBOOT-43 Project: JBoss Bootstrap Issue Type: Feature Request Components: impl-mc Affects Versions: 0.1.1 Reporter: Andrew Lee Rubinger Assignee: John Bailey Fix For: impl-mc-2.0.0-alpha-3 Attachments: JBBOOT-43.patch, JBBOOT-43.patch Make sure the bootstrapUrl works for URLs other than file:// and verify both relative and fully qualified <url> elements are handled correctly.

John Bailey (JIRA)

6:34 p.m.

New subject: [JBoss JIRA] Updated: (JBBOOT-43) Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements

[ https://jira.jboss.org/jira/browse/JBBOOT-43?page=com.atlassian.jira.plug... ] John Bailey updated JBBOOT-43: ------------------------------ Attachment: JBBOOT-43_v2.patch New patch for review. Includes typed exception for invalid bootstrap URLs..

...

Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements ---------------------------------------------------------------------------------------------------- Key: JBBOOT-43 URL: https://jira.jboss.org/jira/browse/JBBOOT-43 Project: JBoss Bootstrap Issue Type: Feature Request Components: impl-mc Affects Versions: 0.1.1 Reporter: Andrew Lee Rubinger Assignee: John Bailey Fix For: impl-mc-2.0.0-alpha-3 Attachments: JBBOOT-43.patch, JBBOOT-43.patch, JBBOOT-43_v2.patch Make sure the bootstrapUrl works for URLs other than file:// and verify both relative and fully qualified <url> elements are handled correctly.

Andrew Lee Rubinger (JIRA)

Tuesday, 18 August Tue, 18 Aug

4:18 a.m.

New subject: [JBoss JIRA] Commented: (JBBOOT-43) Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements

...

Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements ---------------------------------------------------------------------------------------------------- Key: JBBOOT-43 URL: https://jira.jboss.org/jira/browse/JBBOOT-43 Project: JBoss Bootstrap Issue Type: Feature Request Components: impl-mc Affects Versions: 0.1.1 Reporter: Andrew Lee Rubinger Assignee: John Bailey Fix For: impl-mc-2.0.0-alpha-3 Attachments: JBBOOT-43.patch, JBBOOT-43.patch, JBBOOT-43_v2.patch Make sure the bootstrapUrl works for URLs other than file:// and verify both relative and fully qualified <url> elements are handled correctly.

John Bailey (JIRA)

9:17 a.m.

New subject: [JBoss JIRA] Resolved: (JBBOOT-43) Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements

[ https://jira.jboss.org/jira/browse/JBBOOT-43?page=com.atlassian.jira.plug... ] John Bailey resolved JBBOOT-43. ------------------------------- Resolution: Done Update was made to correctly handle relative and fully qualified bootstrap URLs.

...

Enable the use of local and remote URLs for bootstrapUrl and properly handle relative <url> elements ---------------------------------------------------------------------------------------------------- Key: JBBOOT-43 URL: https://jira.jboss.org/jira/browse/JBBOOT-43 Project: JBoss Bootstrap Issue Type: Feature Request Components: impl-mc Affects Versions: 0.1.1 Reporter: Andrew Lee Rubinger Assignee: John Bailey Fix For: impl-mc-2.0.0-alpha-3 Attachments: JBBOOT-43.patch, JBBOOT-43.patch, JBBOOT-43_v2.patch Make sure the bootstrapUrl works for URLs other than file:// and verify both relative and fully qualified <url> elements are handled correctly.

5565

days inactive

5690

days old

jboss-jira@lists.jboss.org

Manage subscription

19 comments

2 participants

tags (0)

participants (2)

Andrew Lee Rubinger (JIRA)
John Bailey (JIRA)

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

[JBoss JIRA] Created: (JBBOOT-43) Throw validation error if bootstrapUrl != a File