[JBoss JIRA] Created: (JBREM-1014) Support injection of socket factory class name into AbstractInvoker
1:23 a.m.
Support injection of socket factory class name into AbstractInvoker
-------------------------------------------------------------------
Key: JBREM-1014
URL: https://jira.jboss.org/jira/browse/JBREM-1014
Project: JBoss Remoting
Issue Type: Feature Request
Security Level: Public (Everyone can see)
Affects Versions: 2.2.2.SP8
Reporter: Ron Sigal
Assignee: Ron Sigal
Fix For: 2.2.2.SP9
It is intended that org.jboss.remoting.AbstractInvoker can accept the class name of a
SocketFactory, using the parameter org.jboss.remoting.Remoting.SOCKET_FACTORY_NAME (actual
value "socketFactory"). Unfortunately, the parameter name
"socketFactory" conflicts with the bean property of the same name. In
particular, the problem is that the method
public void setSocketFactory(SocketFactory socketFactory)
in AbstractInvoker expects a SocketFactory instead of a String.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:12 a.m.
New subject: [JBoss JIRA] Commented: (JBREM-1014) Support injection of socket factory class name into AbstractInvoker
[
https://jira.jboss.org/jira/browse/JBREM-1014?page=com.atlassian.jira.plu...
]
Ron Sigal commented on JBREM-1014:
----------------------------------
Added new parameter, org.jboss.remoting.Remoting.SOCKET_FACTORY_CLASS_NAME (actual value
"socketFactoryClassName"), which to replace Remoting.SOCKET_FACTORY_NAME (which
still exists).
Unit test:
org.jboss.test.remoting.transport.socket.socketfactory.SocketFactoryClassNameTestCase.
Support injection of socket factory class name into AbstractInvoker
-------------------------------------------------------------------
Key: JBREM-1014
URL: https://jira.jboss.org/jira/browse/JBREM-1014
Project: JBoss Remoting
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Affects Versions: 2.2.2.SP8
Reporter: Ron Sigal
Assignee: Ron Sigal
Fix For: 2.2.2.SP9
It is intended that org.jboss.remoting.AbstractInvoker can accept the class name of a
SocketFactory, using the parameter org.jboss.remoting.Remoting.SOCKET_FACTORY_NAME (actual
value "socketFactory"). Unfortunately, the parameter name
"socketFactory" conflicts with the bean property of the same name. In
particular, the problem is that the method
public void setSocketFactory(SocketFactory socketFactory)
in AbstractInvoker expects a SocketFactory instead of a String.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:28 a.m.
New subject: [JBoss JIRA] Updated: (JBREM-1014) Support injection of socket factory class name into AbstractInvoker
[
https://jira.jboss.org/jira/browse/JBREM-1014?page=com.atlassian.jira.plu...
]
Galder Zamarreno updated JBREM-1014:
------------------------------------
Support injection of socket factory class name into AbstractInvoker
-------------------------------------------------------------------
Key: JBREM-1014
URL: https://jira.jboss.org/jira/browse/JBREM-1014
Project: JBoss Remoting
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Affects Versions: 2.2.2.SP8
Reporter: Ron Sigal
Assignee: Ron Sigal
Fix For: 2.2.2.SP9
It is intended that org.jboss.remoting.AbstractInvoker can accept the class name of a
SocketFactory, using the parameter org.jboss.remoting.Remoting.SOCKET_FACTORY_NAME (actual
value "socketFactory"). Unfortunately, the parameter name
"socketFactory" conflicts with the bean property of the same name. In
particular, the problem is that the method
public void setSocketFactory(SocketFactory socketFactory)
in AbstractInvoker expects a SocketFactory instead of a String.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:37 a.m.
New subject: [JBoss JIRA] Updated: (JBREM-1014) Support injection of socket factory class name into AbstractInvoker
[
https://jira.jboss.org/jira/browse/JBREM-1014?page=com.atlassian.jira.plu...
]
Ron Sigal updated JBREM-1014:
-----------------------------
Issue Type: Bug (was: Feature Request)
Support injection of socket factory class name into AbstractInvoker
-------------------------------------------------------------------
Key: JBREM-1014
URL: https://jira.jboss.org/jira/browse/JBREM-1014
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 2.2.2.SP8
Reporter: Ron Sigal
Assignee: Ron Sigal
Fix For: 2.2.2.SP9
It is intended that org.jboss.remoting.AbstractInvoker can accept the class name of a
SocketFactory, using the parameter org.jboss.remoting.Remoting.SOCKET_FACTORY_NAME (actual
value "socketFactory"). Unfortunately, the parameter name
"socketFactory" conflicts with the bean property of the same name. In
particular, the problem is that the method
public void setSocketFactory(SocketFactory socketFactory)
in AbstractInvoker expects a SocketFactory instead of a String.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:53 a.m.
New subject: [JBoss JIRA] Commented: (JBREM-1014) Support injection of socket factory class name into AbstractInvoker
[
https://jira.jboss.org/jira/browse/JBREM-1014?page=com.atlassian.jira.plu...
]
Galder Zamarreno commented on JBREM-1014:
-----------------------------------------
Ron, that won't work either because the configuration map on the
client side is empty as a result of EJB3 not passing down the wire the
configuration map. Hence, no matter what you add to the map, it's
unusable by the client..
If EJB3 had passed the configuration map down to the client, you
wouldn't even have needed the SOCKET_FACTORY_CLASS_NAME
because createSocketFactory() in AbstractInvoker would treat
SOCKET_FACTORY_NAME as class name.
The 2nd option is setting the socket factory class name via introspection
by adding a AbstractInvoker.setSocketFactoryClassName(String socketFactoryClassName)
to take a String but this is API addition. The reason I'm asking for this is
because we can configure the client bind url like this:
sslsocket://${jboss.bind.address}:3853/?socketFactory=com.acme.security.TrustEveryoneSSLSocketFactory
However, this won't work because for PropertyEditors, there's not an
equivalent AbstractInvoker.setSocketFactory(String socketFactory) , hence,
we need something like AbstractInvoker.setSocketFactoryClassName(String
socketFactoryClassName)
and then configure the client bind url like this:
sslsocket://${jboss.bind.address}:3853/?socketFactoryClassName=com.acme.security.TrustEveryoneSSLSocketFactory
It's either that, or pass the Configuration object down the wire to EJB3 clients
which would break if not coded properly.
Support injection of socket factory class name into AbstractInvoker
-------------------------------------------------------------------
Key: JBREM-1014
URL: https://jira.jboss.org/jira/browse/JBREM-1014
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 2.2.2.SP8
Reporter: Ron Sigal
Assignee: Ron Sigal
Fix For: 2.2.2.SP9
It is intended that org.jboss.remoting.AbstractInvoker can accept the class name of a
SocketFactory, using the parameter org.jboss.remoting.Remoting.SOCKET_FACTORY_NAME (actual
value "socketFactory"). Unfortunately, the parameter name
"socketFactory" conflicts with the bean property of the same name. In
particular, the problem is that the method
public void setSocketFactory(SocketFactory socketFactory)
in AbstractInvoker expects a SocketFactory instead of a String.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:06 p.m.
New subject: [JBoss JIRA] Commented: (JBREM-1014) Support injection of socket factory class name into AbstractInvoker
[
https://jira.jboss.org/jira/browse/JBREM-1014?page=com.atlassian.jira.plu...
]
Ron Sigal commented on JBREM-1014:
----------------------------------
I think I see the underlying problem. Originally, *all* parameters were configured
through the InvokerLocator, and then we added configuration maps. However, there's an
anomaly in org.jboss.remoting.RemoteClientInvoker(), which passes both the InvokerLocator
and configuration map to the AbstractInvoker constructor (which combines them to create a
single configuration map), but it then calls AbstractInvoker.createSocketFactory() passing
just the original configuration map, instead of the combined map. Changing
RemoteClientInvoker() to use the combined map doesn't seem like a good idea in a minor
release, but I've got a compromise. It looks for the parameter
"socketFactoryClassName" in the InvokerLocator and adds it (if it exists) to the
configuration map. This change shouldn't affect any existing code since
"socketFactoryClassName" is a new parameter.
Unit tests:
* org.jboss.test.remoting.transport.bisocket.SocketFactoryClassNameTestCase
* org.jboss.test.remoting.transport.http.SocketFactoryClassNameTestCase
* org.jboss.test.remoting.transport.rmi.SocketFactoryClassNameTestCase
* org.jboss.test.remoting.transport.socket.SocketFactoryClassNameTestCase
* org.jboss.test.remoting.transport.bisocket.ssl.SSLSocketFactoryClassNameTestCase
* org.jboss.test.remoting.transport.http.ssl.SSLSocketFactoryClassNameTestCase
* org.jboss.test.remoting.transport.rmi.ssl.SSLSocketFactoryClassNameTestCase
* org.jboss.test.remoting.transport.socket.ssl.SSLSocketFactoryClassNameTestCase
Support injection of socket factory class name into AbstractInvoker
-------------------------------------------------------------------
Key: JBREM-1014
URL: https://jira.jboss.org/jira/browse/JBREM-1014
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 2.2.2.SP8
Reporter: Ron Sigal
Assignee: Ron Sigal
Fix For: 2.2.2.SP9
It is intended that org.jboss.remoting.AbstractInvoker can accept the class name of a
SocketFactory, using the parameter org.jboss.remoting.Remoting.SOCKET_FACTORY_NAME (actual
value "socketFactory"). Unfortunately, the parameter name
"socketFactory" conflicts with the bean property of the same name. In
particular, the problem is that the method
public void setSocketFactory(SocketFactory socketFactory)
in AbstractInvoker expects a SocketFactory instead of a String.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:31 a.m.
New subject: [JBoss JIRA] Commented: (JBREM-1014) Support injection of socket factory class name into AbstractInvoker
[
https://jira.jboss.org/jira/browse/JBREM-1014?page=com.atlassian.jira.plu...
]
Galder Zamarreno commented on JBREM-1014:
-----------------------------------------
Ron, got example working thanks to the latest fix. Thanks ever
so much for working on this and helping me out :).
I'll get a how-to done and see if we can get this included in these
coming CPs.
Support injection of socket factory class name into AbstractInvoker
-------------------------------------------------------------------
Key: JBREM-1014
URL: https://jira.jboss.org/jira/browse/JBREM-1014
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 2.2.2.SP8
Reporter: Ron Sigal
Assignee: Ron Sigal
Fix For: 2.2.2.SP9
It is intended that org.jboss.remoting.AbstractInvoker can accept the class name of a
SocketFactory, using the parameter org.jboss.remoting.Remoting.SOCKET_FACTORY_NAME (actual
value "socketFactory"). Unfortunately, the parameter name
"socketFactory" conflicts with the bean property of the same name. In
particular, the problem is that the method
public void setSocketFactory(SocketFactory socketFactory)
in AbstractInvoker expects a SocketFactory instead of a String.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:02 p.m.
New subject: [JBoss JIRA] Commented: (JBREM-1014) Support injection of socket factory class name into AbstractInvoker
[
https://jira.jboss.org/jira/browse/JBREM-1014?page=com.atlassian.jira.plu...
]
Ron Sigal commented on JBREM-1014:
----------------------------------
Excellent. Che felice sono!
Support injection of socket factory class name into AbstractInvoker
-------------------------------------------------------------------
Key: JBREM-1014
URL: https://jira.jboss.org/jira/browse/JBREM-1014
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 2.2.2.SP8
Reporter: Ron Sigal
Assignee: Ron Sigal
Fix For: 2.2.2.SP9
It is intended that org.jboss.remoting.AbstractInvoker can accept the class name of a
SocketFactory, using the parameter org.jboss.remoting.Remoting.SOCKET_FACTORY_NAME (actual
value "socketFactory"). Unfortunately, the parameter name
"socketFactory" conflicts with the bean property of the same name. In
particular, the problem is that the method
public void setSocketFactory(SocketFactory socketFactory)
in AbstractInvoker expects a SocketFactory instead of a String.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:56 p.m.
New subject: [JBoss JIRA] Closed: (JBREM-1014) Support injection of socket factory class name into AbstractInvoker
[
https://jira.jboss.org/jira/browse/JBREM-1014?page=com.atlassian.jira.plu...
]
Ron Sigal closed JBREM-1014.
----------------------------
Resolution: Done
Support injection of socket factory class name into AbstractInvoker
-------------------------------------------------------------------
Key: JBREM-1014
URL: https://jira.jboss.org/jira/browse/JBREM-1014
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 2.2.2.SP8
Reporter: Ron Sigal
Assignee: Ron Sigal
Fix For: 2.2.2.SP9
It is intended that org.jboss.remoting.AbstractInvoker can accept the class name of a
SocketFactory, using the parameter org.jboss.remoting.Remoting.SOCKET_FACTORY_NAME (actual
value "socketFactory"). Unfortunately, the parameter name
"socketFactory" conflicts with the bean property of the same name. In
particular, the problem is that the method
public void setSocketFactory(SocketFactory socketFactory)
in AbstractInvoker expects a SocketFactory instead of a String.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5953
days inactive
5961
days old
8 comments
2 participants
participants (2)
-
Galder Zamarreno (JIRA) -
Ron Sigal (JIRA)