[JBoss JIRA] (JGRP-2138) Request.viewChange() implementations should not use View.getMembers()
- First Post
- Replies
- Stats
-
Go to
- ----- 2024 -----
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2007 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2006 -----
- December
- November
- October
- September
- August
- July
[
https://issues.jboss.org/browse/JGRP-2138?page=com.atlassian.jira.plugin....
]
Dan Berindei commented on JGRP-2138:
------------------------------------
I don't think you really need to implement {{List<Address>}}, but if you do
please keep {{getMembers()}} and return {{this}}.
For me either variation of {{getMembers()}} is fine as long as {{Request}} isn't using
it. We're only calling {{getMembers()}} in Infinispan when we get a new view, same as
most protocols.
Request.viewChange() implementations should not use
View.getMembers()
---------------------------------------------------------------------
Key: JGRP-2138
URL: https://issues.jboss.org/browse/JGRP-2138
Project: JGroups
Issue Type: Bug
Reporter: Dan Berindei
Assignee: Bela Ban
Priority: Minor
Fix For: 3.6.12, 4.0
{{Request.viewChange()}} is called once for every request, and {{View.getMembers()}}
allocates 2 (small) objects. Both {{UnicastRequest}} and {{GroupRequest}} could use
{{View.containsMember()}} instead.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
2893
days inactive
2893
days old
0 comments
1 participants
tags (0)
participants (1)
-
Dan Berindei (JIRA)