7:01 a.m.
Action URL retained by client
-----------------------------
Key: JBPORTAL-2248
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2248
Project: JBoss Portal
Issue Type: Bug
Security Level: Public (Everyone can see)
Reporter: Dan Krieger
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:09 a.m.
New subject: [JBoss JIRA] Updated: (JBPORTAL-2248) Action URL retained by client
[
https://jira.jboss.org/jira/browse/JBPORTAL-2248?page=com.atlassian.jira....
]
Dan Krieger updated JBPORTAL-2248:
----------------------------------
Affects Version/s: 2.7.0 Final
Description:
When a client navigates to an actionURL, the action is performed and no client-side
redirect is sent to remove the actionURL as the active page. This is showing itself as an
issue with user's enjoying the use of the refresh button.
The URL pattern used in 2.6.X wasn't the best because render parameters often could
potentially contain huge amounts of data and cause overly long URLs (causing 414 errors).
But at least it didn't contain the action URL which now allows a user to redo an
action or force a re-POST on a refresh.
Not sure if this is a bug, intended feature, or how to classify it.
Action URL retained by client
-----------------------------
Key: JBPORTAL-2248
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2248
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 2.7.0 Final
Reporter: Dan Krieger
When a client navigates to an actionURL, the action is performed and no client-side
redirect is sent to remove the actionURL as the active page. This is showing itself as an
issue with user's enjoying the use of the refresh button.
The URL pattern used in 2.6.X wasn't the best because render parameters often could
potentially contain huge amounts of data and cause overly long URLs (causing 414 errors).
But at least it didn't contain the action URL which now allows a user to redo an
action or force a re-POST on a refresh.
Not sure if this is a bug, intended feature, or how to classify it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:07 a.m.
New subject: [JBoss JIRA] Updated: (JBPORTAL-2248) Action URL retained by client
[
https://jira.jboss.org/jira/browse/JBPORTAL-2248?page=com.atlassian.jira....
]
Thomas Heute updated JBPORTAL-2248:
-----------------------------------
Component/s: Portal Core
Fix Version/s: 2.7.1 Final
Action URL retained by client
-----------------------------
Key: JBPORTAL-2248
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2248
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Portal Core
Affects Versions: 2.7.0 Final
Reporter: Dan Krieger
Fix For: 2.7.1 Final
When a client navigates to an actionURL, the action is performed and no client-side
redirect is sent to remove the actionURL as the active page. This is showing itself as an
issue with user's enjoying the use of the refresh button.
The URL pattern used in 2.6.X wasn't the best because render parameters often could
potentially contain huge amounts of data and cause overly long URLs (causing 414 errors).
But at least it didn't contain the action URL which now allows a user to redo an
action or force a re-POST on a refresh.
Not sure if this is a bug, intended feature, or how to classify it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:09 a.m.
New subject: [JBoss JIRA] Assigned: (JBPORTAL-2248) Action URL retained by client
[
https://jira.jboss.org/jira/browse/JBPORTAL-2248?page=com.atlassian.jira....
]
Thomas Heute reassigned JBPORTAL-2248:
--------------------------------------
Assignee: Thomas Heute
Action URL retained by client
-----------------------------
Key: JBPORTAL-2248
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2248
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Portal Core
Affects Versions: 2.7.0 Final
Reporter: Dan Krieger
Assignee: Thomas Heute
Fix For: 2.7.1 Final
When a client navigates to an actionURL, the action is performed and no client-side
redirect is sent to remove the actionURL as the active page. This is showing itself as an
issue with user's enjoying the use of the refresh button.
The URL pattern used in 2.6.X wasn't the best because render parameters often could
potentially contain huge amounts of data and cause overly long URLs (causing 414 errors).
But at least it didn't contain the action URL which now allows a user to redo an
action or force a re-POST on a refresh.
Not sure if this is a bug, intended feature, or how to classify it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:18 p.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-2248) Action URL retained by client
[
https://jira.jboss.org/jira/browse/JBPORTAL-2248?page=com.atlassian.jira....
]
Thomas Heute commented on JBPORTAL-2248:
----------------------------------------
Would require more testing but this should be fixed (I also need to check resource
serving)
Action URL retained by client
-----------------------------
Key: JBPORTAL-2248
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2248
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Portal Core
Affects Versions: 2.7.0 Final
Reporter: Dan Krieger
Assignee: Thomas Heute
Fix For: 2.7.1 Final
When a client navigates to an actionURL, the action is performed and no client-side
redirect is sent to remove the actionURL as the active page. This is showing itself as an
issue with user's enjoying the use of the refresh button.
The URL pattern used in 2.6.X wasn't the best because render parameters often could
potentially contain huge amounts of data and cause overly long URLs (causing 414 errors).
But at least it didn't contain the action URL which now allows a user to redo an
action or force a re-POST on a refresh.
Not sure if this is a bug, intended feature, or how to classify it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:25 p.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-2248) Action URL retained by client
[
https://jira.jboss.org/jira/browse/JBPORTAL-2248?page=com.atlassian.jira....
]
Dan Krieger commented on JBPORTAL-2248:
---------------------------------------
URL's are fixed but public render parameters no longer work. After an action all
render parameters are removed even if explicitly set.
Action URL retained by client
-----------------------------
Key: JBPORTAL-2248
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2248
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Portal Core
Affects Versions: 2.7.0 Final
Reporter: Dan Krieger
Assignee: Thomas Heute
Fix For: 2.7.1 Final
When a client navigates to an actionURL, the action is performed and no client-side
redirect is sent to remove the actionURL as the active page. This is showing itself as an
issue with user's enjoying the use of the refresh button.
The URL pattern used in 2.6.X wasn't the best because render parameters often could
potentially contain huge amounts of data and cause overly long URLs (causing 414 errors).
But at least it didn't contain the action URL which now allows a user to redo an
action or force a re-POST on a refresh.
Not sure if this is a bug, intended feature, or how to classify it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:16 a.m.
New subject: [JBoss JIRA] Work started: (JBPORTAL-2248) Action URL retained by client
[
https://jira.jboss.org/jira/browse/JBPORTAL-2248?page=com.atlassian.jira....
]
Work on JBPORTAL-2248 started by Thomas Heute.
Action URL retained by client
-----------------------------
Key: JBPORTAL-2248
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2248
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Portal Core
Affects Versions: 2.7.0 Final
Reporter: Dan Krieger
Assignee: Thomas Heute
Fix For: 2.7.1 Final
When a client navigates to an actionURL, the action is performed and no client-side
redirect is sent to remove the actionURL as the active page. This is showing itself as an
issue with user's enjoying the use of the refresh button.
The URL pattern used in 2.6.X wasn't the best because render parameters often could
potentially contain huge amounts of data and cause overly long URLs (causing 414 errors).
But at least it didn't contain the action URL which now allows a user to redo an
action or force a re-POST on a refresh.
Not sure if this is a bug, intended feature, or how to classify it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:25 a.m.
New subject: [JBoss JIRA] Work stopped: (JBPORTAL-2248) Action URL retained by client
[
https://jira.jboss.org/jira/browse/JBPORTAL-2248?page=com.atlassian.jira....
]
Work on JBPORTAL-2248 stopped by Thomas Heute.
Action URL retained by client
-----------------------------
Key: JBPORTAL-2248
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2248
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Portal Core
Affects Versions: 2.7.0 Final
Reporter: Dan Krieger
Assignee: Thomas Heute
Fix For: 2.7.1 Final
When a client navigates to an actionURL, the action is performed and no client-side
redirect is sent to remove the actionURL as the active page. This is showing itself as an
issue with user's enjoying the use of the refresh button.
The URL pattern used in 2.6.X wasn't the best because render parameters often could
potentially contain huge amounts of data and cause overly long URLs (causing 414 errors).
But at least it didn't contain the action URL which now allows a user to redo an
action or force a re-POST on a refresh.
Not sure if this is a bug, intended feature, or how to classify it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:27 a.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-2248) Action URL retained by client
[
https://jira.jboss.org/jira/browse/JBPORTAL-2248?page=com.atlassian.jira....
]
Thomas Heute commented on JBPORTAL-2248:
----------------------------------------
I'm commited some progress if you want to try out and report any issue you may find
related to this.
Thanks.
Action URL retained by client
-----------------------------
Key: JBPORTAL-2248
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2248
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Portal Core
Affects Versions: 2.7.0 Final
Reporter: Dan Krieger
Assignee: Thomas Heute
Fix For: 2.7.1 Final
When a client navigates to an actionURL, the action is performed and no client-side
redirect is sent to remove the actionURL as the active page. This is showing itself as an
issue with user's enjoying the use of the refresh button.
The URL pattern used in 2.6.X wasn't the best because render parameters often could
potentially contain huge amounts of data and cause overly long URLs (causing 414 errors).
But at least it didn't contain the action URL which now allows a user to redo an
action or force a re-POST on a refresh.
Not sure if this is a bug, intended feature, or how to classify it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:13 a.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-2248) Action URL retained by client
[
https://jira.jboss.org/jira/browse/JBPORTAL-2248?page=com.atlassian.jira....
]
Dan Krieger commented on JBPORTAL-2248:
---------------------------------------
Still seems to want to remove the public render parameters during an action.
Got this also:
java.lang.IllegalArgumentException: Array must not be zero length
org.jboss.portal.common.util.ParameterMap$ValueConverter.getInternal(ParameterMap.java:469)
org.jboss.portal.common.util.ParameterMap$ValueConverter.getInternal(ParameterMap.java:443)
org.jboss.portal.common.util.AbstractTypedMap$Converter$4.transform(AbstractTypedMap.java:140)
org.jboss.portal.common.util.AbstractTypedMap.put(AbstractTypedMap.java:242)
org.jboss.portal.common.util.ParameterMap.setValues(ParameterMap.java:282)
org.jboss.portal.core.portlet.PortletRequestEncoder.configure(PortletRequestEncoder.java:208)
org.jboss.portal.core.portlet.PortletRequestEncoder.encodeRender(PortletRequestEncoder.java:169)
org.jboss.portal.core.model.portal.PortalObjectURLFactory.doMapping(PortalObjectURLFactory.java:168)
org.jboss.portal.core.controller.command.mapper.DelegatingURLFactoryService.doMapping(DelegatingURLFactoryService.java:68)
org.jboss.portal.core.controller.ControllerContext.renderURL(ControllerContext.java:171)
org.jboss.portal.core.controller.classic.ClassicResponseHandler.processCommandResponse(ClassicResponseHandler.java:62)
org.jboss.portal.core.controller.handler.ResponseHandlerSelector.processCommandResponse(ResponseHandlerSelector.java:70)
org.jboss.portal.core.controller.Controller.processCommandResponse(Controller.java:315)
org.jboss.portal.core.controller.Controller.processCommand(Controller.java:303)
org.jboss.portal.core.controller.Controller.handle(Controller.java:261)
org.jboss.portal.server.RequestControllerDispatcher.invoke(RequestControllerDispatcher.java:51)
org.jboss.portal.common.invocation.Invocation.invokeNext(Invocation.java:131)
org.jboss.portal.server.aspects.server.ContentTypeInterceptor.invoke(ContentTypeInterceptor.java:68)
org.jboss.portal.server.ServerInterceptor.invoke(ServerInterceptor.java:38)
org.jboss.portal.common.invocation.Invocation.invokeNext(Invocation.java:115)
org.jboss.portal.core.aspects.server.PortalContextPathInterceptor.invoke(PortalContextPathInterceptor.java:45)
org.jboss.portal.server.ServerInterceptor.invoke(ServerInterceptor.java:38)
org.jboss.portal.common.invocation.Invocation.invokeNext(Invocation.java:115)
org.jboss.portal.core.aspects.server.LocaleInterceptor.invoke(LocaleInterceptor.java:96)
org.jboss.portal.server.ServerInterceptor.invoke(ServerInterceptor.java:38)
org.jboss.portal.common.invocation.Invocation.invokeNext(Invocation.java:115)
org.jboss.portal.core.aspects.server.UserInterceptor.invoke(UserInterceptor.java:193)
org.jboss.portal.server.ServerInterceptor.invoke(ServerInterceptor.java:38)
org.jboss.portal.common.invocation.Invocation.invokeNext(Invocation.java:115)
org.jboss.portal.server.aspects.server.SignOutInterceptor.invoke(SignOutInterceptor.java:98)
org.jboss.portal.server.ServerInterceptor.invoke(ServerInterceptor.java:38)
org.jboss.portal.common.invocation.Invocation.invokeNext(Invocation.java:115)
org.jboss.portal.core.impl.api.user.UserEventBridgeTriggerInterceptor.invoke(UserEventBridgeTriggerInterceptor.java:65)
org.jboss.portal.server.ServerInterceptor.invoke(ServerInterceptor.java:38)
org.jboss.portal.common.invocation.Invocation.invokeNext(Invocation.java:115)
org.jboss.portal.core.aspects.server.IdentityCacheInterceptor.invoke(IdentityCacheInterceptor.java:68)
org.jboss.portal.server.ServerInterceptor.invoke(ServerInterceptor.java:38)
org.jboss.portal.common.invocation.Invocation.invokeNext(Invocation.java:115)
org.jboss.portal.core.aspects.server.TransactionInterceptor.org$jboss$portal$core$aspects$server$TransactionInterceptor$invoke$aop(TransactionInterceptor.java:49)
org.jboss.portal.core.aspects.server.TransactionInterceptor$invoke_N5143606530999904530.invokeNext(TransactionInterceptor$invoke_N5143606530999904530.java)
org.jboss.aspects.tx.TxPolicy.invokeInOurTx(TxPolicy.java:79)
org.jboss.aspects.tx.TxInterceptor$RequiresNew.invoke(TxInterceptor.java:253)
org.jboss.portal.core.aspects.server.TransactionInterceptor$invoke_N5143606530999904530.invokeNext(TransactionInterceptor$invoke_N5143606530999904530.java)
org.jboss.aspects.tx.TxPolicy.invokeInOurTx(TxPolicy.java:79)
org.jboss.aspects.tx.TxInterceptor$RequiresNew.invoke(TxInterceptor.java:262)
org.jboss.portal.core.aspects.server.TransactionInterceptor$invoke_N5143606530999904530.invokeNext(TransactionInterceptor$invoke_N5143606530999904530.java)
org.jboss.portal.core.aspects.server.TransactionInterceptor.invoke(TransactionInterceptor.java)
org.jboss.portal.server.ServerInterceptor.invoke(ServerInterceptor.java:38)
org.jboss.portal.common.invocation.Invocation.invokeNext(Invocation.java:115)
org.jboss.portal.server.aspects.LockInterceptor$InternalLock.invoke(LockInterceptor.java:69)
org.jboss.portal.server.aspects.LockInterceptor.invoke(LockInterceptor.java:130)
org.jboss.portal.common.invocation.Invocation.invokeNext(Invocation.java:115)
org.jboss.portal.common.invocation.Invocation.invoke(Invocation.java:157)
org.jboss.portal.server.servlet.PortalServlet.service(PortalServlet.java:252)
javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
org.jboss.web.tomcat.filters.ReplyHeaderFilter.doFilter(ReplyHeaderFilter.java:96)
For reference here is my simple block of action code that seems to be causing the
trouble:
String field = req.getParameter("field");
if(field != null)
{
String[] fields;
res.removePublicRenderParameter(field);
if((fields = req.getPrivateParameterMap().get(field)) != null)
{
res.setRenderParameter(field, fields);
}
}
It may be that it working previously was a fluke, but essentially its part of a set of
portlets for filtering content on a main portlet. The field passed in is a public render
parameter (PRP) to be replaced. So if I have PRP a, b, and c set, and my action url is
<portleturl>?field=a&a=newvalue&action=1, the action should leave values for
b and c alone while setting the value of a to 'newvalue'. But b and c are
seemingly removed as well.
That huge error came up when trying to clear a PRP without setting a new one:
?field=a&action=1
My guess is there's trouble around removePublicRenderParameter
I apologize if this doesn't make sense, but hopefully it should help.
Action URL retained by client
-----------------------------
Key: JBPORTAL-2248
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2248
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Portal Core
Affects Versions: 2.7.0 Final
Reporter: Dan Krieger
Assignee: Thomas Heute
Fix For: 2.7.1 Final
When a client navigates to an actionURL, the action is performed and no client-side
redirect is sent to remove the actionURL as the active page. This is showing itself as an
issue with user's enjoying the use of the refresh button.
The URL pattern used in 2.6.X wasn't the best because render parameters often could
potentially contain huge amounts of data and cause overly long URLs (causing 414 errors).
But at least it didn't contain the action URL which now allows a user to redo an
action or force a re-POST on a refresh.
Not sure if this is a bug, intended feature, or how to classify it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:37 p.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-2248) Action URL retained by client
[
https://jira.jboss.org/jira/browse/JBPORTAL-2248?page=com.atlassian.jira....
]
Thomas Heute commented on JBPORTAL-2248:
----------------------------------------
Dan, thanks for the report, i've commited some more changes, but haven't got the
time to test that, i will test after Devoxx which happens next week.
Action URL retained by client
-----------------------------
Key: JBPORTAL-2248
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2248
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Portal Core
Affects Versions: 2.7.0 Final
Reporter: Dan Krieger
Assignee: Thomas Heute
Fix For: 2.7.1 Final
When a client navigates to an actionURL, the action is performed and no client-side
redirect is sent to remove the actionURL as the active page. This is showing itself as an
issue with user's enjoying the use of the refresh button.
The URL pattern used in 2.6.X wasn't the best because render parameters often could
potentially contain huge amounts of data and cause overly long URLs (causing 414 errors).
But at least it didn't contain the action URL which now allows a user to redo an
action or force a re-POST on a refresh.
Not sure if this is a bug, intended feature, or how to classify it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:59 p.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-2248) Action URL retained by client
[
https://jira.jboss.org/jira/browse/JBPORTAL-2248?page=com.atlassian.jira....
]
Dan Krieger commented on JBPORTAL-2248:
---------------------------------------
PRP's now persist, URLs look good, but that "Array must not be zero length"
error still comes up when dealing with removePublicRenderParameter and not setting a new
value. It may be that the array just needs to be removed altogether after remove, rather
than cleared. If I get a chance I can dive into the code and hunt down and attempt a
fix.
If I haven't mentioned it previously, thanks again for your attention on this one.
Action URL retained by client
-----------------------------
Key: JBPORTAL-2248
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2248
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Portal Core
Affects Versions: 2.7.0 Final
Reporter: Dan Krieger
Assignee: Thomas Heute
Fix For: 2.7.1 Final
When a client navigates to an actionURL, the action is performed and no client-side
redirect is sent to remove the actionURL as the active page. This is showing itself as an
issue with user's enjoying the use of the refresh button.
The URL pattern used in 2.6.X wasn't the best because render parameters often could
potentially contain huge amounts of data and cause overly long URLs (causing 414 errors).
But at least it didn't contain the action URL which now allows a user to redo an
action or force a re-POST on a refresh.
Not sure if this is a bug, intended feature, or how to classify it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:08 p.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-2248) Action URL retained by client
[
https://jira.jboss.org/jira/browse/JBPORTAL-2248?page=com.atlassian.jira....
]
Thomas Heute commented on JBPORTAL-2248:
----------------------------------------
I've used the following portlet to play around and didn't meet this exception:
https://svn.jboss.org/repos/portal/branches/JBoss_Portal_Branch_2_7/core-...
I'll look at it again when I'll have some time.
Thanks for the fast answers
Action URL retained by client
-----------------------------
Key: JBPORTAL-2248
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2248
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Portal Core
Affects Versions: 2.7.0 Final
Reporter: Dan Krieger
Assignee: Thomas Heute
Fix For: 2.7.1 Final
When a client navigates to an actionURL, the action is performed and no client-side
redirect is sent to remove the actionURL as the active page. This is showing itself as an
issue with user's enjoying the use of the refresh button.
The URL pattern used in 2.6.X wasn't the best because render parameters often could
potentially contain huge amounts of data and cause overly long URLs (causing 414 errors).
But at least it didn't contain the action URL which now allows a user to redo an
action or force a re-POST on a refresh.
Not sure if this is a bug, intended feature, or how to classify it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:21 p.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-2248) Action URL retained by client
[
https://jira.jboss.org/jira/browse/JBPORTAL-2248?page=com.atlassian.jira....
]
Thomas Heute commented on JBPORTAL-2248:
----------------------------------------
Sorry, was easy to reproduce with the example i was playing with...
Looking at it
Action URL retained by client
-----------------------------
Key: JBPORTAL-2248
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2248
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Portal Core
Affects Versions: 2.7.0 Final
Reporter: Dan Krieger
Assignee: Thomas Heute
Fix For: 2.7.1 Final
When a client navigates to an actionURL, the action is performed and no client-side
redirect is sent to remove the actionURL as the active page. This is showing itself as an
issue with user's enjoying the use of the refresh button.
The URL pattern used in 2.6.X wasn't the best because render parameters often could
potentially contain huge amounts of data and cause overly long URLs (causing 414 errors).
But at least it didn't contain the action URL which now allows a user to redo an
action or force a re-POST on a refresh.
Not sure if this is a bug, intended feature, or how to classify it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:27 p.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-2248) Action URL retained by client
[
https://jira.jboss.org/jira/browse/JBPORTAL-2248?page=com.atlassian.jira....
]
Dan Krieger commented on JBPORTAL-2248:
---------------------------------------
I dropped an instance of that portlet onto my page. Set the public parameters from my
other portlets. When I remove the value from the textbox in the sample portlet and hit
the update button it throws the error again (because it calls
removePublicRenderParameter). If you aren't having that problem it may be that
I'm missing some minor change in any of my jar files in my lib directory, but I've
just updated them all with the latest 2.7 branch build. I'll try a clean and rebuild
and see where that gets me.
Action URL retained by client
-----------------------------
Key: JBPORTAL-2248
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2248
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Portal Core
Affects Versions: 2.7.0 Final
Reporter: Dan Krieger
Assignee: Thomas Heute
Fix For: 2.7.1 Final
When a client navigates to an actionURL, the action is performed and no client-side
redirect is sent to remove the actionURL as the active page. This is showing itself as an
issue with user's enjoying the use of the refresh button.
The URL pattern used in 2.6.X wasn't the best because render parameters often could
potentially contain huge amounts of data and cause overly long URLs (causing 414 errors).
But at least it didn't contain the action URL which now allows a user to redo an
action or force a re-POST on a refresh.
Not sure if this is a bug, intended feature, or how to classify it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:44 p.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-2248) Action URL retained by client
[
https://jira.jboss.org/jira/browse/JBPORTAL-2248?page=com.atlassian.jira....
]
Dan Krieger commented on JBPORTAL-2248:
---------------------------------------
Looking in the portlet module (trunk):
https://anonsvn.jboss.org/repos/portal/modules/portlet/trunk/portlet/src/...
I have very little idea how everything comes together because I'm mostly just grepping
my way around, but at line 232 where it handles the "removed" render parameters
it puts in an empty Strings array, rather than removing it from the snapshot map. So it
may or may not be fixed by changing
snapshot.put(removal, EMPTY_STRINGS);
to
snapshot.remove(removal);
I can't seem to get maven to cooperate at the moment otherwise I'd test it out
myself.
Action URL retained by client
-----------------------------
Key: JBPORTAL-2248
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2248
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Portal Core
Affects Versions: 2.7.0 Final
Reporter: Dan Krieger
Assignee: Thomas Heute
Fix For: 2.7.1 Final
When a client navigates to an actionURL, the action is performed and no client-side
redirect is sent to remove the actionURL as the active page. This is showing itself as an
issue with user's enjoying the use of the refresh button.
The URL pattern used in 2.6.X wasn't the best because render parameters often could
potentially contain huge amounts of data and cause overly long URLs (causing 414 errors).
But at least it didn't contain the action URL which now allows a user to redo an
action or force a re-POST on a refresh.
Not sure if this is a bug, intended feature, or how to classify it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:14 p.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-2248) Action URL retained by client
[
https://jira.jboss.org/jira/browse/JBPORTAL-2248?page=com.atlassian.jira....
]
Thomas Heute commented on JBPORTAL-2248:
----------------------------------------
I've commited some more changes if you want to give it a try
Action URL retained by client
-----------------------------
Key: JBPORTAL-2248
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2248
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Portal Core
Affects Versions: 2.7.0 Final
Reporter: Dan Krieger
Assignee: Thomas Heute
Fix For: 2.7.1 Final
When a client navigates to an actionURL, the action is performed and no client-side
redirect is sent to remove the actionURL as the active page. This is showing itself as an
issue with user's enjoying the use of the refresh button.
The URL pattern used in 2.6.X wasn't the best because render parameters often could
potentially contain huge amounts of data and cause overly long URLs (causing 414 errors).
But at least it didn't contain the action URL which now allows a user to redo an
action or force a re-POST on a refresh.
Not sure if this is a bug, intended feature, or how to classify it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:14 p.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-2248) Action URL retained by client
[
https://jira.jboss.org/jira/browse/JBPORTAL-2248?page=com.atlassian.jira....
]
Dan Krieger commented on JBPORTAL-2248:
---------------------------------------
Latest change works just fine. Thank you.
Action URL retained by client
-----------------------------
Key: JBPORTAL-2248
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2248
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Portal Core
Affects Versions: 2.7.0 Final
Reporter: Dan Krieger
Assignee: Thomas Heute
Fix For: 2.7.1 Final
When a client navigates to an actionURL, the action is performed and no client-side
redirect is sent to remove the actionURL as the active page. This is showing itself as an
issue with user's enjoying the use of the refresh button.
The URL pattern used in 2.6.X wasn't the best because render parameters often could
potentially contain huge amounts of data and cause overly long URLs (causing 414 errors).
But at least it didn't contain the action URL which now allows a user to redo an
action or force a re-POST on a refresh.
Not sure if this is a bug, intended feature, or how to classify it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:51 p.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-2248) Action URL retained by client
[
https://jira.jboss.org/jira/browse/JBPORTAL-2248?page=com.atlassian.jira....
]
Thomas Heute commented on JBPORTAL-2248:
----------------------------------------
Thanks for the fast feedback !
I'm waiting on some more tests before closing that one.
Action URL retained by client
-----------------------------
Key: JBPORTAL-2248
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2248
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Portal Core
Affects Versions: 2.7.0 Final
Reporter: Dan Krieger
Assignee: Thomas Heute
Fix For: 2.7.1 Final
When a client navigates to an actionURL, the action is performed and no client-side
redirect is sent to remove the actionURL as the active page. This is showing itself as an
issue with user's enjoying the use of the refresh button.
The URL pattern used in 2.6.X wasn't the best because render parameters often could
potentially contain huge amounts of data and cause overly long URLs (causing 414 errors).
But at least it didn't contain the action URL which now allows a user to redo an
action or force a re-POST on a refresh.
Not sure if this is a bug, intended feature, or how to classify it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:37 a.m.
New subject: [JBoss JIRA] Resolved: (JBPORTAL-2248) Action URL retained by client
[
https://jira.jboss.org/jira/browse/JBPORTAL-2248?page=com.atlassian.jira....
]
Thomas Heute resolved JBPORTAL-2248.
------------------------------------
Resolution: Done
Action URL retained by client
-----------------------------
Key: JBPORTAL-2248
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2248
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Portal Core
Affects Versions: 2.7.0 Final
Reporter: Dan Krieger
Assignee: Thomas Heute
Fix For: 2.7.1 Final
When a client navigates to an actionURL, the action is performed and no client-side
redirect is sent to remove the actionURL as the active page. This is showing itself as an
issue with user's enjoying the use of the refresh button.
The URL pattern used in 2.6.X wasn't the best because render parameters often could
potentially contain huge amounts of data and cause overly long URLs (causing 414 errors).
But at least it didn't contain the action URL which now allows a user to redo an
action or force a re-POST on a refresh.
Not sure if this is a bug, intended feature, or how to classify it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5722
days inactive
5776
days old
19 comments
2 participants
participants (2)
-
Dan Krieger (JIRA) -
Thomas Heute (JIRA)