[ http://jira.jboss.com/jira/browse/JBRULES-1284?page=all ] Justin Wick updated JBRULES-1284: --------------------------------- Attachment: DroolsTest.zip A complete drools project with minimalist test code ready to be transplanted. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-1284?page=comments#action_12383469 ] Justin Wick commented on JBRULES-1284: -------------------------------------- IMHO, if this is known to be a "bad" thing to do, the compiler should at least throw a warning saying so, if not a straight-out error. Unless, of course, the runtime coercian could be made better. Is there a reason runtime type coercion cannot say that literals are whatever type they would be in Java? i.e. 50 is an integer, 50l is a long, 50.0 is a double, "50" is a String, etc? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-1284?page=all ] Edson Tirelli reassigned JBRULES-1284: -------------------------------------- Assignee: Edson Tirelli (was: Mark Proctor) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-1284?page=all ] Edson Tirelli reopened JBRULES-1284: ------------------------------------ There are still problems with alpha-hashing. Pretend you have 3 rules: rule "r1" when MyFact( object == "true" ) then end rule "r2" when MyFact( object == "Bob" ) then end rule "r2" when MyFact( object == 15 ) then end The above 3 rules will cause the engine to hash the values "true" and "Bob" as strings and 15 as an Integer. Although, if the object attribute is set to something like a Boolean object, the hashcode will never match with the String "true" hashcode and as so will never propagate. Not sure yet how to fix that... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-1284?page=comments#action_12386768 ] Michael Neale commented on JBRULES-1284: ---------------------------------------- As discussed - we should treat object fields as an unknown type, no hashing, just evaluate it as needed. This will mean a performance penalty, but the only other alternative is to defer any sort of hashing decision until we see an object, work out its type, but that is not rigorous. If people want to use Object, they have to understand, that there is price to pay at runtime. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-1284?page=all ] Mark Proctor reopened JBRULES-1284: ----------------------------------- This breaks CompositeObjectSinkAdapter because it isn't working for Strings: rule rule1 when context : Context( state == Context.START_UP ) guest : Guest( name == "mark", sex != Sex.M, hobby == "english") count : Count() then end rule rule2 when context : Context( state == Context.START_UP ) guest : Guest( name == "mark", sex != Sex.M, hobby == "french") count : Count() then end rule rule3 when context : Context( state == Context.START_UP ) guest : Guest( name == "mark", sex != Sex.M, hobby == "xxx") count : Count() then end rule rule4 when context : Context( state == Context.START_UP ) guest : Guest( name == "mark", sex != Sex.M, hobby == "yyy") count : Count() then end hobby should be hased but it's ObjectType is Object and thus it's not getting hashed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-1284?page=comments#action_12394910 ] Edson Tirelli commented on JBRULES-1284: ---------------------------------------- Mark, I don't understand how the engine can differentiate between a Java1.4 Enum and a regular Object type. We may be able to do something for Java 1.5 (trunk), but I don't see how to improve that for Java 1.4 (4.0.x branch). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira