[ http://jira.jboss.com/jira/browse/JBRULES-1262?page=all ] M H updated JBRULES-1262: ------------------------- Fix Version/s: 4.0.5 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-1262?page=comments#action_12399007 ] M H commented on JBRULES-1262: ------------------------------ For me the problem seems to be the following: i'm in class DefaultExpander.java private static final Pattern patternFinder = Pattern.compile( "\\((.*?)\\)" ); after the first two expand steps we have $p:Item(eval(title.isEqual("test")) which is correct. During the third step the patternfinder gets 'eval(title.isEqual("test"' and copies into variable constraint, and appends eval(id.isEqual("test") separeted with "," which is wrong. When eval is used, the patternFinder does not what is necessary. I'll tired the following: private static final Pattern patternFinderEval = Pattern.compile( "\\(.*(eval\\(.*\\)).*\\)" ); Line 250: if (expanded[lastPattern].trim().indexOf("eval") > -1) { m2 = patternFinderEval.matcher( expanded[lastPattern] ); } else { m2 = patternFinder.matcher( expanded[lastPattern] ); } it seems to work, but someone else has to check this ... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-1262?page=comments#action_12399397 ] Wouter Scheele commented on JBRULES-1262: ----------------------------------------- The pattern is matching the closing parentheses lazily, Pattern.compile( "\\((.*?)\\)" ), the problem would also disappear by changing the match to be greedy, Pattern.compile( "\\((.*)\\)" ). What is the reason for the lazy match? I cannot think of a usage that breaks using the greedy match. In the preceding example, shouldn't the pattern always be looking for the closing ) of the Item declaration? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-1262?page=comments#action_12399900 ] Edson Tirelli commented on JBRULES-1262: ---------------------------------------- The fix is good for your specific case, but does not address the general case where you can have more than one pattern per line, just to mention one example. So, my recommendation is that you can apply the fix to your local builds, but we need a general fix to include in the release. The fix for the general case requires quite some work. If no one volunteers, I will implement the fix as soon as possible, but still there are a lot of other tickets that take priority over this. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-1262?page=all ] Mark Proctor updated JBRULES-1262: ---------------------------------- Priority: Minor (was: Blocker) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBRULES-1262?page=com.atlassian.jira.p... ] Mark Proctor updated JBRULES-1262: ---------------------------------- Fix Version/s: 5.0.0.M2 (was: 5.0.0.M1) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBRULES-1262?page=com.atlassian.jira.p... ] Edson Tirelli updated JBRULES-1262: ----------------------------------- Fix Version/s: 5.0.0.CR1 (was: 5.0.0.M3) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBRULES-1262?page=com.atlassian.jira.p... ] Mark Proctor updated JBRULES-1262: ---------------------------------- Fix Version/s: 5.0.0.GA (was: 5.0.0.CR1) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBRULES-1262?page=com.atlassian.jira.p... ] Jörg Harm commented on JBRULES-1262: ------------------------------------ Changing in the class DefaultExpander final Matcher m2 = patternFinder.matcher( expanded[lastPattern] ); to final ParenthesesMatcher m2 = new ParenthesesMatcher( expanded[lastPattern] ); with the ParenthesesMatcher being private static class ParenthesesMatcher implements MatchResult { private final String input; int start = -1; int end = -1; public ParenthesesMatcher(String input) { this.input = input; } public boolean find() { start = input.indexOf('(', end + 1); if (start >= 0) { char stringDelimiter = 0; for (int i = start + 1, count = 1; i < input.length() && count > 0; i++) { if (stringDelimiter == 0) { final char ch = input.charAt(i); switch (ch) { case '(': count++; break; case ')': count--; if (count == 0) { end = i; } break; case '\'': case '"': stringDelimiter = ch; default: break; } } else { if (input.charAt(i) == stringDelimiter && input.charAt(i - 1) != '\\') { stringDelimiter = 0; } } } } return 0 <= start && start < end; } public int start() { return start(0); } public int start(int group) { checkMatched(); checkGroup(group); return startUnchecked(group); } private int startUnchecked(int group) { return start + group; } public int end() { return end(0); } public int end(int group) { checkMatched(); checkGroup(group); return endUnchecked(group); } private int endUnchecked(int group) { return end + 1 - group; } public String group() { return group(0); } public String group(int group) { checkMatched(); checkGroup(group); return input.substring(startUnchecked(group), endUnchecked(group)); } public int groupCount() { return 1; } private void checkGroup(int group) { if (group > groupCount()) { throw new IndexOutOfBoundsException("No group " + group); } } private void checkMatched() { if (0 > start || start >= end) { throw new IllegalStateException("No match found"); } } } "eval" can be used even if there parentheses in string literals somewhere. With this change the builds works and shows no failures. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira