5:39 p.m.
Look at SecurityConfig
----------------------
Key: SECURITY-244
URL: http://jira.jboss.com/jira/browse/SECURITY-244
Project: JBoss Security and Identity Management
Issue Type: Task
Security Level: Public (Everyone can see)
Reporter: Anil Saldhana
Assigned To: Anil Saldhana
Fix For: NO_VERSION
(11:25:04 AM) sguilhen: anil: ping... on SecurityConfig, there is a stack of
configurations... however the popLoginConfig() seems not right to me... it always
re-installs the same configuration over and over instead of installing the previous
configuration... can you take a look at it later?
(11:27:22 AM) sguilhen: anil: also, as I am going to inject XMLLoginConfig directly, I
need somehow to change this stack to keep the XMLLoginConfig instance instead of the
object name.... so I think I need to add an extra interface here to allow the use of
multiple login configurations.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:16 p.m.
New subject: [JBoss JIRA] Assigned: (SECURITY-244) Look at SecurityConfig
[
https://jira.jboss.org/jira/browse/SECURITY-244?page=com.atlassian.jira.p...
]
Anil Saldhana reassigned SECURITY-244:
--------------------------------------
Assignee: Stefan Guilhen (was: Anil Saldhana)
Is this still an issue?
Look at SecurityConfig
----------------------
Key: SECURITY-244
URL: https://jira.jboss.org/jira/browse/SECURITY-244
Project: JBoss Security and Identity Management
Issue Type: Task
Security Level: Public(Everyone can see)
Reporter: Anil Saldhana
Assignee: Stefan Guilhen
Fix For: NO_VERSION
(11:25:04 AM) sguilhen: anil: ping... on SecurityConfig, there is a stack of
configurations... however the popLoginConfig() seems not right to me... it always
re-installs the same configuration over and over instead of installing the previous
configuration... can you take a look at it later?
(11:27:22 AM) sguilhen: anil: also, as I am going to inject XMLLoginConfig directly, I
need somehow to change this stack to keep the XMLLoginConfig instance instead of the
object name.... so I think I need to add an extra interface here to allow the use of
multiple login configurations.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:18 p.m.
New subject: [JBoss JIRA] Commented: (SECURITY-244) Look at SecurityConfig
[
https://jira.jboss.org/jira/browse/SECURITY-244?page=com.atlassian.jira.p...
]
Stefan Guilhen commented on SECURITY-244:
-----------------------------------------
Not sure about the popLoginConfig issue, but the stack still holds object names as far as
I know. I'll take a look at this.
Look at SecurityConfig
----------------------
Key: SECURITY-244
URL: https://jira.jboss.org/jira/browse/SECURITY-244
Project: JBoss Security and Identity Management
Issue Type: Task
Security Level: Public(Everyone can see)
Reporter: Anil Saldhana
Assignee: Stefan Guilhen
Fix For: NO_VERSION
(11:25:04 AM) sguilhen: anil: ping... on SecurityConfig, there is a stack of
configurations... however the popLoginConfig() seems not right to me... it always
re-installs the same configuration over and over instead of installing the previous
configuration... can you take a look at it later?
(11:27:22 AM) sguilhen: anil: also, as I am going to inject XMLLoginConfig directly, I
need somehow to change this stack to keep the XMLLoginConfig instance instead of the
object name.... so I think I need to add an extra interface here to allow the use of
multiple login configurations.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:26 a.m.
New subject: [JBoss JIRA] Commented: (SECURITY-244) Look at SecurityConfig
[
https://jira.jboss.org/jira/browse/SECURITY-244?page=com.atlassian.jira.p...
]
Stefan Guilhen commented on SECURITY-244:
-----------------------------------------
I've taken a look a this class and this is what we have now in Trunk:
- the loginConfigStack now holds Configuration objects instead of object names. Thus, when
a configuration is popped, we install the previous config in the stack. I think we still
need to add some logic so that when the stack becomes empty we install the JDK default
configuration.
- currently, whenever we push a configuration we either provide an object name for an
MBean that must implement getConfiguration(Configuration prevConfig) or an XMLLoginConfig
instance. In my opinion, this not as good as it could be, as XMLLoginConfig is not an
interface and this means that people who want to inject their own configuration need to
extend this class. A better way to do this would be to create an interface, something like
LoginConfig, and define the getConfiguration(Configuration prevConfig) method. Then change
the pushLoginConfig to accept instances of LoginConfig instead of XMLLoginConfig. In this
case, XMLLoginConfig would implement LoginConfig, allowing us to inject any LoginConfig
implementation into SecurityConfig.
Look at SecurityConfig
----------------------
Key: SECURITY-244
URL: https://jira.jboss.org/jira/browse/SECURITY-244
Project: JBoss Security and Identity Management
Issue Type: Task
Security Level: Public(Everyone can see)
Reporter: Anil Saldhana
Assignee: Stefan Guilhen
Fix For: NO_VERSION
(11:25:04 AM) sguilhen: anil: ping... on SecurityConfig, there is a stack of
configurations... however the popLoginConfig() seems not right to me... it always
re-installs the same configuration over and over instead of installing the previous
configuration... can you take a look at it later?
(11:27:22 AM) sguilhen: anil: also, as I am going to inject XMLLoginConfig directly, I
need somehow to change this stack to keep the XMLLoginConfig instance instead of the
object name.... so I think I need to add an extra interface here to allow the use of
multiple login configurations.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:41 a.m.
New subject: [JBoss JIRA] Commented: (SECURITY-244) Look at SecurityConfig
[
https://jira.jboss.org/jira/browse/SECURITY-244?page=com.atlassian.jira.p...
]
Anil Saldhana commented on SECURITY-244:
----------------------------------------
Stefan, your reasoning looks good to me. Lets get this done for AS5GA then...
Look at SecurityConfig
----------------------
Key: SECURITY-244
URL: https://jira.jboss.org/jira/browse/SECURITY-244
Project: JBoss Security and Identity Management
Issue Type: Task
Security Level: Public(Everyone can see)
Reporter: Anil Saldhana
Assignee: Stefan Guilhen
Fix For: NO_VERSION
(11:25:04 AM) sguilhen: anil: ping... on SecurityConfig, there is a stack of
configurations... however the popLoginConfig() seems not right to me... it always
re-installs the same configuration over and over instead of installing the previous
configuration... can you take a look at it later?
(11:27:22 AM) sguilhen: anil: also, as I am going to inject XMLLoginConfig directly, I
need somehow to change this stack to keep the XMLLoginConfig instance instead of the
object name.... so I think I need to add an extra interface here to allow the use of
multiple login configurations.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:19 p.m.
New subject: [JBoss JIRA] Closed: (SECURITY-244) Look at SecurityConfig
[
https://jira.jboss.org/jira/browse/SECURITY-244?page=com.atlassian.jira.p...
]
Stefan Guilhen closed SECURITY-244.
-----------------------------------
Resolution: Done
SecurityConfig looks good now. I've added a couple of logging statements to the
popLoginConfig method so we can better visualize what configuration is being installed
when we pop the current config.
Look at SecurityConfig
----------------------
Key: SECURITY-244
URL: https://jira.jboss.org/jira/browse/SECURITY-244
Project: JBoss Security and Identity Management
Issue Type: Task
Security Level: Public(Everyone can see)
Reporter: Anil Saldhana
Assignee: Stefan Guilhen
Fix For: NO_VERSION
(11:25:04 AM) sguilhen: anil: ping... on SecurityConfig, there is a stack of
configurations... however the popLoginConfig() seems not right to me... it always
re-installs the same configuration over and over instead of installing the previous
configuration... can you take a look at it later?
(11:27:22 AM) sguilhen: anil: also, as I am going to inject XMLLoginConfig directly, I
need somehow to change this stack to keep the XMLLoginConfig instance instead of the
object name.... so I think I need to add an extra interface here to allow the use of
multiple login configurations.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5474
days inactive
6036
days old
5 comments
2 participants
participants (2)
-
Anil Saldhana (JIRA) -
Stefan Guilhen (JIRA)