[ http://jira.jboss.com/jira/browse/JBRULES-519?page=comments#action_12345449 ] Tomasz Cichocki commented on JBRULES-519: ----------------------------------------- I played around with drl.g file, it doesn't compile with antlr-3.0ea10... It does compile with antlr-3.0ea8, but there are many warnings... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-519?page=comments#action_12346927 ] Michael Neale commented on JBRULES-519: --------------------------------------- Awesome ! Tomasz, you are some kind of an Antlr deity. Tell me where you live and I will pray in that general direction tonight. I am not sure when we will incorporate those changes, but we will. I want to pull out the DSL stuff from the core parser anyway, so that is fine. I didn't think the lexer rule for the RHS would actually work - does it have any detrimental side effects? Perhaps we can combine this issue with tightening the newline requirements. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-519?page=comments#action_12346936 ] Edson Tirelli commented on JBRULES-519: --------------------------------------- Michael, I made only a quick test with this grammar, but it seems the line breaks are working fine now. What do you mean by "tightening"? BTW, Thank you Tomasz, really awesome job! []s Edson -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-519?page=comments#action_12346944 ] Edson Tirelli commented on JBRULES-519: --------------------------------------- hmmm, ok, we need to check that. I was referring to this: http://jira.jboss.com/jira/browse/JBRULES-549 I think you was referring to this: http://jira.jboss.com/jira/browse/JBRULES-269 Yeah, we need to test that. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-519?page=comments#action_12347866 ] Edson Tirelli commented on JBRULES-519: --------------------------------------- $ svn log -r 7928 -v ------------------------------------------------------------------------ r7928 | tirelli | 2006-11-29 08:48:37 -0300 (Wed, 29 Nov 2006) | 1 line Changed paths: M /labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/DrlParser.java A /labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/SwitchingCommonTokenStream.java A /labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/DRLLexer.java A /labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/DRLParser.java D /labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/RuleParser.java D /labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/RuleParserLexer.java M /labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/descr/LiteralRestrictionDescr.java A /labs/jbossrules/trunk/drools-compiler/src/main/resources/org/drools/lang/DRL.g M /labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/IndexedNumber.java M /labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/integrationtests/IntegrationCases.java M /labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/lang/RuleParserTest.java M /labs/jbossrules/trunk/drools-compiler/src/test/resources/org/drools/lang/column_partial.drl M /labs/jbossrules/trunk/drools-compiler/src/test/resources/org/drools/lang/empty_rule.drl M /labs/jbossrules/trunk/drools-compiler/src/test/resources/org/drools/lang/eol_funny_business.drl M /labs/jbossrules/trunk/drools-compiler/src/test/resources/org/drools/lang/invalid_syntax.drl M /labs/jbossrules/trunk/drools-compiler/src/test/resources/org/drools/lang/restrictions_test.drl M /labs/jbossrules/trunk/drools-compiler/src/test/resources/org/drools/lang/rule_names_number_prefix.drl M /labs/jbossrules/trunk/drools-compiler/src/test/resources/org/drools/lang/statement_ordering_1.drl JBRULES-519: merging grammar into 3.1m1 branch ------------------------------------------------------------------------ -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBRULES-519?page=all ] Edson Tirelli resolved JBRULES-519. ----------------------------------- Fix Version/s: 3.1-m1 Resolution: Done Problem fixed. Unit test added to trunk in revision #8300: $ svn log -r 8300 -v ------------------------------------------------------------------------ r8300 | tirelli | 2006-12-13 16:33:47 -0300 (Wed, 13 Dec 2006) | 1 line Changed paths: M /labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/lang/RuleParserTest.java A /labs/jbossrules/trunk/drools-compiler/src/test/resources/org/drools/lang/escaped-string.drl JBRULES-519: fixing escaped strings. Unit test added ------------------------------------------------------------------------ -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira