[ https://issues.jboss.org/browse/AS7-4154?page=com.atlassian.jira.plugin.s... ] Ondrej Zizka updated AS7-4154: ------------------------------ Description: Add support for such report. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-4154?page=com.atlassian.jira.plugin.s... ] Ondrej Zizka updated AS7-4154: ------------------------------ Description: Add support for such report. See: http://mojo.codehaus.org/animal-sniffer-maven-plugin/ was:Add support for such report. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-4154?page=com.atlassian.jira.plugin.s... ] Ondrej Zizka updated AS7-4154: ------------------------------ Description: Add support for such report. See: http://mojo.codehaus.org/animal-sniffer-maven-plugin/ {code} mvn animal-sniffer:build -DincludeJavaHome=false -DskipIfNoJavaHome=true {code} was: Add support for such report. See: http://mojo.codehaus.org/animal-sniffer-maven-plugin/ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-4154?page=com.atlassian.jira.plugin.s... ] Ondrej Zizka edited comment on AS7-4154 at 10/26/12 10:39 AM: -------------------------------------------------------------- Did some experiments. It does the job, but fails with errors like {code} ERROR] Failed to execute goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.9:build (default-cli) on project jboss-as-testsuite-shared: A type incompatibility occured while executing org.codehaus.mojo:animal-sniffer-maven-plugin:1.9:build: Cannot merger class com/google/common/collect/MapMaker as it has changed superclass. {code} Probably multiple versions of the class. After some further trials/errors with excludes, I made it work. {code} <plugin> <groupId>org.codehaus.mojo</groupId> <artifactId>animal-sniffer-maven-plugin</artifactId> <version>1.9</version> <configuration> <!-- <skipIfNoJavaHome>true</skipIfNoJavaHome> <includeJavaHome>false</includeJavaHome> <includeDependencies> <includeDependency>org.jboss.as:*</includeDependency> </includeDependencies> --> <excludeDependencies> <excludeDependency>com.sun.faces:*</excludeDependency> <excludeDependency>com.google.collections:*</excludeDependency> </excludeDependencies> <includeClasses> <includeClass>org.jboss.as.*</includeClass> </includeClasses> <excludeClasses> <excludeClass>com.sun.*</excludeClass> <excludeClass>com.google.common.collect.MapMaker</excludeClass> </excludeClasses> </configuration> </plugin> {code} was (Author: ozizka): Did some experiments. It does the job, but fails with some error about com.sun.faces.util.Util$1. Probably multiple versions of the class. That would need further trial/error with excludes. {code} <plugin> <groupId>org.codehaus.mojo</groupId> <artifactId>animal-sniffer-maven-plugin</artifactId> <version>1.9</version> <configuration> <!-- <skipIfNoJavaHome>true</skipIfNoJavaHome> <includeJavaHome>false</includeJavaHome> <includeDependencies> <includeDependency>org.jboss.as:*</includeDependency> </includeDependencies> --> <excludeDependencies> <excludeDependency>com.sun.faces:*</excludeDependency> </excludeDependencies> <includeClasses> <includeClass>org.jboss.as.*</includeClass> </includeClasses> <excludeClasses> <excludeClass>com.sun.*</excludeClass> </excludeClasses> </configuration> </plugin> </plugins> {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-4154?page=com.atlassian.jira.plugin.s... ] Ondrej Zizka commented on AS7-4154: ----------------------------------- I continued a bit and found no way to turn the .signature files into signature artifacts which are needed for the second goal, animal-sniffer: check. No relevant info in the docs (only for JDK API check). http://mojo.codehaus.org/animal-sniffer-maven-plugin/ I've asked at SO: http://stackoverflow.com/questions/13098613/animal-sniffer-maven-plugin-h... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-4154?page=com.atlassian.jira.plugin.s... ] Ondrej Zizka commented on AS7-4154: ----------------------------------- {code} <profile> <id>api-signature-check</id> <build> <plugins> <plugin> <groupId>org.codehaus.mojo</groupId> <artifactId>animal-sniffer-maven-plugin</artifactId> <version>1.9</version> <configuration> <!-- <skipIfNoJavaHome>true</skipIfNoJavaHome> <includeJavaHome>false</includeJavaHome> <includeDependencies> <includeDependency>org.jboss.as:*</includeDependency> </includeDependencies> --> <excludeDependencies> <excludeDependency>com.sun.faces:*</excludeDependency> <excludeDependency>com.google.collections:*</excludeDependency> </excludeDependencies> <includeClasses> <includeClass>org.jboss.as.*</includeClass> </includeClasses> <excludeClasses> <excludeClass>com.sun.*</excludeClass> <excludeClass>com.google.common.collect.MapMaker</excludeClass> </excludeClasses> </configuration> <executions> <execution> <id>api-signature.build</id> <phase>site</phase> <goals><goal>build</goal></goals> </execution> </executions> </plugin> <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-install-plugin</artifactId> <version>2.4</version> <executions> <execution> <id>api-signature.install</id> <phase>site</phase> <goals><goal>install-file</goal></goals> <configuration> <file>${project.build.directory}/${project.artifactId}-${project.version}.signature</file> <groupId>${project.groupID}</groupId> <artifactId>${project.artifactId}</artifactId> <version>${project.version}</version> <packaging>signature</packaging> </configuration> </execution> </executions> </plugin> </plugins> </build> </profile> {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-4154?page=com.atlassian.jira.plugin.s... ] Ondrej Zizka edited comment on AS7-4154 at 10/28/12 7:58 AM: ------------------------------------------------------------- {code:xml} <profile> <id>api-signature.create</id> <build> <plugins> <plugin> <groupId>org.codehaus.mojo</groupId> <artifactId>animal-sniffer-maven-plugin</artifactId> <version>1.9</version> <configuration> <!-- <skipIfNoJavaHome>true</skipIfNoJavaHome> <includeJavaHome>false</includeJavaHome> <includeDependencies> <includeDependency>org.jboss.as:*</includeDependency> </includeDependencies> --> <excludeDependencies> <excludeDependency>com.sun.faces:*</excludeDependency> <excludeDependency>com.google.collections:*</excludeDependency> </excludeDependencies> <includeClasses> <includeClass>org.jboss.as.*</includeClass> </includeClasses> <excludeClasses> <excludeClass>com.sun.*</excludeClass> <excludeClass>com.google.common.collect.MapMaker</excludeClass> </excludeClasses> </configuration> <executions> <execution> <id>api-signature.create.animal-sniffer</id> <phase>site</phase> <goals><goal>build</goal></goals> </execution> </executions> </plugin> <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-install-plugin</artifactId> <version>2.4</version> <executions> <execution> <id>api-signature.create.install</id> <phase>site</phase> <goals><goal>install-file</goal></goals> <configuration> <file>${project.build.directory}/${project.artifactId}-${project.version}.signature</file> <groupId>${project.groupID}</groupId> <artifactId>${project.artifactId}</artifactId> <version>${project.version}</version> <packaging>signature</packaging> </configuration> </execution> </executions> </plugin> </plugins> </build> </profile> {code} was (Author: ozizka): {code:xml} <profile> <id>api-signature-check</id> <build> <plugins> <plugin> <groupId>org.codehaus.mojo</groupId> <artifactId>animal-sniffer-maven-plugin</artifactId> <version>1.9</version> <configuration> <!-- <skipIfNoJavaHome>true</skipIfNoJavaHome> <includeJavaHome>false</includeJavaHome> <includeDependencies> <includeDependency>org.jboss.as:*</includeDependency> </includeDependencies> --> <excludeDependencies> <excludeDependency>com.sun.faces:*</excludeDependency> <excludeDependency>com.google.collections:*</excludeDependency> </excludeDependencies> <includeClasses> <includeClass>org.jboss.as.*</includeClass> </includeClasses> <excludeClasses> <excludeClass>com.sun.*</excludeClass> <excludeClass>com.google.common.collect.MapMaker</excludeClass> </excludeClasses> </configuration> <executions> <execution> <id>api-signature.build</id> <phase>site</phase> <goals><goal>build</goal></goals> </execution> </executions> </plugin> <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-install-plugin</artifactId> <version>2.4</version> <executions> <execution> <id>api-signature.install</id> <phase>site</phase> <goals><goal>install-file</goal></goals> <configuration> <file>${project.build.directory}/${project.artifactId}-${project.version}.signature</file> <groupId>${project.groupID}</groupId> <artifactId>${project.artifactId}</artifactId> <version>${project.version}</version> <packaging>signature</packaging> </configuration> </execution> </executions> </plugin> </plugins> </build> </profile> {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira