[JBoss JIRA] Created: (JBRULES-575) Shadow facts break when a fact Class has 2 properties (with a different name) of the same fact class
2:43 p.m.
Shadow facts break when a fact Class has 2 properties (with a different name) of the same
fact class
----------------------------------------------------------------------------------------------------
Key: JBRULES-575
URL: http://jira.jboss.com/jira/browse/JBRULES-575
Project: JBoss Rules
Issue Type: Bug
Security Level: Public (Everyone can see)
Affects Versions: 3.1-m1
Reporter: Geoffrey De Smet
Assigned To: Mark Proctor
Priority: Critical
See user mailing list: [trunk] Repetitive field name/signature in class
ava.lang.ClassFormatError: Repetitive field name/signature in class file
net/sf/taseree/samples/travelingtournament/domain/MatchShadowProxy
Here's my Match class:
public class Match extends AbstractPersistable implements Comparable<Match>,
Solution {
private Team homeTeam;
private Team awayTeam;
private Day day;
// getters, setters, clone(), toString()
}
AbstractPersistable has a Long id with getters/setters
I will make a testcase with Cheese and provide a testcase patch, but it seems the
trunk's pom's don't do "mvn idea:idea" properly, like the branch
did,
so I 'll provide a pom.xml patch first :)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:01 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-575) Shadow facts break when a fact Class has 2 properties (with a different name) of the same fact class
[ http://jira.jboss.com/jira/browse/JBRULES-575?page=comments#action_12348102 ]
Geoffrey De Smet commented on JBRULES-575:
------------------------------------------
I tried adjusting ShadowProxyFactoryTest with a CheeseCouple class (which holds
firstCheese and secondCheese), but that worked:
final Class proxy = ShadowProxyFactory.getProxy( CheeseCouple.class );
final CheeseCouple cheeseCoupleProxy = (CheeseCouple) proxy.getConstructor( new
Class[]{CheeseCouple.class} ).newInstance( new Object[]{cheeseCouple} );
However the stacktrace is at:
at org.drools.rule.PackageCompilationData$PackageClassLoader.fastFindClass
So I 'll now go for yet another integration test.
Shadow facts break when a fact Class has 2 properties (with a
different name) of the same fact class
----------------------------------------------------------------------------------------------------
Key: JBRULES-575
URL: http://jira.jboss.com/jira/browse/JBRULES-575
Project: JBoss Rules
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.1-m1
Reporter: Geoffrey De Smet
Assigned To: Mark Proctor
Priority: Critical
See user mailing list: [trunk] Repetitive field name/signature in class
ava.lang.ClassFormatError: Repetitive field name/signature in class file
net/sf/taseree/samples/travelingtournament/domain/MatchShadowProxy
Here's my Match class:
public class Match extends AbstractPersistable implements Comparable<Match>,
Solution {
private Team homeTeam;
private Team awayTeam;
private Day day;
// getters, setters, clone(), toString()
}
AbstractPersistable has a Long id with getters/setters
I will make a testcase with Cheese and provide a testcase patch, but it seems the
trunk's pom's don't do "mvn idea:idea" properly, like the branch
did,
so I 'll provide a pom.xml patch first :)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:01 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-575) Shadow facts break when a fact Class has 2 properties (with a different name) of the same fact class
[ http://jira.jboss.com/jira/browse/JBRULES-575?page=comments#action_12348103 ]
Geoffrey De Smet commented on JBRULES-575:
------------------------------------------
Ps: the full stacktrace:
java.lang.ClassFormatError: Repetitive field name/signature in class file
net/sf/taseree/samples/travelingtournament/domain/MatchShadowProxy
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:620)
at java.lang.ClassLoader.defineClass(ClassLoader.java:465)
at
org.drools.rule.PackageCompilationData$PackageClassLoader.fastFindClass(PackageCompilationData.java:305)
at
org.drools.rule.PackageCompilationData$PackageClassLoader.findClass(PackageCompilationData.java:343)
at org.drools.rule.PackageCompilationData.wire(PackageCompilationData.java:230)
at org.drools.rule.PackageCompilationData.wire(PackageCompilationData.java:222)
at org.drools.rule.PackageCompilationData.write(PackageCompilationData.java:154)
at org.drools.semantics.java.RuleBuilder.build(RuleBuilder.java:435)
at org.drools.semantics.java.RuleBuilder.build(RuleBuilder.java:323)
at org.drools.semantics.java.RuleBuilder.build(RuleBuilder.java:215)
at org.drools.compiler.PackageBuilder.addRule(PackageBuilder.java:366)
at org.drools.compiler.PackageBuilder.addPackage(PackageBuilder.java:215)
at org.drools.compiler.PackageBuilder.addPackageFromDrl(PackageBuilder.java:144)
at
net.sf.taseree.samples.common.evaluation.RuleBaseBeanFactory.afterPropertiesSet(RuleBaseBeanFactory.java:32)
at
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.invokeInitMethods(AbstractAutowireCapableBeanFactory.java:1059)
at
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:363)
at
org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:226)
at
org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:147)
at
org.springframework.beans.factory.support.BeanDefinitionValueResolver.resolveReference(BeanDefinitionValueResolver.java:176)
at
org.springframework.beans.factory.support.BeanDefinitionValueResolver.resolveValueIfNecessary(BeanDefinitionValueResolver.java:105)
at
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyPropertyValues(AbstractAutowireCapableBeanFactory.java:1013)
at
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:824)
at
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:345)
at
org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:226)
at
org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:147)
at
org.springframework.beans.factory.support.BeanDefinitionValueResolver.resolveReference(BeanDefinitionValueResolver.java:176)
at
org.springframework.beans.factory.support.BeanDefinitionValueResolver.resolveValueIfNecessary(BeanDefinitionValueResolver.java:105)
at
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyPropertyValues(AbstractAutowireCapableBeanFactory.java:1013)
at
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:824)
at
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:345)
at
org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:226)
at
org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:147)
at
org.springframework.beans.factory.support.BeanDefinitionValueResolver.resolveReference(BeanDefinitionValueResolver.java:176)
at
org.springframework.beans.factory.support.BeanDefinitionValueResolver.resolveValueIfNecessary(BeanDefinitionValueResolver.java:105)
at
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyPropertyValues(AbstractAutowireCapableBeanFactory.java:1013)
at
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:824)
at
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:345)
at
org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:226)
at
org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:147)
at
org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:275)
at
org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:320)
at
org.springframework.context.support.ClassPathXmlApplicationContext.<init>(ClassPathXmlApplicationContext.java:87)
at
org.springframework.context.support.ClassPathXmlApplicationContext.<init>(ClassPathXmlApplicationContext.java:72)
at
org.springframework.context.support.ClassPathXmlApplicationContext.<init>(ClassPathXmlApplicationContext.java:63)
at net.sf.taseree.samples.common.app.CommonApp.startApp(CommonApp.java:24)
at
net.sf.taseree.samples.travelingtournament.app.TravelingTournamentApp.main(TravelingTournamentApp.java:14)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at com.intellij.rt.execution.application.AppMain.main(AppMain.java:90)
Shadow facts break when a fact Class has 2 properties (with a
different name) of the same fact class
----------------------------------------------------------------------------------------------------
Key: JBRULES-575
URL: http://jira.jboss.com/jira/browse/JBRULES-575
Project: JBoss Rules
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.1-m1
Reporter: Geoffrey De Smet
Assigned To: Mark Proctor
Priority: Critical
See user mailing list: [trunk] Repetitive field name/signature in class
ava.lang.ClassFormatError: Repetitive field name/signature in class file
net/sf/taseree/samples/travelingtournament/domain/MatchShadowProxy
Here's my Match class:
public class Match extends AbstractPersistable implements Comparable<Match>,
Solution {
private Team homeTeam;
private Team awayTeam;
private Day day;
// getters, setters, clone(), toString()
}
AbstractPersistable has a Long id with getters/setters
I will make a testcase with Cheese and provide a testcase patch, but it seems the
trunk's pom's don't do "mvn idea:idea" properly, like the branch
did,
so I 'll provide a pom.xml patch first :)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:15 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-575) Shadow facts break when a fact Class has 2 properties (with a different name) of the same fact class
[ http://jira.jboss.com/jira/browse/JBRULES-575?page=comments#action_12348105 ]
Geoffrey De Smet commented on JBRULES-575:
------------------------------------------
Hmmmm, my integration test also worked:
public void testShadowFactWith2PropertiesOfTheSameClass() throws Exception {
// pre build the package
final PackageBuilder builder = new PackageBuilder();
builder.addPackageFromDrl( new InputStreamReader( getClass().getResourceAsStream(
"test_ShadowFactWith2PropertiesOfTheSameClass.drl" ) ) );
final Package pkg = builder.getPackage();
// add the package to a rulebase
final RuleBase ruleBase = getRuleBase();
ruleBase.addPackage( pkg );
final WorkingMemory workingMemory = ruleBase.newWorkingMemory();
final List list = new ArrayList();
workingMemory.setGlobal( "list",
list );
final Cheese stilton = new Cheese( "stilton", 5 );
workingMemory.assertObject( stilton );
final Cheese gouda = new Cheese( "gouda", 7 );
workingMemory.assertObject( gouda );
final CheeseCouple cheeseCouple = new CheeseCouple(stilton, gouda);
workingMemory.assertObject( cheeseCouple );
workingMemory.fireAllRules();
assertEquals( new Integer( 7 ),
list.get( 0 ) );
}
However, in Taseree, with the same trunk revision (current head) it still breaks...
I don't understand it.
To try yourself:
- do a "mvn install" on the drools trunk
- check taseree from https://svn.sourceforge.net/svnroot/taseree/trunk
- adjust /pom.xml so the drools dependencies (3.0.2 or 3.1.0-SNAPSHOT dependening if my
pom.xml patch is applied on the drools trunk),
- mvn eclipse:eclipse idea:idea
- Run net.sf.taseree.samples.travelingtournament.app.TravelingTournamentApp
(LessonScheduleApp currently doesn't work)
Shadow facts break when a fact Class has 2 properties (with a
different name) of the same fact class
----------------------------------------------------------------------------------------------------
Key: JBRULES-575
URL: http://jira.jboss.com/jira/browse/JBRULES-575
Project: JBoss Rules
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.1-m1
Reporter: Geoffrey De Smet
Assigned To: Mark Proctor
Priority: Critical
See user mailing list: [trunk] Repetitive field name/signature in class
ava.lang.ClassFormatError: Repetitive field name/signature in class file
net/sf/taseree/samples/travelingtournament/domain/MatchShadowProxy
Here's my Match class:
public class Match extends AbstractPersistable implements Comparable<Match>,
Solution {
private Team homeTeam;
private Team awayTeam;
private Day day;
// getters, setters, clone(), toString()
}
AbstractPersistable has a Long id with getters/setters
I will make a testcase with Cheese and provide a testcase patch, but it seems the
trunk's pom's don't do "mvn idea:idea" properly, like the branch
did,
so I 'll provide a pom.xml patch first :)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:20 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-575) Shadow facts break when a fact Class has 2 properties (with a different name) of the same fact class
[ http://jira.jboss.com/jira/browse/JBRULES-575?page=comments#action_12348309 ]
Geoffrey De Smet commented on JBRULES-575:
------------------------------------------
Edson thinks it's due to overridden/implemented methods, so here's my full class
description:
public class Match extends AbstractPersistable
implements Comparable<Match>, Solution {
// ...
// Implemented from Comparable<Match>
public int compareTo(Match lesson) {
// Overwritten from Object, implemented from Solution
public Match clone() {
// Overwritten from AbstractPersistable
public String toString() {
}
Shadow facts break when a fact Class has 2 properties (with a
different name) of the same fact class
----------------------------------------------------------------------------------------------------
Key: JBRULES-575
URL: http://jira.jboss.com/jira/browse/JBRULES-575
Project: JBoss Rules
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.1-m1
Reporter: Geoffrey De Smet
Assigned To: Mark Proctor
Priority: Critical
See user mailing list: [trunk] Repetitive field name/signature in class
ava.lang.ClassFormatError: Repetitive field name/signature in class file
net/sf/taseree/samples/travelingtournament/domain/MatchShadowProxy
Here's my Match class:
public class Match extends AbstractPersistable implements Comparable<Match>,
Solution {
private Team homeTeam;
private Team awayTeam;
private Day day;
// getters, setters, clone(), toString()
}
AbstractPersistable has a Long id with getters/setters
I will make a testcase with Cheese and provide a testcase patch, but it seems the
trunk's pom's don't do "mvn idea:idea" properly, like the branch
did,
so I 'll provide a pom.xml patch first :)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:26 p.m.
New subject: [JBoss JIRA] Assigned: (JBRULES-575) Shadow facts break when a fact Class has 2 properties (with a different name) of the same fact class
[ http://jira.jboss.com/jira/browse/JBRULES-575?page=all ]
Edson Tirelli reassigned JBRULES-575:
-------------------------------------
Assignee: Edson Tirelli (was: Mark Proctor)
Shadow facts break when a fact Class has 2 properties (with a
different name) of the same fact class
----------------------------------------------------------------------------------------------------
Key: JBRULES-575
URL: http://jira.jboss.com/jira/browse/JBRULES-575
Project: JBoss Rules
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.1-m1
Reporter: Geoffrey De Smet
Assigned To: Edson Tirelli
Priority: Critical
See user mailing list: [trunk] Repetitive field name/signature in class
ava.lang.ClassFormatError: Repetitive field name/signature in class file
net/sf/taseree/samples/travelingtournament/domain/MatchShadowProxy
Here's my Match class:
public class Match extends AbstractPersistable implements Comparable<Match>,
Solution {
private Team homeTeam;
private Team awayTeam;
private Day day;
// getters, setters, clone(), toString()
}
AbstractPersistable has a Long id with getters/setters
I will make a testcase with Cheese and provide a testcase patch, but it seems the
trunk's pom's don't do "mvn idea:idea" properly, like the branch
did,
so I 'll provide a pom.xml patch first :)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:45 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-575) Shadow facts break when a fact Class has 2 properties (with a different name) of the same fact class
[ http://jira.jboss.com/jira/browse/JBRULES-575?page=comments#action_12348754 ]
Edson Tirelli commented on JBRULES-575:
---------------------------------------
Ok, found the problem.
Java 5 allows you override a method changing its return type. In your case, Solution has a
method clone() that returns a Solution object, while Match overrides the clone method
returning a Match object.
Need to improve proxy factory to override only the last overriden method: in this case,
Match.clone(), and ignore parent overriden methods (Solution.clone() in your case).
Shadow facts break when a fact Class has 2 properties (with a
different name) of the same fact class
----------------------------------------------------------------------------------------------------
Key: JBRULES-575
URL: http://jira.jboss.com/jira/browse/JBRULES-575
Project: JBoss Rules
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.1-m1
Reporter: Geoffrey De Smet
Assigned To: Edson Tirelli
Priority: Critical
See user mailing list: [trunk] Repetitive field name/signature in class
ava.lang.ClassFormatError: Repetitive field name/signature in class file
net/sf/taseree/samples/travelingtournament/domain/MatchShadowProxy
Here's my Match class:
public class Match extends AbstractPersistable implements Comparable<Match>,
Solution {
private Team homeTeam;
private Team awayTeam;
private Day day;
// getters, setters, clone(), toString()
}
AbstractPersistable has a Long id with getters/setters
I will make a testcase with Cheese and provide a testcase patch, but it seems the
trunk's pom's don't do "mvn idea:idea" properly, like the branch
did,
so I 'll provide a pom.xml patch first :)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:08 p.m.
New subject: [JBoss JIRA] Closed: (JBRULES-575) Shadow facts break when a fact Class has 2 properties (with a different name) of the same fact class
[ http://jira.jboss.com/jira/browse/JBRULES-575?page=all ]
Edson Tirelli closed JBRULES-575.
---------------------------------
Shadow facts break when a fact Class has 2 properties (with a
different name) of the same fact class
----------------------------------------------------------------------------------------------------
Key: JBRULES-575
URL: http://jira.jboss.com/jira/browse/JBRULES-575
Project: JBoss Rules
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.1-m1
Reporter: Geoffrey De Smet
Assigned To: Edson Tirelli
Priority: Critical
Fix For: 3.1-m1
See user mailing list: [trunk] Repetitive field name/signature in class
ava.lang.ClassFormatError: Repetitive field name/signature in class file
net/sf/taseree/samples/travelingtournament/domain/MatchShadowProxy
Here's my Match class:
public class Match extends AbstractPersistable implements Comparable<Match>,
Solution {
private Team homeTeam;
private Team awayTeam;
private Day day;
// getters, setters, clone(), toString()
}
AbstractPersistable has a Long id with getters/setters
I will make a testcase with Cheese and provide a testcase patch, but it seems the
trunk's pom's don't do "mvn idea:idea" properly, like the branch
did,
so I 'll provide a pom.xml patch first :)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:08 p.m.
New subject: [JBoss JIRA] Resolved: (JBRULES-575) Shadow facts break when a fact Class has 2 properties (with a different name) of the same fact class
[ http://jira.jboss.com/jira/browse/JBRULES-575?page=all ]
Edson Tirelli resolved JBRULES-575.
-----------------------------------
Fix Version/s: 3.1-m1
Resolution: Done
Geoffrey, thank you for reporting. Fix commited into trunk in revision 8332.
$ svn log -r 8332 -v
------------------------------------------------------------------------
r8332 | tirelli | 2006-12-14 19:02:58 -0300 (Thu, 14 Dec 2006) | 1 line
Changed paths:
M
/labs/jbossrules/trunk/drools-core/src/main/java/org/drools/base/ShadowProxyFactory.java
JBRULES-575: filtering overriden methods based on the return type
------------------------------------------------------------------------
As this is a problem specific to java 5+, I could not commit the test cases, but all of
those I tested here are now working just fine.
Please, check and let me know if you have any other issue.
Regards,
Edson
Shadow facts break when a fact Class has 2 properties (with a
different name) of the same fact class
----------------------------------------------------------------------------------------------------
Key: JBRULES-575
URL: http://jira.jboss.com/jira/browse/JBRULES-575
Project: JBoss Rules
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 3.1-m1
Reporter: Geoffrey De Smet
Assigned To: Edson Tirelli
Priority: Critical
Fix For: 3.1-m1
See user mailing list: [trunk] Repetitive field name/signature in class
ava.lang.ClassFormatError: Repetitive field name/signature in class file
net/sf/taseree/samples/travelingtournament/domain/MatchShadowProxy
Here's my Match class:
public class Match extends AbstractPersistable implements Comparable<Match>,
Solution {
private Team homeTeam;
private Team awayTeam;
private Day day;
// getters, setters, clone(), toString()
}
AbstractPersistable has a Long id with getters/setters
I will make a testcase with Cheese and provide a testcase patch, but it seems the
trunk's pom's don't do "mvn idea:idea" properly, like the branch
did,
so I 'll provide a pom.xml patch first :)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6490
days inactive
6501
days old
8 comments
2 participants
participants (2)
-
Edson Tirelli (JIRA) -
Geoffrey De Smet (JIRA)