[ https://jira.jboss.org/jira/browse/JBMDR-60?page=com.atlassian.jira.plugi... ] Scott Marlow reassigned JBMDR-60: --------------------------------- Assignee: Ales Justin (was: Scott Marlow) Did this happen yet? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBMDR-60?page=com.atlassian.jira.plugi... ] Scott Marlow commented on JBMDR-60: ----------------------------------- I avoided breaking any api as recommended on the design forums. It shouldn't hurt if this change gets merged back as part of another change. However, I think there is more work left to do to get full benefit from this ScopeKey change. I don't think the ScopeKey change is that big. There are still places where I put an OptimizedKey (return value from ScopeKey.getOptimizedKey()) as the Map search key but we later perform a Map search with a plain ScopeKey instead of an OptimizedKey. This causes ScopeKey.equals to be invoked with an OptimizedScopeKey object (or maybe the other way around). This is slower than if we used OptimizedScopeKey.equals with an OptimizedScopeKey object. My plan is to find all of the places that cause the mixed OptimizedScopeKey + ScopeKey based searchs to occur during AS boot and attempt fixing them to pass an OptimizedScopeKey. I got blocked on this effort before when I couldn't figure out how to fix this jira on my own. When we start doing parallel deployment, the performance impact of this ScopeKey change will be even more dramatic (since we avoid the need to synchronize on the Map). Do you need a new jira for moving MDR + MC Kernel to AS trunk? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira