[ http://jira.jboss.com/jira/browse/JBAS-5105?page=comments#action_12393943 ] Dr. Richard Li commented on JBAS-5105: -------------------------------------- Using the following procedures can reproduct the problem: 1. Create an Entity Bean with self gen keys using SERIAL type. 2. Use a session bean to create a few instances of the Entity Bean. 3. Exception occurs, only 1 row is created successfully, but other rows keep failing. I try to trace the SQL and figure out the problem is not that simple, the correct sequence in doing the create is: 1. insert the row into the table (NEED to OPT OUT the PK FIELD) 2. use currval('the_sequence') to retrieve the actual pk but actually the sequence is: 1. use currval('the_sequence') to obtain the pk 2. set the pk in the entity 3. insert the row in the table (The pk field is set as well) This sequence have the following problems: 1. The pk value may be the same in multiple threads execution which cause duplicate key exception 2. the sequence will not increment since the pk field is given an actual value. When next time the value of the sequence is enquired an exception will occurs. I would like to contribute on this issue, could any body points out that if I can use the correct sequence with the current framework? I this is the case, I can work on. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAS-5105?page=all ] Dr. Richard Li updated JBAS-5105: --------------------------------- Attachment: PSQLEntityCommandTest.zip I have created a test project to illustrate this issue. The "Standard" sub-project produces a ejb module which uses old persistant manager, the "JDBC2" sub-project produces the same ejb module which configures to use the "cmp2.x jdbc2 pm". When I run the client to create entities, exception occurs in the "JDBC" sub-project, while the "Standard" sub-project works correctly. I will attach the logs for both projects for comparison. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAS-5105?page=all ] Dr. Richard Li updated JBAS-5105: --------------------------------- Attachment: server.log This is the log for executing the "JDBC2" sub-project. Please note that the currval(...) is issued before the insert statement, and the insert statement includes the pk field during insert. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAS-5105?page=comments#action_12394256 ] Alexey Loubyansky commented on JBAS-5105: ----------------------------------------- Again, I don't see a bug in the current impl. It works as expected. You are talking about a different strategy that should be impl in a different command. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAS-5105?page=comments#action_12394311 ] Alexey Loubyansky commented on JBAS-5105: ----------------------------------------- I checked PostgreSQL's docs and now I see what you were talking about. I was confused by how the sequence is used in this case. Yes, it should call nextval() instead of currval(). What don't you like about this approach? We have to get the id after ejbCreate returns and before ejbPostCreate is invoked. So either we have to - INSERT with RETURNING or call currval() after INSERT in ejbCreate - or call nextval() and then INSERT sometime later (after ejbCreate/ejbPostCreate) In the later case we would support non-null foreign keys while in the first one we wouldn't. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAS-5105?page=comments#action_12394326 ] Alexey Loubyansky commented on JBAS-5105: ----------------------------------------- In which way should the INSERT statement be changed for that to work? Should the pk column be excluded? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAS-5105?page=all ] Alexey Loubyansky updated JBAS-5105: ------------------------------------ Fix Version/s: JBossAS-5.0.0.Beta4 JBossAS-4.2.3.GA Affects Version/s: JBossAS-5.0.0.Beta3 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira