[JBoss JIRA] Created: (JBMESSAGING-1183) Message Bridge use QueueFactoryRef or TopicFactoryRef instead of FactoryRef when looking up Source and Target Connection Factories
1:17 p.m.
Message Bridge use QueueFactoryRef or TopicFactoryRef instead of FactoryRef when looking
up Source and Target Connection Factories
----------------------------------------------------------------------------------------------------------------------------------
Key: JBMESSAGING-1183
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-1183
Project: JBoss Messaging
Issue Type: Bug
Components: Messaging Core
Affects Versions: 1.4.0.SP1
Reporter: Aaron Walker
Assigned To: Aaron Walker
Priority: Minor
Some message providers don't have a single base class the implements both the Queue
and Topic Connection Factories so you can't create a single JMSProviderLoader where
you can set the FactoryRef attribute to a single JNDI name. Really the Message bridge
should use the QueueFactoryRef or TopicFactoryRef attribute depending on the destination
type that the bridge is trying to connect to.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:23 p.m.
New subject: [JBoss JIRA] Commented: (JBMESSAGING-1183) Message Bridge use QueueFactoryRef or TopicFactoryRef instead of FactoryRef when looking up Source and Target Connection Factories
[ http://jira.jboss.com/jira/browse/JBMESSAGING-1183?page=comments#action_1... ]
Aaron Walker commented on JBMESSAGING-1183:
-------------------------------------------
Should I commit this to trunk and the stable branch
Message Bridge use QueueFactoryRef or TopicFactoryRef instead of
FactoryRef when looking up Source and Target Connection Factories
----------------------------------------------------------------------------------------------------------------------------------
Key: JBMESSAGING-1183
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-1183
Project: JBoss Messaging
Issue Type: Bug
Components: Messaging Core
Affects Versions: 1.4.0.SP1
Reporter: Aaron Walker
Assigned To: Aaron Walker
Priority: Minor
Some message providers don't have a single base class the implements both the Queue
and Topic Connection Factories so you can't create a single JMSProviderLoader where
you can set the FactoryRef attribute to a single JNDI name. Really the Message bridge
should use the QueueFactoryRef or TopicFactoryRef attribute depending on the destination
type that the bridge is trying to connect to.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:30 p.m.
New subject: [JBoss JIRA] Commented: (JBMESSAGING-1183) Message Bridge use QueueFactoryRef or TopicFactoryRef instead of FactoryRef when looking up Source and Target Connection Factories
[ http://jira.jboss.com/jira/browse/JBMESSAGING-1183?page=comments#action_1... ]
Tim Fox commented on JBMESSAGING-1183:
--------------------------------------
Can you post our patch?
I am literally about to run the tests for the 1.4.0.SP2 release, if the fix is simple I
can add it now...
Message Bridge use QueueFactoryRef or TopicFactoryRef instead of
FactoryRef when looking up Source and Target Connection Factories
----------------------------------------------------------------------------------------------------------------------------------
Key: JBMESSAGING-1183
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-1183
Project: JBoss Messaging
Issue Type: Bug
Components: Messaging Core
Affects Versions: 1.4.0.SP1
Reporter: Aaron Walker
Assigned To: Aaron Walker
Priority: Minor
Some message providers don't have a single base class the implements both the Queue
and Topic Connection Factories so you can't create a single JMSProviderLoader where
you can set the FactoryRef attribute to a single JNDI name. Really the Message bridge
should use the QueueFactoryRef or TopicFactoryRef attribute depending on the destination
type that the bridge is trying to connect to.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2 p.m.
New subject: [JBoss JIRA] Commented: (JBMESSAGING-1183) Message Bridge use QueueFactoryRef or TopicFactoryRef instead of FactoryRef when looking up Source and Target Connection Factories
[ http://jira.jboss.com/jira/browse/JBMESSAGING-1183?page=comments#action_1... ]
Aaron Walker commented on JBMESSAGING-1183:
-------------------------------------------
I don't have a diff tool to create a patch but here are the line of code for
BridgeService.java. The last two line are the original lines of code just replacing the
strings this the two variables about line 327 in original souce file for 1.4.0.SP1
String sourceFactoryRef = "QueueFactoryRef";
if(sourceDest instanceof javax.jms.Topic)
{
sourceFactoryRef = "TopicFactoryRef";
}
String targetFactoryRef = "QueueFactoryRef";
if(targetDest instanceof javax.jms.Topic)
{
targetFactoryRef = "TopicFactoryRef";
}
String sourceCFRef = (String)server.getAttribute(sourceProviderLoader,
sourceFactoryRef);
String targetCFRef = (String)server.getAttribute(targetProviderLoader,
targetFactoryRef);
Message Bridge use QueueFactoryRef or TopicFactoryRef instead of
FactoryRef when looking up Source and Target Connection Factories
----------------------------------------------------------------------------------------------------------------------------------
Key: JBMESSAGING-1183
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-1183
Project: JBoss Messaging
Issue Type: Bug
Components: Messaging Core
Affects Versions: 1.4.0.SP1
Reporter: Aaron Walker
Assigned To: Aaron Walker
Priority: Minor
Some message providers don't have a single base class the implements both the Queue
and Topic Connection Factories so you can't create a single JMSProviderLoader where
you can set the FactoryRef attribute to a single JNDI name. Really the Message bridge
should use the QueueFactoryRef or TopicFactoryRef attribute depending on the destination
type that the bridge is trying to connect to.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:07 p.m.
New subject: [JBoss JIRA] Commented: (JBMESSAGING-1183) Message Bridge use QueueFactoryRef or TopicFactoryRef instead of FactoryRef when looking up Source and Target Connection Factories
[ http://jira.jboss.com/jira/browse/JBMESSAGING-1183?page=comments#action_1... ]
Tim Fox commented on JBMESSAGING-1183:
--------------------------------------
Is it a JMS 1.1 or a JMS 1.0 implementation you are trying to use the bridge with?
Message Bridge use QueueFactoryRef or TopicFactoryRef instead of
FactoryRef when looking up Source and Target Connection Factories
----------------------------------------------------------------------------------------------------------------------------------
Key: JBMESSAGING-1183
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-1183
Project: JBoss Messaging
Issue Type: Bug
Components: Messaging Core
Affects Versions: 1.4.0.SP1
Reporter: Aaron Walker
Assigned To: Aaron Walker
Priority: Minor
Some message providers don't have a single base class the implements both the Queue
and Topic Connection Factories so you can't create a single JMSProviderLoader where
you can set the FactoryRef attribute to a single JNDI name. Really the Message bridge
should use the QueueFactoryRef or TopicFactoryRef attribute depending on the destination
type that the bridge is trying to connect to.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:13 p.m.
New subject: [JBoss JIRA] Commented: (JBMESSAGING-1183) Message Bridge use QueueFactoryRef or TopicFactoryRef instead of FactoryRef when looking up Source and Target Connection Factories
[ http://jira.jboss.com/jira/browse/JBMESSAGING-1183?page=comments#action_1... ]
Tim Fox commented on JBMESSAGING-1183:
--------------------------------------
Also how are you getting references to sourceDest and targetDest?
Message Bridge use QueueFactoryRef or TopicFactoryRef instead of
FactoryRef when looking up Source and Target Connection Factories
----------------------------------------------------------------------------------------------------------------------------------
Key: JBMESSAGING-1183
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-1183
Project: JBoss Messaging
Issue Type: Bug
Components: Messaging Core
Affects Versions: 1.4.0.SP1
Reporter: Aaron Walker
Assigned To: Aaron Walker
Priority: Minor
Some message providers don't have a single base class the implements both the Queue
and Topic Connection Factories so you can't create a single JMSProviderLoader where
you can set the FactoryRef attribute to a single JNDI name. Really the Message bridge
should use the QueueFactoryRef or TopicFactoryRef attribute depending on the destination
type that the bridge is trying to connect to.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:18 p.m.
New subject: [JBoss JIRA] Updated: (JBMESSAGING-1183) Message Bridge use QueueFactoryRef or TopicFactoryRef instead of FactoryRef when looking up Source and Target Connection Factories
[ http://jira.jboss.com/jira/browse/JBMESSAGING-1183?page=all ]
Tim Fox updated JBMESSAGING-1183:
---------------------------------
Fix Version/s: Stable branch
I think it's just too late to get this in SP2, but it should go in the next cumulative
patch.
Message Bridge use QueueFactoryRef or TopicFactoryRef instead of
FactoryRef when looking up Source and Target Connection Factories
----------------------------------------------------------------------------------------------------------------------------------
Key: JBMESSAGING-1183
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-1183
Project: JBoss Messaging
Issue Type: Bug
Components: Messaging Core
Affects Versions: 1.4.0.SP1
Reporter: Aaron Walker
Assigned To: Aaron Walker
Priority: Minor
Fix For: Stable branch
Some message providers don't have a single base class the implements both the Queue
and Topic Connection Factories so you can't create a single JMSProviderLoader where
you can set the FactoryRef attribute to a single JNDI name. Really the Message bridge
should use the QueueFactoryRef or TopicFactoryRef attribute depending on the destination
type that the bridge is trying to connect to.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:40 p.m.
New subject: [JBoss JIRA] Commented: (JBMESSAGING-1183) Message Bridge use QueueFactoryRef or TopicFactoryRef instead of FactoryRef when looking up Source and Target Connection Factories
[ http://jira.jboss.com/jira/browse/JBMESSAGING-1183?page=comments#action_1... ]
Aaron Walker commented on JBMESSAGING-1183:
-------------------------------------------
It's JMS 1.1 but it's Websphere MQ ;)
The WSMQ destinations and connection factories get bound into JNDI using a custom MBean
that use the IBM API to create them
But if you use the WSMQ JCA adpater you end with the same result. Separate Queue and Topic
connection factories.
Also if you want to maintain backward compatibility the you should use the FactoyRef if
it's set otherwise check the destination type.
Message Bridge use QueueFactoryRef or TopicFactoryRef instead of
FactoryRef when looking up Source and Target Connection Factories
----------------------------------------------------------------------------------------------------------------------------------
Key: JBMESSAGING-1183
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-1183
Project: JBoss Messaging
Issue Type: Bug
Components: Messaging Core
Affects Versions: 1.4.0.SP1
Reporter: Aaron Walker
Assigned To: Aaron Walker
Priority: Minor
Fix For: Stable branch
Some message providers don't have a single base class the implements both the Queue
and Topic Connection Factories so you can't create a single JMSProviderLoader where
you can set the FactoryRef attribute to a single JNDI name. Really the Message bridge
should use the QueueFactoryRef or TopicFactoryRef attribute depending on the destination
type that the bridge is trying to connect to.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:02 a.m.
New subject: [JBoss JIRA] Commented: (JBMESSAGING-1183) Message Bridge use QueueFactoryRef or TopicFactoryRef instead of FactoryRef when looking up Source and Target Connection Factories
[ http://jira.jboss.com/jira/browse/JBMESSAGING-1183?page=comments#action_1... ]
Tim Fox commented on JBMESSAGING-1183:
--------------------------------------
Aaron - please feel free to commit on Branch_Stable and TRUNK. It's ok to do so now
since I have cut the 1.4.0.SP2 release.
Might need to update the bridge example and any documentation that refers to the bridge
too.
Message Bridge use QueueFactoryRef or TopicFactoryRef instead of
FactoryRef when looking up Source and Target Connection Factories
----------------------------------------------------------------------------------------------------------------------------------
Key: JBMESSAGING-1183
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-1183
Project: JBoss Messaging
Issue Type: Bug
Components: Messaging Core
Affects Versions: 1.4.0.SP1
Reporter: Aaron Walker
Assigned To: Aaron Walker
Priority: Minor
Fix For: Stable branch
Some message providers don't have a single base class the implements both the Queue
and Topic Connection Factories so you can't create a single JMSProviderLoader where
you can set the FactoryRef attribute to a single JNDI name. Really the Message bridge
should use the QueueFactoryRef or TopicFactoryRef attribute depending on the destination
type that the bridge is trying to connect to.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:43 p.m.
New subject: [JBoss JIRA] Updated: (JBMESSAGING-1183) Message Bridge use QueueFactoryRef or TopicFactoryRef instead of FactoryRef when looking up Source and Target Connection Factories
[ http://jira.jboss.com/jira/browse/JBMESSAGING-1183?page=all ]
Tim Fox updated JBMESSAGING-1183:
---------------------------------
Fix Version/s: 1.4.0.SP3.CP01
Message Bridge use QueueFactoryRef or TopicFactoryRef instead of
FactoryRef when looking up Source and Target Connection Factories
----------------------------------------------------------------------------------------------------------------------------------
Key: JBMESSAGING-1183
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-1183
Project: JBoss Messaging
Issue Type: Bug
Components: Messaging Core
Affects Versions: 1.4.0.SP1
Reporter: Aaron Walker
Assigned To: Aaron Walker
Priority: Minor
Fix For: Stable branch, 1.4.0.SP3.CP01
Some message providers don't have a single base class the implements both the Queue
and Topic Connection Factories so you can't create a single JMSProviderLoader where
you can set the FactoryRef attribute to a single JNDI name. Really the Message bridge
should use the QueueFactoryRef or TopicFactoryRef attribute depending on the destination
type that the bridge is trying to connect to.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:27 p.m.
New subject: [JBoss JIRA] Assigned: (JBMESSAGING-1183) Message Bridge use QueueFactoryRef or TopicFactoryRef instead of FactoryRef when looking up Source and Target Connection Factories
[ http://jira.jboss.com/jira/browse/JBMESSAGING-1183?page=all ]
Jeff Mesnil reassigned JBMESSAGING-1183:
----------------------------------------
Assignee: Jeff Mesnil (was: Aaron Walker)
Message Bridge use QueueFactoryRef or TopicFactoryRef instead of
FactoryRef when looking up Source and Target Connection Factories
----------------------------------------------------------------------------------------------------------------------------------
Key: JBMESSAGING-1183
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-1183
Project: JBoss Messaging
Issue Type: Bug
Components: Messaging Core
Affects Versions: 1.4.0.SP1
Reporter: Aaron Walker
Assigned To: Jeff Mesnil
Priority: Minor
Fix For: Stable branch, 1.4.0.SP3.CP01
Some message providers don't have a single base class the implements both the Queue
and Topic Connection Factories so you can't create a single JMSProviderLoader where
you can set the FactoryRef attribute to a single JNDI name. Really the Message bridge
should use the QueueFactoryRef or TopicFactoryRef attribute depending on the destination
type that the bridge is trying to connect to.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:32 p.m.
New subject: [JBoss JIRA] Updated: (JBMESSAGING-1183) Message Bridge use QueueFactoryRef or TopicFactoryRef instead of FactoryRef when looking up Source and Target Connection Factories
[ http://jira.jboss.com/jira/browse/JBMESSAGING-1183?page=all ]
Tim Fox updated JBMESSAGING-1183:
---------------------------------
Fix Version/s: 1.4.1.beta2
(was: Stable branch)
Message Bridge use QueueFactoryRef or TopicFactoryRef instead of
FactoryRef when looking up Source and Target Connection Factories
----------------------------------------------------------------------------------------------------------------------------------
Key: JBMESSAGING-1183
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-1183
Project: JBoss Messaging
Issue Type: Bug
Components: Messaging Core
Affects Versions: 1.4.0.SP1
Reporter: Aaron Walker
Assigned To: Jeff Mesnil
Priority: Minor
Fix For: 1.4.0.SP3.CP01, 1.4.1.beta2
Some message providers don't have a single base class the implements both the Queue
and Topic Connection Factories so you can't create a single JMSProviderLoader where
you can set the FactoryRef attribute to a single JNDI name. Really the Message bridge
should use the QueueFactoryRef or TopicFactoryRef attribute depending on the destination
type that the bridge is trying to connect to.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:36 p.m.
New subject: [JBoss JIRA] Resolved: (JBMESSAGING-1183) Message Bridge use QueueFactoryRef or TopicFactoryRef instead of FactoryRef when looking up Source and Target Connection Factories
[ http://jira.jboss.com/jira/browse/JBMESSAGING-1183?page=all ]
Jeff Mesnil resolved JBMESSAGING-1183.
--------------------------------------
Resolution: Done
- committed in Branch_Stable (r3768) for version 1.4.1.beta2
- merged in JBossMessaging_1_4_0_SP3_CP (r3770) from r3768 for version 1.4.0.SP3.CP02
( also committed in trunk for JBM 2.0 (r3771) but kept the code commented)
Message Bridge use QueueFactoryRef or TopicFactoryRef instead of
FactoryRef when looking up Source and Target Connection Factories
----------------------------------------------------------------------------------------------------------------------------------
Key: JBMESSAGING-1183
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-1183
Project: JBoss Messaging
Issue Type: Bug
Components: Messaging Core
Affects Versions: 1.4.0.SP1
Reporter: Aaron Walker
Assigned To: Jeff Mesnil
Priority: Minor
Fix For: 1.4.0.SP3.CP02, 1.4.1.beta2
Some message providers don't have a single base class the implements both the Queue
and Topic Connection Factories so you can't create a single JMSProviderLoader where
you can set the FactoryRef attribute to a single JNDI name. Really the Message bridge
should use the QueueFactoryRef or TopicFactoryRef attribute depending on the destination
type that the bridge is trying to connect to.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:52 a.m.
New subject: [JBoss JIRA] Closed: (JBMESSAGING-1183) Message Bridge use QueueFactoryRef or TopicFactoryRef instead of FactoryRef when looking up Source and Target Connection Factories
[
https://jira.jboss.org/jira/browse/JBMESSAGING-1183?page=com.atlassian.ji...
]
Tim Fox closed JBMESSAGING-1183.
--------------------------------
Message Bridge use QueueFactoryRef or TopicFactoryRef instead of
FactoryRef when looking up Source and Target Connection Factories
----------------------------------------------------------------------------------------------------------------------------------
Key: JBMESSAGING-1183
URL: https://jira.jboss.org/jira/browse/JBMESSAGING-1183
Project: JBoss Messaging
Issue Type: Bug
Components: Messaging Core
Affects Versions: 1.4.0.SP1
Reporter: Aaron Walker
Assignee: Jeff Mesnil
Priority: Minor
Fix For: 1.4.0.SP3.CP02, 1.4.1.CR1
Some message providers don't have a single base class the implements both the Queue
and Topic Connection Factories so you can't create a single JMSProviderLoader where
you can set the FactoryRef attribute to a single JNDI name. Really the Message bridge
should use the QueueFactoryRef or TopicFactoryRef attribute depending on the destination
type that the bridge is trying to connect to.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5838
days inactive
6133
days old
13 comments
3 participants
participants (3)
-
Aaron Walker (JIRA) -
Jeff Mesnil (JIRA)
-
Tim Fox (JIRA)