8:25 p.m.
ENCRYPT debug log prints "hex" output in ambiguous format
---------------------------------------------------------
Key: JGRP-1100
URL: https://jira.jboss.org/jira/browse/JGRP-1100
Project: JGroups
Issue Type: Bug
Affects Versions: 2.4.7
Reporter: Dennis Reed
Assignee: Dennis Reed
ENCRYPT.formatArray doesn't convert a byte array straight to hex.
It leaves off any leading 0 in a byte and appends ffffff in front of any negative byte.
This prevents the original data from easily being reconstructed from the log for debugging
purposes.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:17 p.m.
New subject: [JBoss JIRA] Commented: (JGRP-1100) ENCRYPT debug log prints "hex" output in ambiguous format
[
https://issues.jboss.org/browse/JGRP-1100?page=com.atlassian.jira.plugin....
]
Bela Ban commented on JGRP-1100:
--------------------------------
Is this issue still relevant ? In other words, do you want to assign it to a release, or
close it ? If it is the former, I'll create a new 2.4.x release
ENCRYPT debug log prints "hex" output in ambiguous format
---------------------------------------------------------
Key: JGRP-1100
URL: https://issues.jboss.org/browse/JGRP-1100
Project: JGroups
Issue Type: Bug
Affects Versions: 2.4.7
Reporter: Dennis Reed
Assignee: Dennis Reed
ENCRYPT.formatArray doesn't convert a byte array straight to hex.
It leaves off any leading 0 in a byte and appends ffffff in front of any negative byte.
This prevents the original data from easily being reconstructed from the log for
debugging purposes.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:39 p.m.
New subject: [JBoss JIRA] Commented: (JGRP-1100) ENCRYPT debug log prints "hex" output in ambiguous format
[
https://issues.jboss.org/browse/JGRP-1100?page=com.atlassian.jira.plugin....
]
Dennis Reed commented on JGRP-1100:
-----------------------------------
It's still valid. The debug data printed by formatArray can't be used to get the
original bytes.
I believe it applies to all JGroups versions.
ENCRYPT debug log prints "hex" output in ambiguous format
---------------------------------------------------------
Key: JGRP-1100
URL: https://issues.jboss.org/browse/JGRP-1100
Project: JGroups
Issue Type: Bug
Affects Versions: 2.4.7
Reporter: Dennis Reed
Assignee: Dennis Reed
ENCRYPT.formatArray doesn't convert a byte array straight to hex.
It leaves off any leading 0 in a byte and appends ffffff in front of any negative byte.
This prevents the original data from easily being reconstructed from the log for
debugging purposes.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:43 p.m.
New subject: [JBoss JIRA] Updated: (JGRP-1100) ENCRYPT debug log prints "hex" output in ambiguous format
[
https://issues.jboss.org/browse/JGRP-1100?page=com.atlassian.jira.plugin....
]
Bela Ban updated JGRP-1100:
---------------------------
Fix Version/s: 2.4.10
2.12
OK, I created 2.4.10, and set the fix version to 2.4.10 and 2.12. You're still the
assignee...
ENCRYPT debug log prints "hex" output in ambiguous format
---------------------------------------------------------
Key: JGRP-1100
URL: https://issues.jboss.org/browse/JGRP-1100
Project: JGroups
Issue Type: Bug
Affects Versions: 2.4.7
Reporter: Dennis Reed
Assignee: Dennis Reed
Fix For: 2.4.10, 2.12
ENCRYPT.formatArray doesn't convert a byte array straight to hex.
It leaves off any leading 0 in a byte and appends ffffff in front of any negative byte.
This prevents the original data from easily being reconstructed from the log for
debugging purposes.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:46 p.m.
New subject: [JBoss JIRA] Commented: (JGRP-1100) ENCRYPT debug log prints "hex" output in ambiguous format
[
https://issues.jboss.org/browse/JGRP-1100?page=com.atlassian.jira.plugin....
]
Bela Ban commented on JGRP-1100:
--------------------------------
Question is should we remove formatArray() ? because it is only used to print out a key
when logging is enabled, and I think we should *not* print out that key anyway ! Not sure
but this one-way hashing of the key is probably not very safe, so folks with access to the
key can reverse engineer the key ?
ENCRYPT debug log prints "hex" output in ambiguous format
---------------------------------------------------------
Key: JGRP-1100
URL: https://issues.jboss.org/browse/JGRP-1100
Project: JGroups
Issue Type: Bug
Affects Versions: 2.4.7
Reporter: Dennis Reed
Assignee: Dennis Reed
Fix For: 2.4.10, 2.12
ENCRYPT.formatArray doesn't convert a byte array straight to hex.
It leaves off any leading 0 in a byte and appends ffffff in front of any negative byte.
This prevents the original data from easily being reconstructed from the log for
debugging purposes.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:46 p.m.
New subject: [JBoss JIRA] Issue Comment Edited: (JGRP-1100) ENCRYPT debug log prints "hex" output in ambiguous format
[
https://issues.jboss.org/browse/JGRP-1100?page=com.atlassian.jira.plugin....
]
Bela Ban edited comment on JGRP-1100 at 12/10/10 10:45 AM:
-----------------------------------------------------------
Question is should we remove formatArray() ? because it is only used to print out a key
when logging is enabled, and I think we should *not* print out that key anyway ! Not sure
but this one-way hashing of the key is probably not very safe, so folks with access to the
code can reverse engineer the key ?
was (Author: bela(a)jboss.com):
Question is should we remove formatArray() ? because it is only used to print out a
key when logging is enabled, and I think we should *not* print out that key anyway ! Not
sure but this one-way hashing of the key is probably not very safe, so folks with access
to the key can reverse engineer the key ?
ENCRYPT debug log prints "hex" output in ambiguous format
---------------------------------------------------------
Key: JGRP-1100
URL: https://issues.jboss.org/browse/JGRP-1100
Project: JGroups
Issue Type: Bug
Affects Versions: 2.4.7
Reporter: Dennis Reed
Assignee: Dennis Reed
Fix For: 2.4.10, 2.12
ENCRYPT.formatArray doesn't convert a byte array straight to hex.
It leaves off any leading 0 in a byte and appends ffffff in front of any negative byte.
This prevents the original data from easily being reconstructed from the log for
debugging purposes.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:59 p.m.
New subject: [JBoss JIRA] Commented: (JGRP-1100) ENCRYPT debug log prints "hex" output in ambiguous format
[
https://issues.jboss.org/browse/JGRP-1100?page=com.atlassian.jira.plugin....
]
Dennis Reed commented on JGRP-1100:
-----------------------------------
Being able to see the value of the key can be very useful in debugging a problem in
ENCRYPT.
(That's when I ran across this bug in formatArray).
Although it's certainly not something you want logged unless you're debugging
ENCRYPT.
ENCRYPT debug log prints "hex" output in ambiguous format
---------------------------------------------------------
Key: JGRP-1100
URL: https://issues.jboss.org/browse/JGRP-1100
Project: JGroups
Issue Type: Bug
Affects Versions: 2.4.7
Reporter: Dennis Reed
Assignee: Dennis Reed
Fix For: 2.4.10, 2.12
ENCRYPT.formatArray doesn't convert a byte array straight to hex.
It leaves off any leading 0 in a byte and appends ffffff in front of any negative byte.
This prevents the original data from easily being reconstructed from the log for
debugging purposes.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:41 a.m.
New subject: [JBoss JIRA] Commented: (JGRP-1100) ENCRYPT debug log prints "hex" output in ambiguous format
[
https://issues.jboss.org/browse/JGRP-1100?page=com.atlassian.jira.plugin....
]
Bela Ban commented on JGRP-1100:
--------------------------------
Ok. Are you going to fix it ?
ENCRYPT debug log prints "hex" output in ambiguous format
---------------------------------------------------------
Key: JGRP-1100
URL: https://issues.jboss.org/browse/JGRP-1100
Project: JGroups
Issue Type: Bug
Affects Versions: 2.4.7
Reporter: Dennis Reed
Assignee: Dennis Reed
Fix For: 2.4.10, 2.12
ENCRYPT.formatArray doesn't convert a byte array straight to hex.
It leaves off any leading 0 in a byte and appends ffffff in front of any negative byte.
This prevents the original data from easily being reconstructed from the log for
debugging purposes.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:37 p.m.
New subject: [JBoss JIRA] Commented: (JGRP-1100) ENCRYPT debug log prints "hex" output in ambiguous format
[
https://issues.jboss.org/browse/JGRP-1100?page=com.atlassian.jira.plugin....
]
Dennis Reed commented on JGRP-1100:
-----------------------------------
Feel free to fix it if you want.
It shouldn't take long, but it's currently way down on my TODO list.
ENCRYPT debug log prints "hex" output in ambiguous format
---------------------------------------------------------
Key: JGRP-1100
URL: https://issues.jboss.org/browse/JGRP-1100
Project: JGroups
Issue Type: Bug
Affects Versions: 2.4.7
Reporter: Dennis Reed
Assignee: Dennis Reed
Fix For: 2.4.10, 2.12
ENCRYPT.formatArray doesn't convert a byte array straight to hex.
It leaves off any leading 0 in a byte and appends ffffff in front of any negative byte.
This prevents the original data from easily being reconstructed from the log for
debugging purposes.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:45 p.m.
New subject: [JBoss JIRA] Updated: (JGRP-1100) ENCRYPT debug log prints "hex" output in ambiguous format
[
https://issues.jboss.org/browse/JGRP-1100?page=com.atlassian.jira.plugin....
]
Bela Ban updated JGRP-1100:
---------------------------
Fix Version/s: 3.x
(was: 2.12)
ENCRYPT debug log prints "hex" output in ambiguous format
---------------------------------------------------------
Key: JGRP-1100
URL: https://issues.jboss.org/browse/JGRP-1100
Project: JGroups
Issue Type: Bug
Affects Versions: 2.4.7
Reporter: Dennis Reed
Assignee: Dennis Reed
Fix For: 2.4.10, 3.x
ENCRYPT.formatArray doesn't convert a byte array straight to hex.
It leaves off any leading 0 in a byte and appends ffffff in front of any negative byte.
This prevents the original data from easily being reconstructed from the log for
debugging purposes.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:45 p.m.
New subject: [JBoss JIRA] Commented: (JGRP-1100) ENCRYPT debug log prints "hex" output in ambiguous format
[
https://issues.jboss.org/browse/JGRP-1100?page=com.atlassian.jira.plugin....
]
Bela Ban commented on JGRP-1100:
--------------------------------
I'll move it to 3.x (/dev/null) then...
ENCRYPT debug log prints "hex" output in ambiguous format
---------------------------------------------------------
Key: JGRP-1100
URL: https://issues.jboss.org/browse/JGRP-1100
Project: JGroups
Issue Type: Bug
Affects Versions: 2.4.7
Reporter: Dennis Reed
Assignee: Dennis Reed
Fix For: 2.4.10, 3.x
ENCRYPT.formatArray doesn't convert a byte array straight to hex.
It leaves off any leading 0 in a byte and appends ffffff in front of any negative byte.
This prevents the original data from easily being reconstructed from the log for
debugging purposes.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:10 p.m.
New subject: [JBoss JIRA] (JGRP-1100) ENCRYPT debug log prints "hex" output in ambiguous format
[
https://issues.jboss.org/browse/JGRP-1100?page=com.atlassian.jira.plugin....
]
Bela Ban updated JGRP-1100:
---------------------------
Fix Version/s: 3.0
(was: 3.x)
(was: 2.4.10)
Moving to 3.0
ENCRYPT debug log prints "hex" output in ambiguous format
---------------------------------------------------------
Key: JGRP-1100
URL: https://issues.jboss.org/browse/JGRP-1100
Project: JGroups
Issue Type: Bug
Affects Versions: 2.4.7
Reporter: Dennis Reed
Assignee: Dennis Reed
Fix For: 3.0
ENCRYPT.formatArray doesn't convert a byte array straight to hex.
It leaves off any leading 0 in a byte and appends ffffff in front of any negative byte.
This prevents the original data from easily being reconstructed from the log for
debugging purposes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:12 p.m.
New subject: [JBoss JIRA] (JGRP-1100) ENCRYPT debug log prints "hex" output in ambiguous format
[
https://issues.jboss.org/browse/JGRP-1100?page=com.atlassian.jira.plugin....
]
Bela Ban resolved JGRP-1100.
----------------------------
Fix Version/s: 2.4.10
Resolution: Done
OK, I removed formatArray() from ENCRYPT. IMO, it's bad to log the secret key anyway:
someone could enable logging for ENCRYPT dynamically (e.g. probe.sh
op=ENCRYPT.setLevel["debug"]) and would then know the secret shared key...
ENCRYPT debug log prints "hex" output in ambiguous format
---------------------------------------------------------
Key: JGRP-1100
URL: https://issues.jboss.org/browse/JGRP-1100
Project: JGroups
Issue Type: Bug
Affects Versions: 2.4.7
Reporter: Dennis Reed
Assignee: Dennis Reed
Fix For: 2.4.10, 3.0
ENCRYPT.formatArray doesn't convert a byte array straight to hex.
It leaves off any leading 0 in a byte and appends ffffff in front of any negative byte.
This prevents the original data from easily being reconstructed from the log for
debugging purposes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4639
days inactive
5343
days old
12 comments
4 participants
participants (4)
-
Bela Ban (JIRA) -
Bela Ban (Resolved) (JIRA)
-
Bela Ban (Updated) (JIRA)
-
Dennis Reed (JIRA)