3:17 a.m.
Proxy serialization looses inner data objects
---------------------------------------------
Key: JASSIST-42
URL: http://jira.jboss.com/jira/browse/JASSIST-42
Project: Javassist
Issue Type: Bug
Reporter: Damien Lecan
Assigned To: Shigeru Chiba
Priority: Blocker
I working with proxies build with ProxyFactory method.
When I want to serialize/deserialize it, everything seems to be ok except that only proxy
instance is serialized, not inner objects.
Eg.
Object "A" contains an instance of "B"
After serialization/deserialization of a proxy of A, instance of "B" in
"A" is null
When I look at this code :
public static SerializedProxy makeSerializedProxy(Object proxy)
throws java.io.InvalidClassException
{
Class clazz = proxy.getClass();
return new SerializedProxy(clazz, ProxyFactory.getFilter(clazz),
ProxyFactory.getHandler(clazz));
}
I don't understand how serialization can keep inner objects ...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:03 a.m.
New subject: [JBoss JIRA] Commented: (JASSIST-42) Proxy serialization looses inner data objects
[
https://jira.jboss.org/jira/browse/JASSIST-42?page=com.atlassian.jira.plu...
]
David Lloyd commented on JASSIST-42:
------------------------------------
This is indeed a very nefarious problem, however it is not unsolvable. You could solve it
in a couple of ways:
1) The logic that serialization implements is well-defined; you could continue to use a
serialized proxy via writeReplace; however, on the write side, use reflection to store all
superclass field values into an array in the proxy, duplicating the logic of Java
Serialization. On the read side, the readResolve of the serialized proxy object would
then use the same sun.reflect.ReflectionFactory that Java Serialization uses to create new
instances, and then would use reflection to populate all the fields, exactly as
ObjectInputStream would. The disadvantage is that any field value which refers to an
object which refers back to the original proxy will have an invalid reference, and would
cause an exception on deserialization; and of course, this represents a fairly substantial
coding effort besides.
2) Require the use of special class annotation/resolver logic by way of
java.io.ObjectOutputStream#annotateClass() and java.io.ObjectInputStream#resolveClass().
The logic in annotateClass() would write out an identifying byte marking the class as a
Javassist proxy, followed by the superclass and the list of the proxy's implemented
interfaces. The logic in resolveClass() would read this data and use the
ProxyFactory's createClass() method to get the (possibly cached) class object if it is
present. Then, the proxy need only implement Serializable or Externalizable, like any
object, and everything will work perfectly in all cases; the solution is essentially
bulletproof, apart from the disadvantage of requiring the customized subclasses. This
could, however, be easily accomplished by way of a pair of static methods in a utility
class, so the burden to the user should be minimal compared to the gain.
Proxy serialization looses inner data objects
---------------------------------------------
Key: JASSIST-42
URL: https://jira.jboss.org/jira/browse/JASSIST-42
Project: Javassist
Issue Type: Bug
Reporter: Damien Lecan
Assignee: Shigeru Chiba
Priority: Blocker
I working with proxies build with ProxyFactory method.
When I want to serialize/deserialize it, everything seems to be ok except that only proxy
instance is serialized, not inner objects.
Eg.
Object "A" contains an instance of "B"
After serialization/deserialization of a proxy of A, instance of "B" in
"A" is null
When I look at this code :
public static SerializedProxy makeSerializedProxy(Object proxy)
throws java.io.InvalidClassException
{
Class clazz = proxy.getClass();
return new SerializedProxy(clazz, ProxyFactory.getFilter(clazz),
ProxyFactory.getHandler(clazz));
}
I don't understand how serialization can keep inner objects ...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:09 a.m.
New subject: [JBoss JIRA] Commented: (JASSIST-42) Proxy serialization looses inner data objects
[
https://jira.jboss.org/jira/browse/JASSIST-42?page=com.atlassian.jira.plu...
]
David Lloyd commented on JASSIST-42:
------------------------------------
An additional comment to #2 - you'll definitely want to make sure you always use a
constant value (like 0 or -1) for the generated class' serialVersionUID field. Also,
you may need to take steps to ensure that the generated class on the receiving side has
the same package and name as the originating class; there is some check there but I
don't recall if it is on the sending or receiving side, and what the exact restriction
is.
Proxy serialization looses inner data objects
---------------------------------------------
Key: JASSIST-42
URL: https://jira.jboss.org/jira/browse/JASSIST-42
Project: Javassist
Issue Type: Bug
Reporter: Damien Lecan
Assignee: Shigeru Chiba
Priority: Blocker
I working with proxies build with ProxyFactory method.
When I want to serialize/deserialize it, everything seems to be ok except that only proxy
instance is serialized, not inner objects.
Eg.
Object "A" contains an instance of "B"
After serialization/deserialization of a proxy of A, instance of "B" in
"A" is null
When I look at this code :
public static SerializedProxy makeSerializedProxy(Object proxy)
throws java.io.InvalidClassException
{
Class clazz = proxy.getClass();
return new SerializedProxy(clazz, ProxyFactory.getFilter(clazz),
ProxyFactory.getHandler(clazz));
}
I don't understand how serialization can keep inner objects ...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:32 p.m.
New subject: [JBoss JIRA] Commented: (JASSIST-42) Proxy serialization looses inner data objects
[
https://jira.jboss.org/jira/browse/JASSIST-42?page=com.atlassian.jira.plu...
]
David Lloyd commented on JASSIST-42:
------------------------------------
Designing Javassist proxies to rely on readResolve()/writeReplace() was a mistake for a
few reasons.
1) The design of SerializedProxy is insufficiently flexible, as it makes a number of
assumptions about the serializable proxy (for example, that it has no significant
serializable state).
2) Proxy type superclasses cannot define their own readResolve/writeReplace methods; at
best it simply won't work; at worst it could result in VerifyError since the
superclass's writeReplace might have too restrictive of an access level or a final
modifier.
3) It is impossible to use a secondary mechanism, like special class annotation, to make
traditional serialization work properly because the proxy's writeReplace will cause
serialization to be bypassed in any case.
If there is an option to globally disable writeReplace/SerializableProxy somehow, then the
ObjectOutputStream subclass idea will solve all three of the above issues and would
suffice to allow proxy serialization in a 100% compliant fashion, with a minimum of coding
effort required.
Proxy serialization looses inner data objects
---------------------------------------------
Key: JASSIST-42
URL: https://jira.jboss.org/jira/browse/JASSIST-42
Project: Javassist
Issue Type: Bug
Reporter: Damien Lecan
Assignee: Shigeru Chiba
Priority: Blocker
I working with proxies build with ProxyFactory method.
When I want to serialize/deserialize it, everything seems to be ok except that only proxy
instance is serialized, not inner objects.
Eg.
Object "A" contains an instance of "B"
After serialization/deserialization of a proxy of A, instance of "B" in
"A" is null
When I look at this code :
public static SerializedProxy makeSerializedProxy(Object proxy)
throws java.io.InvalidClassException
{
Class clazz = proxy.getClass();
return new SerializedProxy(clazz, ProxyFactory.getFilter(clazz),
ProxyFactory.getHandler(clazz));
}
I don't understand how serialization can keep inner objects ...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:19 a.m.
New subject: [JBoss JIRA] Commented: (JASSIST-42) Proxy serialization looses inner data objects
[
https://jira.jboss.org/jira/browse/JASSIST-42?page=com.atlassian.jira.plu...
]
Andrew Dinn commented on JASSIST-42:
------------------------------------
See the developer forum for a proposed solution to this problem.
http://community.jboss.org/thread/149524
Proxy serialization looses inner data objects
---------------------------------------------
Key: JASSIST-42
URL: https://jira.jboss.org/jira/browse/JASSIST-42
Project: Javassist
Issue Type: Bug
Reporter: Damien Lecan
Assignee: Shigeru Chiba
Priority: Blocker
I working with proxies build with ProxyFactory method.
When I want to serialize/deserialize it, everything seems to be ok except that only proxy
instance is serialized, not inner objects.
Eg.
Object "A" contains an instance of "B"
After serialization/deserialization of a proxy of A, instance of "B" in
"A" is null
When I look at this code :
public static SerializedProxy makeSerializedProxy(Object proxy)
throws java.io.InvalidClassException
{
Class clazz = proxy.getClass();
return new SerializedProxy(clazz, ProxyFactory.getFilter(clazz),
ProxyFactory.getHandler(clazz));
}
I don't understand how serialization can keep inner objects ...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:29 p.m.
New subject: [JBoss JIRA] Commented: (JASSIST-42) Proxy serialization looses inner data objects
[
https://jira.jboss.org/jira/browse/JASSIST-42?page=com.atlassian.jira.plu...
]
Andrew Dinn commented on JASSIST-42:
------------------------------------
I have attached a patch against the current trunk to the forum thread mentioned in my last
comment which
1) makes serialization use the cache correctly
2) provides an alternative way to serialize objects using subclasses
ProxyObjectOuptut/InputStream of classes ObjectOuptut/InputStream.
This patch requires a minor change to javassist clients. They must no longer call
ProxyFactory.setHandler(). Instead they must cast each newly created proxy instance to a
ProxyObject and call method setHandler() on the proxy instance.
Proxy serialization looses inner data objects
---------------------------------------------
Key: JASSIST-42
URL: https://jira.jboss.org/jira/browse/JASSIST-42
Project: Javassist
Issue Type: Bug
Reporter: Damien Lecan
Assignee: Shigeru Chiba
Priority: Blocker
I working with proxies build with ProxyFactory method.
When I want to serialize/deserialize it, everything seems to be ok except that only proxy
instance is serialized, not inner objects.
Eg.
Object "A" contains an instance of "B"
After serialization/deserialization of a proxy of A, instance of "B" in
"A" is null
When I look at this code :
public static SerializedProxy makeSerializedProxy(Object proxy)
throws java.io.InvalidClassException
{
Class clazz = proxy.getClass();
return new SerializedProxy(clazz, ProxyFactory.getFilter(clazz),
ProxyFactory.getHandler(clazz));
}
I don't understand how serialization can keep inner objects ...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3 a.m.
New subject: [JBoss JIRA] Commented: (JASSIST-42) Proxy serialization looses inner data objects
[
https://jira.jboss.org/jira/browse/JASSIST-42?page=com.atlassian.jira.plu...
]
Andrew Dinn commented on JASSIST-42:
------------------------------------
After talking to Chiba I have added one more refinement to this patch to avoid the
backwards compatibility problems. Method ProxyFactory.setHandler() is still retained but
has been deprecated. Existing code which uses the deprecated method will continue to work
as before but classes will not be cached. New code which follows the model for creating
and initialising proxies described in the javadoc for Proxyfactory will automatically
cache and reuse proxy classes.
If ProxyFactory.setHandler() is not called then the factory generates proxy classes
according to the new model. These classes do not install a handler for their instances and
they can be cached and reused safely. The client must use ProxyObject.setHandler() to
configure the handler for each instance.
If the client calls ProxyFactory.setHandler() with a non-null argument the factory
switches to generating proxy classes according to the old model i.e. the classes install
the supplied handler when they create their instances. The factory automatically disables
caching when this method is called.
Note that instances of old style classes can still be serialized/deserialized after this
fix. Furthermore, the patched deserialization code ensures that a new style class is used
(and hence cached and reused) for the deserialized instance, avoiding creation of
unnecessary proxy classes at deserialize.
Proxy serialization looses inner data objects
---------------------------------------------
Key: JASSIST-42
URL: https://jira.jboss.org/jira/browse/JASSIST-42
Project: Javassist
Issue Type: Bug
Reporter: Damien Lecan
Assignee: Shigeru Chiba
Priority: Blocker
I working with proxies build with ProxyFactory method.
When I want to serialize/deserialize it, everything seems to be ok except that only proxy
instance is serialized, not inner objects.
Eg.
Object "A" contains an instance of "B"
After serialization/deserialization of a proxy of A, instance of "B" in
"A" is null
When I look at this code :
public static SerializedProxy makeSerializedProxy(Object proxy)
throws java.io.InvalidClassException
{
Class clazz = proxy.getClass();
return new SerializedProxy(clazz, ProxyFactory.getFilter(clazz),
ProxyFactory.getHandler(clazz));
}
I don't understand how serialization can keep inner objects ...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:14 a.m.
New subject: [JBoss JIRA] Assigned: (JASSIST-42) Proxy serialization looses inner data objects
[
https://jira.jboss.org/jira/browse/JASSIST-42?page=com.atlassian.jira.plu...
]
Andrew Dinn reassigned JASSIST-42:
----------------------------------
Assignee: Andrew Dinn (was: Shigeru Chiba)
Proxy serialization looses inner data objects
---------------------------------------------
Key: JASSIST-42
URL: https://jira.jboss.org/jira/browse/JASSIST-42
Project: Javassist
Issue Type: Bug
Reporter: Damien Lecan
Assignee: Andrew Dinn
Priority: Blocker
I working with proxies build with ProxyFactory method.
When I want to serialize/deserialize it, everything seems to be ok except that only proxy
instance is serialized, not inner objects.
Eg.
Object "A" contains an instance of "B"
After serialization/deserialization of a proxy of A, instance of "B" in
"A" is null
When I look at this code :
public static SerializedProxy makeSerializedProxy(Object proxy)
throws java.io.InvalidClassException
{
Class clazz = proxy.getClass();
return new SerializedProxy(clazz, ProxyFactory.getFilter(clazz),
ProxyFactory.getHandler(clazz));
}
I don't understand how serialization can keep inner objects ...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:16 a.m.
New subject: [JBoss JIRA] Closed: (JASSIST-42) Proxy serialization looses inner data objects
[
https://jira.jboss.org/jira/browse/JASSIST-42?page=com.atlassian.jira.plu...
]
Andrew Dinn closed JASSIST-42.
------------------------------
Resolution: Done
Fixed caching problems and provided new serialize/deserialize model using subclasses
ProxyObjectOutputStream and ProxyObjectInputStream of, respectibely, ObjectOutputStream
and ObjectInputStream. See javadoc in ProxyFactory for details.
Added tests to check that old and new style proxy creation both work and that old and new
style serialization also both work.
Proxy serialization looses inner data objects
---------------------------------------------
Key: JASSIST-42
URL: https://jira.jboss.org/jira/browse/JASSIST-42
Project: Javassist
Issue Type: Bug
Reporter: Damien Lecan
Assignee: Andrew Dinn
Priority: Blocker
I working with proxies build with ProxyFactory method.
When I want to serialize/deserialize it, everything seems to be ok except that only proxy
instance is serialized, not inner objects.
Eg.
Object "A" contains an instance of "B"
After serialization/deserialization of a proxy of A, instance of "B" in
"A" is null
When I look at this code :
public static SerializedProxy makeSerializedProxy(Object proxy)
throws java.io.InvalidClassException
{
Class clazz = proxy.getClass();
return new SerializedProxy(clazz, ProxyFactory.getFilter(clazz),
ProxyFactory.getHandler(clazz));
}
I don't understand how serialization can keep inner objects ...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:18 a.m.
New subject: [JBoss JIRA] Closed: (JASSIST-42) Proxy serialization looses inner data objects
[
https://jira.jboss.org/jira/browse/JASSIST-42?page=com.atlassian.jira.plu...
]
Andrew Dinn closed JASSIST-42.
------------------------------
Resolution: Done
Proxy serialization looses inner data objects
---------------------------------------------
Key: JASSIST-42
URL: https://jira.jboss.org/jira/browse/JASSIST-42
Project: Javassist
Issue Type: Bug
Affects Versions: 3.11.0.GA
Reporter: Damien Lecan
Assignee: Andrew Dinn
Priority: Blocker
Fix For: 3.12.0.GA
I working with proxies build with ProxyFactory method.
When I want to serialize/deserialize it, everything seems to be ok except that only proxy
instance is serialized, not inner objects.
Eg.
Object "A" contains an instance of "B"
After serialization/deserialization of a proxy of A, instance of "B" in
"A" is null
When I look at this code :
public static SerializedProxy makeSerializedProxy(Object proxy)
throws java.io.InvalidClassException
{
Class clazz = proxy.getClass();
return new SerializedProxy(clazz, ProxyFactory.getFilter(clazz),
ProxyFactory.getHandler(clazz));
}
I don't understand how serialization can keep inner objects ...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:18 a.m.
New subject: [JBoss JIRA] Reopened: (JASSIST-42) Proxy serialization looses inner data objects
[
https://jira.jboss.org/jira/browse/JASSIST-42?page=com.atlassian.jira.plu...
]
Andrew Dinn reopened JASSIST-42:
--------------------------------
reopened to correct affects and fix versions
Proxy serialization looses inner data objects
---------------------------------------------
Key: JASSIST-42
URL: https://jira.jboss.org/jira/browse/JASSIST-42
Project: Javassist
Issue Type: Bug
Affects Versions: 3.11.0.GA
Reporter: Damien Lecan
Assignee: Andrew Dinn
Priority: Blocker
Fix For: 3.12.0.GA
I working with proxies build with ProxyFactory method.
When I want to serialize/deserialize it, everything seems to be ok except that only proxy
instance is serialized, not inner objects.
Eg.
Object "A" contains an instance of "B"
After serialization/deserialization of a proxy of A, instance of "B" in
"A" is null
When I look at this code :
public static SerializedProxy makeSerializedProxy(Object proxy)
throws java.io.InvalidClassException
{
Class clazz = proxy.getClass();
return new SerializedProxy(clazz, ProxyFactory.getFilter(clazz),
ProxyFactory.getHandler(clazz));
}
I don't understand how serialization can keep inner objects ...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:18 a.m.
New subject: [JBoss JIRA] Updated: (JASSIST-42) Proxy serialization looses inner data objects
[
https://jira.jboss.org/jira/browse/JASSIST-42?page=com.atlassian.jira.plu...
]
Andrew Dinn updated JASSIST-42:
-------------------------------
Fix Version/s: 3.12.0.GA
Affects Version/s: 3.11.0.GA
Proxy serialization looses inner data objects
---------------------------------------------
Key: JASSIST-42
URL: https://jira.jboss.org/jira/browse/JASSIST-42
Project: Javassist
Issue Type: Bug
Affects Versions: 3.11.0.GA
Reporter: Damien Lecan
Assignee: Andrew Dinn
Priority: Blocker
Fix For: 3.12.0.GA
I working with proxies build with ProxyFactory method.
When I want to serialize/deserialize it, everything seems to be ok except that only proxy
instance is serialized, not inner objects.
Eg.
Object "A" contains an instance of "B"
After serialization/deserialization of a proxy of A, instance of "B" in
"A" is null
When I look at this code :
public static SerializedProxy makeSerializedProxy(Object proxy)
throws java.io.InvalidClassException
{
Class clazz = proxy.getClass();
return new SerializedProxy(clazz, ProxyFactory.getFilter(clazz),
ProxyFactory.getHandler(clazz));
}
I don't understand how serialization can keep inner objects ...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5373
days inactive
6172
days old
11 comments
3 participants
participants (3)
-
Andrew Dinn (JIRA) -
Damien Lecan (JIRA)
-
David Lloyd (JIRA)