[JBoss JIRA] Created: (JBRULES-2559) Problem with Collect statement from a source that is a previous declaration after an OR'd group in MVEL dialect
11:01 a.m.
Problem with Collect statement from a source that is a previous declaration after an
OR'd group in MVEL dialect
---------------------------------------------------------------------------------------------------------------
Key: JBRULES-2559
URL: https://jira.jboss.org/browse/JBRULES-2559
Project: Drools
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: drools-core
Affects Versions: 5.1.0.M2
Reporter: Chris DeLashmutt
Assignee: Mark Proctor
When using a Collect statement that is sourced from a nested property of a bound pattern
and it follows an OR'd group of evals, the bound pattern seems to be pointing to the
wrong object in the tuple. I have attached a diff for drools-compiler that includes a new
test case in FirstOrderLogicTest and DRL that exhibits this problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:03 a.m.
New subject: [JBoss JIRA] Updated: (JBRULES-2559) Problem with Collect statement from a source that is a previous declaration after an OR'd group in MVEL dialect
[
https://jira.jboss.org/browse/JBRULES-2559?page=com.atlassian.jira.plugin...
]
Chris DeLashmutt updated JBRULES-2559:
--------------------------------------
Attachment: patch.txt
A patch to drools-compiler with the test case and drl exhibiting the problem.
Problem with Collect statement from a source that is a previous
declaration after an OR'd group in MVEL dialect
---------------------------------------------------------------------------------------------------------------
Key: JBRULES-2559
URL: https://jira.jboss.org/browse/JBRULES-2559
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.1.0.M2
Reporter: Chris DeLashmutt
Assignee: Mark Proctor
Attachments: patch.txt
When using a Collect statement that is sourced from a nested property of a bound pattern
and it follows an OR'd group of evals, the bound pattern seems to be pointing to the
wrong object in the tuple. I have attached a diff for drools-compiler that includes a new
test case in FirstOrderLogicTest and DRL that exhibits this problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:26 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2559) Problem with Collect statement from a source that is a previous declaration after an OR'd group in MVEL dialect
[
https://jira.jboss.org/browse/JBRULES-2559?page=com.atlassian.jira.plugin...
]
Chris DeLashmutt commented on JBRULES-2559:
-------------------------------------------
I added what I think is a proper clone implementation to MVELDataProvider, but now the
problem I'm seeing is that when MVELDataProvider is serialized, it doesn't save
the prototype and requiredDeclarations properties. It seems like those properties get
re-set properly via AbstractRuleBase's readExternal method when it calls
Package.getDialectRuntimeRegistry.onBeforeExecute() on all the packages. However,
ReteooBuilder seems to get it's own clones of the MVELDataProvider and it has no such
call to onBeforeExecute in it's readExternal method. I'll see if I can implement
something.
Problem with Collect statement from a source that is a previous
declaration after an OR'd group in MVEL dialect
---------------------------------------------------------------------------------------------------------------
Key: JBRULES-2559
URL: https://jira.jboss.org/browse/JBRULES-2559
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.1.0.M2
Reporter: Chris DeLashmutt
Assignee: Mark Proctor
Attachments: patch.txt
When using a Collect statement that is sourced from a nested property of a bound pattern
and it follows an OR'd group of evals, the bound pattern seems to be pointing to the
wrong object in the tuple. I have attached a diff for drools-compiler that includes a new
test case in FirstOrderLogicTest and DRL that exhibits this problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:25 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2559) Problem with Collect statement from a source that is a previous declaration after an OR'd group in MVEL dialect
[
https://jira.jboss.org/browse/JBRULES-2559?page=com.atlassian.jira.plugin...
]
Chris DeLashmutt commented on JBRULES-2559:
-------------------------------------------
After debugging a bit more it seems that the Rule references inside of ReteooBuilder and
Rete inside of ReteooRuleBase contain MVELDataProviders that _have_ been compiled. Still
searching for where this uncompiled MVELDataProvider is coming from.
Problem with Collect statement from a source that is a previous
declaration after an OR'd group in MVEL dialect
---------------------------------------------------------------------------------------------------------------
Key: JBRULES-2559
URL: https://jira.jboss.org/browse/JBRULES-2559
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.1.0.M2
Reporter: Chris DeLashmutt
Assignee: Mark Proctor
Attachments: patch.txt
When using a Collect statement that is sourced from a nested property of a bound pattern
and it follows an OR'd group of evals, the bound pattern seems to be pointing to the
wrong object in the tuple. I have attached a diff for drools-compiler that includes a new
test case in FirstOrderLogicTest and DRL that exhibits this problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:50 p.m.
New subject: [JBoss JIRA] Updated: (JBRULES-2559) Problem with Collect statement from a source that is a previous declaration after an OR'd group in MVEL dialect
[
https://jira.jboss.org/browse/JBRULES-2559?page=com.atlassian.jira.plugin...
]
Chris DeLashmutt updated JBRULES-2559:
--------------------------------------
Comment: was deleted
(was: After debugging a bit more it seems that the Rule references inside of ReteooBuilder
and Rete inside of ReteooRuleBase contain MVELDataProviders that _have_ been compiled.
Still searching for where this uncompiled MVELDataProvider is coming from.)
Problem with Collect statement from a source that is a previous
declaration after an OR'd group in MVEL dialect
---------------------------------------------------------------------------------------------------------------
Key: JBRULES-2559
URL: https://jira.jboss.org/browse/JBRULES-2559
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.1.0.M2
Reporter: Chris DeLashmutt
Assignee: Mark Proctor
Attachments: patch.txt
When using a Collect statement that is sourced from a nested property of a bound pattern
and it follows an OR'd group of evals, the bound pattern seems to be pointing to the
wrong object in the tuple. I have attached a diff for drools-compiler that includes a new
test case in FirstOrderLogicTest and DRL that exhibits this problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:07 p.m.
New subject: [JBoss JIRA] Updated: (JBRULES-2559) Problem with Collect statement from a source that is a previous declaration after an OR'd group in MVEL dialect
[
https://jira.jboss.org/browse/JBRULES-2559?page=com.atlassian.jira.plugin...
]
Chris DeLashmutt updated JBRULES-2559:
--------------------------------------
Comment: was deleted
(was: I added what I think is a proper clone implementation to MVELDataProvider, but now
the problem I'm seeing is that when MVELDataProvider is serialized, it doesn't
save the prototype and requiredDeclarations properties. It seems like those properties
get re-set properly via AbstractRuleBase's readExternal method when it calls
Package.getDialectRuntimeRegistry.onBeforeExecute() on all the packages. However,
ReteooBuilder seems to get it's own clones of the MVELDataProvider and it has no such
call to onBeforeExecute in it's readExternal method. I'll see if I can implement
something.)
Problem with Collect statement from a source that is a previous
declaration after an OR'd group in MVEL dialect
---------------------------------------------------------------------------------------------------------------
Key: JBRULES-2559
URL: https://jira.jboss.org/browse/JBRULES-2559
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.1.0.M2
Reporter: Chris DeLashmutt
Assignee: Mark Proctor
Attachments: patch.txt
When using a Collect statement that is sourced from a nested property of a bound pattern
and it follows an OR'd group of evals, the bound pattern seems to be pointing to the
wrong object in the tuple. I have attached a diff for drools-compiler that includes a new
test case in FirstOrderLogicTest and DRL that exhibits this problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:57 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2559) Problem with Collect statement from a source that is a previous declaration after an OR'd group in MVEL dialect
[
https://jira.jboss.org/browse/JBRULES-2559?page=com.atlassian.jira.plugin...
]
Chris DeLashmutt commented on JBRULES-2559:
-------------------------------------------
Following etirelli's lead in the fix for JBRULES-2482, I added a replaceDeclaration to
MVELDataProvider, and made LogicTransformer call it when it seems a From element.
However, now the problem I'm seeing is that the rule is activating twice! Continuing
to investigate.
Problem with Collect statement from a source that is a previous
declaration after an OR'd group in MVEL dialect
---------------------------------------------------------------------------------------------------------------
Key: JBRULES-2559
URL: https://jira.jboss.org/browse/JBRULES-2559
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.1.0.M2
Reporter: Chris DeLashmutt
Assignee: Mark Proctor
Attachments: patch.txt
When using a Collect statement that is sourced from a nested property of a bound pattern
and it follows an OR'd group of evals, the bound pattern seems to be pointing to the
wrong object in the tuple. I have attached a diff for drools-compiler that includes a new
test case in FirstOrderLogicTest and DRL that exhibits this problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:33 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2559) Problem with Collect statement from a source that is a previous declaration after an OR'd group in MVEL dialect
[
https://jira.jboss.org/browse/JBRULES-2559?page=com.atlassian.jira.plugin...
]
Chris DeLashmutt commented on JBRULES-2559:
-------------------------------------------
Another strange problem with this change I'm trying to make is that if I try to use
SerializationHelper.getSerialisedStatefulSession( wm ) in the test case, I'm getting
an NPE when the session is being deserialized on a LeftTuple constructor. The rightTuple
parameter to the constructor is null because no RightTuple could be found for the given
key in InputMarshaller around line 532.
Problem with Collect statement from a source that is a previous
declaration after an OR'd group in MVEL dialect
---------------------------------------------------------------------------------------------------------------
Key: JBRULES-2559
URL: https://jira.jboss.org/browse/JBRULES-2559
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.1.0.M2
Reporter: Chris DeLashmutt
Assignee: Mark Proctor
Attachments: patch.txt
When using a Collect statement that is sourced from a nested property of a bound pattern
and it follows an OR'd group of evals, the bound pattern seems to be pointing to the
wrong object in the tuple. I have attached a diff for drools-compiler that includes a new
test case in FirstOrderLogicTest and DRL that exhibits this problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:13 p.m.
New subject: [JBoss JIRA] Updated: (JBRULES-2559) Problem with Collect statement from a source that is a previous declaration after an OR'd group in MVEL dialect
[
https://jira.jboss.org/browse/JBRULES-2559?page=com.atlassian.jira.plugin...
]
Chris DeLashmutt updated JBRULES-2559:
--------------------------------------
Attachment: (was: patch.txt)
Problem with Collect statement from a source that is a previous
declaration after an OR'd group in MVEL dialect
---------------------------------------------------------------------------------------------------------------
Key: JBRULES-2559
URL: https://jira.jboss.org/browse/JBRULES-2559
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.1.0.M2
Reporter: Chris DeLashmutt
Assignee: Mark Proctor
When using a Collect statement that is sourced from a nested property of a bound pattern
and it follows an OR'd group of evals, the bound pattern seems to be pointing to the
wrong object in the tuple. I have attached a diff for drools-compiler that includes a new
test case in FirstOrderLogicTest and DRL that exhibits this problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:15 p.m.
New subject: [JBoss JIRA] Updated: (JBRULES-2559) Problem with Collect statement from a source that is a previous declaration after an OR'd group in MVEL dialect
[
https://jira.jboss.org/browse/JBRULES-2559?page=com.atlassian.jira.plugin...
]
Chris DeLashmutt updated JBRULES-2559:
--------------------------------------
Attachment: new-test-for-drools-compiler.txt
fix-with-wm-serialization-fail-drools-core.txt
Adding test with serialization failure and fix for drools-core
Problem with Collect statement from a source that is a previous
declaration after an OR'd group in MVEL dialect
---------------------------------------------------------------------------------------------------------------
Key: JBRULES-2559
URL: https://jira.jboss.org/browse/JBRULES-2559
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.1.0.M2
Reporter: Chris DeLashmutt
Assignee: Mark Proctor
Attachments: fix-with-wm-serialization-fail-drools-core.txt,
new-test-for-drools-compiler.txt
When using a Collect statement that is sourced from a nested property of a bound pattern
and it follows an OR'd group of evals, the bound pattern seems to be pointing to the
wrong object in the tuple. I have attached a diff for drools-compiler that includes a new
test case in FirstOrderLogicTest and DRL that exhibits this problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:18 p.m.
New subject: [JBoss JIRA] Assigned: (JBRULES-2559) Problem with Collect statement from a source that is a previous declaration after an OR'd group in MVEL dialect
[
https://jira.jboss.org/browse/JBRULES-2559?page=com.atlassian.jira.plugin...
]
Edson Tirelli reassigned JBRULES-2559:
--------------------------------------
Assignee: Edson Tirelli (was: Mark Proctor)
Problem with Collect statement from a source that is a previous
declaration after an OR'd group in MVEL dialect
---------------------------------------------------------------------------------------------------------------
Key: JBRULES-2559
URL: https://jira.jboss.org/browse/JBRULES-2559
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.1.0.M2
Reporter: Chris DeLashmutt
Assignee: Edson Tirelli
Attachments: fix-with-wm-serialization-fail-drools-core.txt,
new-test-for-drools-compiler.txt
When using a Collect statement that is sourced from a nested property of a bound pattern
and it follows an OR'd group of evals, the bound pattern seems to be pointing to the
wrong object in the tuple. I have attached a diff for drools-compiler that includes a new
test case in FirstOrderLogicTest and DRL that exhibits this problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:08 p.m.
New subject: [JBoss JIRA] Resolved: (JBRULES-2559) Problem with Collect statement from a source that is a previous declaration after an OR'd group in MVEL dialect
[
https://jira.jboss.org/browse/JBRULES-2559?page=com.atlassian.jira.plugin...
]
Edson Tirelli resolved JBRULES-2559.
------------------------------------
Fix Version/s: 5.1.0.CR1
Resolution: Done
Fixed. Thanks for reporting and providing patches.
Problem with Collect statement from a source that is a previous
declaration after an OR'd group in MVEL dialect
---------------------------------------------------------------------------------------------------------------
Key: JBRULES-2559
URL: https://jira.jboss.org/browse/JBRULES-2559
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.1.0.M2
Reporter: Chris DeLashmutt
Assignee: Edson Tirelli
Fix For: 5.1.0.CR1
Attachments: fix-with-wm-serialization-fail-drools-core.txt,
new-test-for-drools-compiler.txt
When using a Collect statement that is sourced from a nested property of a bound pattern
and it follows an OR'd group of evals, the bound pattern seems to be pointing to the
wrong object in the tuple. I have attached a diff for drools-compiler that includes a new
test case in FirstOrderLogicTest and DRL that exhibits this problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:10 p.m.
New subject: [JBoss JIRA] Closed: (JBRULES-2559) Problem with Collect statement from a source that is a previous declaration after an OR'd group in MVEL dialect
[
https://jira.jboss.org/browse/JBRULES-2559?page=com.atlassian.jira.plugin...
]
Edson Tirelli closed JBRULES-2559.
----------------------------------
Problem with Collect statement from a source that is a previous
declaration after an OR'd group in MVEL dialect
---------------------------------------------------------------------------------------------------------------
Key: JBRULES-2559
URL: https://jira.jboss.org/browse/JBRULES-2559
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.1.0.M2
Reporter: Chris DeLashmutt
Assignee: Edson Tirelli
Fix For: 5.1.0.CR1
Attachments: fix-with-wm-serialization-fail-drools-core.txt,
new-test-for-drools-compiler.txt
When using a Collect statement that is sourced from a nested property of a bound pattern
and it follows an OR'd group of evals, the bound pattern seems to be pointing to the
wrong object in the tuple. I have attached a diff for drools-compiler that includes a new
test case in FirstOrderLogicTest and DRL that exhibits this problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5248
days inactive
5253
days old
12 comments
2 participants
participants (2)
-
Chris DeLashmutt (JIRA) -
Edson Tirelli (JIRA)