[
https://issues.redhat.com/browse/WFLY-13221?page=com.atlassian.jira.plugi...
]
Yeray Borges Santana commented on WFLY-13221:
---------------------------------------------
I don't get at all the point of using this package schema declaration to filter out
schemas that are included in the current feature pack. Initially, sounds logical to me to
include in docs/schema any xsd included in any jar file of my feature pack. However, we
are filtering them out and remove completely the package-schemas in the
{{wildfly-feature-pack-build.xml}} does not include all.
Me as a feature pack consumer would rather expect to find out all xsd included by the
feature pack modules under docs/schema. I don't get at all why we are indeed filtering
them, won't be easier to include all instead of selectively decide what is included? I
suppose the response comes from historical reasons since legacy feature packs were also
filtering them.
[~brian.stansberry] if you have an argument to this, I would like to know the reason,
thanks.
Remove package-schema cruft from wildfly-feature-pack-build.xml
files
---------------------------------------------------------------------
Key: WFLY-13221
URL:
https://issues.redhat.com/browse/WFLY-13221
Project: WildFly
Issue Type: Task
Components: Build System
Reporter: Brian Stansberry
Assignee: Yeray Borges Santana
Priority: Minor
The various wildfly-feature-pack-build.xml files include 'package-schemas'
elements. AIUI the children of those elements only need to refer to maven groupId for
which that specific feature pack provides artifacts with schemas. It does not need to
include groupIds for artifacts from other f-ps that the f-p depends on. The WF galleon
plugin itself combines those.
So the task is
1) to clean out cruft, i.e. elements that are related to artifacts from other feature
packs. Helps clarify the expected use of these files.
2) Perhaps in the verifier tests for servlet-dist, ee-dist, dist add verification of the
presence of 1 schema from each relevant maven groupId. Guard against schemas suddenly not
getting picked up.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)